Re: [RFC PATCH] arm64: dts: allwinner: a64/h5: Add CPU idle states

2021-03-30 Thread Sudeep Holla
On Tue, Mar 23, 2021 at 11:44:50PM -0500, Samuel Holland wrote: > 3) Modify the Linux PSCI client to respect PSCI_FEATURES when setting >psci_ops.cpu_suspend. cpuidle-psci checks for this function before >setting up idle states. We don't call PSCI_FEATURES on mandatory functions as it may

Re: [RFC PATCH] arm64: dts: allwinner: a64/h5: Add CPU idle states

2021-03-30 Thread Maxime Ripard
Hi Samuel, On Tue, Mar 23, 2021 at 11:44:50PM -0500, Samuel Holland wrote: > On 3/22/21 8:56 PM, Andre Przywara wrote: > >> I'm sending this patch as an RFC because it raises questions about how > >> we handle firmware versioning. How far back does (or should) our support > >> for old TF-A and Cru

Re: [RFC PATCH] arm64: dts: allwinner: a64/h5: Add CPU idle states

2021-03-23 Thread Samuel Holland
On 3/22/21 8:56 PM, Andre Przywara wrote: >> I'm sending this patch as an RFC because it raises questions about how >> we handle firmware versioning. How far back does (or should) our support >> for old TF-A and Crust versions go? >> >> cpuidle has a problem that without working firmware support, C

Re: [RFC PATCH] arm64: dts: allwinner: a64/h5: Add CPU idle states

2021-03-22 Thread Andre Przywara
On Mon, 22 Mar 2021 01:25:14 -0500 Samuel Holland wrote: Hi, > Powering off idle CPUs saves about 33 mW compared to using WFI only. > Additional power savings are possible by idling the L2 and downclocking > the cluster when all CPUs are idle. > > Entry and exit latency were measured using a lo

[RFC PATCH] arm64: dts: allwinner: a64/h5: Add CPU idle states

2021-03-21 Thread Samuel Holland
Powering off idle CPUs saves about 33 mW compared to using WFI only. Additional power savings are possible by idling the L2 and downclocking the cluster when all CPUs are idle. Entry and exit latency were measured using a logic analyzer, with GPIO pins toggled in Linux after the calls to trace_cpu