Re: Re: [RFC PATCH] block:Fix some problems about handling plug in blk_queue_bio().

2012-08-09 Thread Shaohua Li
2012/8/8 Jianpeng Ma : > On 2012-08-08 11:06 Shaohua Li Wrote: >>2012/8/8 Jianpeng Ma : >>> I think there are three problems about handling plug in blk_queue_bio(): >>> 1:if request_count >= BLK_MAX_REQUEST_COUNT, avoid unnecessary >>> plug->should_sort judge. >>this makes sense, though not a

Re: Re: [RFC PATCH] block:Fix some problems about handling plug in blk_queue_bio().

2012-08-09 Thread Shaohua Li
2012/8/8 Jianpeng Ma majianp...@gmail.com: On 2012-08-08 11:06 Shaohua Li s...@kernel.org Wrote: 2012/8/8 Jianpeng Ma majianp...@gmail.com: I think there are three problems about handling plug in blk_queue_bio(): 1:if request_count = BLK_MAX_REQUEST_COUNT, avoid unnecessary plug-should_sort

Re: Re: [RFC PATCH] block:Fix some problems about handling plug in blk_queue_bio().

2012-08-07 Thread Jianpeng Ma
On 2012-08-08 11:06 Shaohua Li Wrote: >2012/8/8 Jianpeng Ma : >> I think there are three problems about handling plug in blk_queue_bio(): >> 1:if request_count >= BLK_MAX_REQUEST_COUNT, avoid unnecessary >> plug->should_sort judge. >this makes sense, though not a big deal, nice to fix it. Thanks

Re: [RFC PATCH] block:Fix some problems about handling plug in blk_queue_bio().

2012-08-07 Thread Shaohua Li
2012/8/8 Jianpeng Ma : > I think there are three problems about handling plug in blk_queue_bio(): > 1:if request_count >= BLK_MAX_REQUEST_COUNT, avoid unnecessary > plug->should_sort judge. this makes sense, though not a big deal, nice to fix it. > 2:Only two device can trace plug. I didn't get

[RFC PATCH] block:Fix some problems about handling plug in blk_queue_bio().

2012-08-07 Thread Jianpeng Ma
I think there are three problems about handling plug in blk_queue_bio(): 1:if request_count >= BLK_MAX_REQUEST_COUNT, avoid unnecessary plug->should_sort judge. 2:Only two device can trace plug. 3:When exec blk_flush_plug_list,it use list_sort which has O(nlog(n)) complexity. When insert and

[RFC PATCH] block:Fix some problems about handling plug in blk_queue_bio().

2012-08-07 Thread Jianpeng Ma
I think there are three problems about handling plug in blk_queue_bio(): 1:if request_count = BLK_MAX_REQUEST_COUNT, avoid unnecessary plug-should_sort judge. 2:Only two device can trace plug. 3:When exec blk_flush_plug_list,it use list_sort which has O(nlog(n)) complexity. When insert and sort,

Re: [RFC PATCH] block:Fix some problems about handling plug in blk_queue_bio().

2012-08-07 Thread Shaohua Li
2012/8/8 Jianpeng Ma majianp...@gmail.com: I think there are three problems about handling plug in blk_queue_bio(): 1:if request_count = BLK_MAX_REQUEST_COUNT, avoid unnecessary plug-should_sort judge. this makes sense, though not a big deal, nice to fix it. 2:Only two device can trace plug.

Re: Re: [RFC PATCH] block:Fix some problems about handling plug in blk_queue_bio().

2012-08-07 Thread Jianpeng Ma
On 2012-08-08 11:06 Shaohua Li s...@kernel.org Wrote: 2012/8/8 Jianpeng Ma majianp...@gmail.com: I think there are three problems about handling plug in blk_queue_bio(): 1:if request_count = BLK_MAX_REQUEST_COUNT, avoid unnecessary plug-should_sort judge. this makes sense, though not a big