Re: [RFC PATCH] e1000e: Use rtnl_lock to prevent race conditions between net and pci/pm

2019-10-07 Thread Alexander Duyck
On Mon, Oct 7, 2019 at 10:12 AM David Z. Dai wrote: > > On Mon, 2019-10-07 at 10:02 -0700, Alexander Duyck wrote: > > On Mon, Oct 7, 2019 at 8:51 AM David Z. Dai wrote: > > > > > > > > > > > > We have tested on one of the test box. > > > With this patch, it doesn't crash kernel anymore, which

Re: [RFC PATCH] e1000e: Use rtnl_lock to prevent race conditions between net and pci/pm

2019-10-07 Thread David Z. Dai
On Mon, 2019-10-07 at 10:02 -0700, Alexander Duyck wrote: > On Mon, Oct 7, 2019 at 8:51 AM David Z. Dai wrote: > > > > > > > We have tested on one of the test box. > > With this patch, it doesn't crash kernel anymore, which is good! > > > > However we see this warning message from the log file

Re: [RFC PATCH] e1000e: Use rtnl_lock to prevent race conditions between net and pci/pm

2019-10-07 Thread Alexander Duyck
On Mon, Oct 7, 2019 at 8:51 AM David Z. Dai wrote: > > We have tested on one of the test box. > With this patch, it doesn't crash kernel anymore, which is good! > > However we see this warning message from the log file for irq number 0: > [10206.317270] Trying to free already-free IRQ 0 > >

Re: [RFC PATCH] e1000e: Use rtnl_lock to prevent race conditions between net and pci/pm

2019-10-07 Thread David Z. Dai
On Sat, 2019-10-05 at 10:22 -0700, Alexander Duyck wrote: > On Fri, Oct 4, 2019 at 7:18 PM David Z. Dai wrote: > > > > On Fri, 2019-10-04 at 16:36 -0700, Alexander Duyck wrote: > > > From: Alexander Duyck > > > > > > This patch is meant to address possible race conditions that can exist > > >

Re: [RFC PATCH] e1000e: Use rtnl_lock to prevent race conditions between net and pci/pm

2019-10-05 Thread Alexander Duyck
On Fri, Oct 4, 2019 at 7:18 PM David Z. Dai wrote: > > On Fri, 2019-10-04 at 16:36 -0700, Alexander Duyck wrote: > > From: Alexander Duyck > > > > This patch is meant to address possible race conditions that can exist > > between network configuration and power management. A similar issue was >

Re: [RFC PATCH] e1000e: Use rtnl_lock to prevent race conditions between net and pci/pm

2019-10-04 Thread David Z. Dai
On Fri, 2019-10-04 at 16:36 -0700, Alexander Duyck wrote: > From: Alexander Duyck > > This patch is meant to address possible race conditions that can exist > between network configuration and power management. A similar issue was > fixed for igb in commit 9474933caf21 ("igb: close/suspend race

[RFC PATCH] e1000e: Use rtnl_lock to prevent race conditions between net and pci/pm

2019-10-04 Thread Alexander Duyck
From: Alexander Duyck This patch is meant to address possible race conditions that can exist between network configuration and power management. A similar issue was fixed for igb in commit 9474933caf21 ("igb: close/suspend race in netif_device_detach"). In addition it consolidates the code so