Re: [RFC PATCH] ext4: convert swap_inode_data() over to use swap() on most of the fields

2017-01-04 Thread Jan Kara
On Wed 04-01-17 15:21:28, Jeff Layton wrote: > On Wed, 2017-01-04 at 16:43 +0100, Jan Kara wrote: > > On Tue 20-12-16 10:55:41, Jeff Layton wrote: > > > > > > For some odd reason, it forces a byte-by-byte copy of each field. A > > > plain old swap() on most of these fields would be more efficient.

Re: [RFC PATCH] ext4: convert swap_inode_data() over to use swap() on most of the fields

2017-01-04 Thread Jeff Layton
On Wed, 2017-01-04 at 16:43 +0100, Jan Kara wrote: > On Tue 20-12-16 10:55:41, Jeff Layton wrote: > > > > For some odd reason, it forces a byte-by-byte copy of each field. A > > plain old swap() on most of these fields would be more efficient. We > > do need to retain one memswap however as that f

Re: [RFC PATCH] ext4: convert swap_inode_data() over to use swap() on most of the fields

2017-01-04 Thread Jan Kara
On Tue 20-12-16 10:55:41, Jeff Layton wrote: > For some odd reason, it forces a byte-by-byte copy of each field. A > plain old swap() on most of these fields would be more efficient. We > do need to retain one memswap however as that field is an array. > > Signed-off-by: Jeff Layton Looks good t

[RFC PATCH] ext4: convert swap_inode_data() over to use swap() on most of the fields

2016-12-20 Thread Jeff Layton
For some odd reason, it forces a byte-by-byte copy of each field. A plain old swap() on most of these fields would be more efficient. We do need to retain one memswap however as that field is an array. Signed-off-by: Jeff Layton --- fs/ext4/ioctl.c | 18 -- 1 file changed, 8 inse