Re: [RFC PATCH] fs/binfmt_elf.c: fix inconsistent vma dump size

2014-11-26 Thread Jungseung Lee
2014-11-26 21:43 GMT+09:00 Andrew Morton : > On Wed, 26 Nov 2014 21:37:54 +0900 Jungseung Lee wrote: > >> 2014-11-26 15:51 GMT+09:00 Jungseung Lee : >> >> >>> @@ -2093,7 +2083,20 @@ static int elf_core_dump(struct coredump_params >> >>> *cprm) >> >>> >> >>> dataoff = offset = roundup(offset

Re: [RFC PATCH] fs/binfmt_elf.c: fix inconsistent vma dump size

2014-11-26 Thread Andrew Morton
On Wed, 26 Nov 2014 21:37:54 +0900 Jungseung Lee wrote: > 2014-11-26 15:51 GMT+09:00 Jungseung Lee : > > >>> @@ -2093,7 +2083,20 @@ static int elf_core_dump(struct coredump_params > >>> *cprm) > >>> > >>> dataoff = offset = roundup(offset, ELF_EXEC_PAGESIZE); > >>> > >>> - offset += e

Re: [RFC PATCH] fs/binfmt_elf.c: fix inconsistent vma dump size

2014-11-26 Thread Jungseung Lee
2014-11-26 15:51 GMT+09:00 Jungseung Lee : >>> @@ -2093,7 +2083,20 @@ static int elf_core_dump(struct coredump_params >>> *cprm) >>> >>> dataoff = offset = roundup(offset, ELF_EXEC_PAGESIZE); >>> >>> - offset += elf_core_vma_data_size(gate_vma, cprm->mm_flags); >>> + vma_filesz = km

Re: [RFC PATCH] fs/binfmt_elf.c: fix inconsistent vma dump size

2014-11-25 Thread Jungseung Lee
Hello, Andrew. 2014-11-26 6:38 GMT+09:00 Andrew Morton : > On Sun, 23 Nov 2014 04:16:39 +0900 Jungseung Lee wrote: > >> vma_dump_size() has been used several times on actual dumper >> and it is supposed to be same values for same vma. >> But vma_dump_size() could be different, while coredump is p

Re: [RFC PATCH] fs/binfmt_elf.c: fix inconsistent vma dump size

2014-11-25 Thread Andrew Morton
On Sun, 23 Nov 2014 04:16:39 +0900 Jungseung Lee wrote: > vma_dump_size() has been used several times on actual dumper > and it is supposed to be same values for same vma. > But vma_dump_size() could be different, while coredump is procceeded. > (e.g. remove shared memory) > > In that case, head

[RFC PATCH] fs/binfmt_elf.c: fix inconsistent vma dump size

2014-11-22 Thread Jungseung Lee
vma_dump_size() has been used several times on actual dumper and it is supposed to be same values for same vma. But vma_dump_size() could be different, while coredump is procceeded. (e.g. remove shared memory) In that case, header info and vma size could be inconsistent and it cause wrong coredump