Re: [RFC PATCH] fs: Make splice() and tee() take into account O_NONBLOCK flag on pipes

2019-03-04 Thread Steven Rostedt
[ Replying again, but without Cc'ing Trump due to a bug in claws-mail ] On Mon, 4 Mar 2019 16:09:22 -0800 Linus Torvalds wrote: > > Note that the "arguably buggy" argument is not an actual real argument Note that "arguably buggy" just means that you can argue that it is buggy. It doesn't actu

Re: [RFC PATCH] fs: Make splice() and tee() take into account O_NONBLOCK flag on pipes

2019-03-04 Thread Linus Torvalds
On Mon, Mar 4, 2019 at 4:04 PM Linus Torvalds wrote: > > Of course, if it turns out that this breaks something that assumes > that splice blocks purely based on the SPLICE_F_NONBLOCK flag, we'll > have to revert it. Looking at the history of splice, it does look like > it has always ignored O_NONB

Re: [RFC PATCH] fs: Make splice() and tee() take into account O_NONBLOCK flag on pipes

2019-03-04 Thread Linus Torvalds
On Mon, Mar 4, 2019 at 7:58 AM Steven Rostedt wrote: > > I'm still just hearing crickets about this? Should I just send this > directly to Linus or Andrew? I'll take it. It looks sane. Of course, if it turns out that this breaks something that assumes that splice blocks purely based on the SPLIC

Re: [RFC PATCH] fs: Make splice() and tee() take into account O_NONBLOCK flag on pipes

2019-03-04 Thread Steven Rostedt
On Tue, 19 Feb 2019 12:12:12 -0500 Steven Rostedt wrote: > On Wed, 13 Feb 2019 09:44:45 -0500 > Steven Rostedt wrote: > > > Reviewed-by: Steven Rostedt (VMware) > > > > Does anyone have any issues or comments about this patch? > > I'm going to start pinging people once a week, looking for

Re: [RFC PATCH] fs: Make splice() and tee() take into account O_NONBLOCK flag on pipes

2019-02-19 Thread Steven Rostedt
On Wed, 13 Feb 2019 09:44:45 -0500 Steven Rostedt wrote: > Reviewed-by: Steven Rostedt (VMware) > > Does anyone have any issues or comments about this patch? I'm going to start pinging people once a week, looking for comments on this patch ;-) -- Steve

Re: [RFC PATCH] fs: Make splice() and tee() take into account O_NONBLOCK flag on pipes

2019-02-13 Thread Steven Rostedt
On Thu, 7 Feb 2019 17:45:19 +0200 Slavomir Kaslev wrote: > The current implementation of splice() and tee() ignores O_NONBLOCK set on > pipe > file descriptors and checks only the SPLICE_F_NONBLOCK flag for blocking on > pipe > arguments. This is inconsistent since splice()-ing from/to non-pip

[RFC PATCH] fs: Make splice() and tee() take into account O_NONBLOCK flag on pipes

2019-02-07 Thread Slavomir Kaslev
The current implementation of splice() and tee() ignores O_NONBLOCK set on pipe file descriptors and checks only the SPLICE_F_NONBLOCK flag for blocking on pipe arguments. This is inconsistent since splice()-ing from/to non-pipe file descriptors does take O_NONBLOCK into consideration. Fix this by