Re: [RFC PATCH] ftrace: Skip __fentry__ location of overridden weak functions

2024-06-11 Thread Zheng Yejian
On 2024/6/11 17:21, Peter Zijlstra wrote: On Tue, Jun 11, 2024 at 09:56:51AM +0800, Zheng Yejian wrote: On 2024/6/7 23:02, Peter Zijlstra wrote: Oh gawd, sodding weak functions again. I would suggest changing scipts/kallsyms.c to emit readily identifiable symbol names for all the weak junk,

Re: [RFC PATCH] ftrace: Skip __fentry__ location of overridden weak functions

2024-06-11 Thread Peter Zijlstra
On Tue, Jun 11, 2024 at 09:56:51AM +0800, Zheng Yejian wrote: > On 2024/6/7 23:02, Peter Zijlstra wrote: > > Oh gawd, sodding weak functions again. > > > > I would suggest changing scipts/kallsyms.c to emit readily identifiable > > symbol names for all the weak junk, eg: > > > >__weak_junk_N

Re: [RFC PATCH] ftrace: Skip __fentry__ location of overridden weak functions

2024-06-10 Thread Zheng Yejian
On 2024/6/7 23:02, Peter Zijlstra wrote: On Fri, Jun 07, 2024 at 07:52:11PM +0800, Zheng Yejian wrote: ftrace_location() was changed to not only return the __fentry__ location when called for the __fentry__ location, but also when called for the sym+0 location after commit aebfd12521d9 ("x86/ibt

Re: [RFC PATCH] ftrace: Skip __fentry__ location of overridden weak functions

2024-06-07 Thread Steven Rostedt
On Fri, 7 Jun 2024 17:02:28 +0200 Peter Zijlstra wrote: > > There may be following resolutions: > > Oh gawd, sodding weak functions again. > > I would suggest changing scipts/kallsyms.c to emit readily identifiable > symbol names for all the weak junk, eg: > > __weak_junk_N > > That i

Re: [RFC PATCH] ftrace: Skip __fentry__ location of overridden weak functions

2024-06-07 Thread Peter Zijlstra
On Fri, Jun 07, 2024 at 07:52:11PM +0800, Zheng Yejian wrote: > ftrace_location() was changed to not only return the __fentry__ location > when called for the __fentry__ location, but also when called for the > sym+0 location after commit aebfd12521d9 ("x86/ibt,ftrace: Search for > __fentry__ locat

[RFC PATCH] ftrace: Skip __fentry__ location of overridden weak functions

2024-06-07 Thread Zheng Yejian
ftrace_location() was changed to not only return the __fentry__ location when called for the __fentry__ location, but also when called for the sym+0 location after commit aebfd12521d9 ("x86/ibt,ftrace: Search for __fentry__ location"). That is, if sym+0 location is not __fentry__, ftrace_location()