Re: [RFC PATCH] iio: ak8975: Make sure chipset is always initialized

2015-01-23 Thread Pandruvada, Srinivas
On Sat, 2015-01-24 at 00:38 +0100, Hartmut Knaack wrote: > Pandruvada, Srinivas schrieb am 19.01.2015 um 17:56: > > On Mon, 2015-01-19 at 18:49 +0200, Daniel Baluta wrote: > >> On Mon, Jan 19, 2015 at 6:44 PM, Pandruvada, Srinivas > >> wrote: > >>> On Mon, 2015-01-19 at 16:40 +0200, Daniel Baluta

Re: [RFC PATCH] iio: ak8975: Make sure chipset is always initialized

2015-01-23 Thread Hartmut Knaack
Pandruvada, Srinivas schrieb am 19.01.2015 um 17:56: > On Mon, 2015-01-19 at 18:49 +0200, Daniel Baluta wrote: >> On Mon, Jan 19, 2015 at 6:44 PM, Pandruvada, Srinivas >> wrote: >>> On Mon, 2015-01-19 at 16:40 +0200, Daniel Baluta wrote: Hello, On Sat, Dec 20, 2014 at 11:29 PM, Pan

Re: [RFC PATCH] iio: ak8975: Make sure chipset is always initialized

2015-01-19 Thread Pandruvada, Srinivas
On Mon, 2015-01-19 at 18:49 +0200, Daniel Baluta wrote: > On Mon, Jan 19, 2015 at 6:44 PM, Pandruvada, Srinivas > wrote: > > On Mon, 2015-01-19 at 16:40 +0200, Daniel Baluta wrote: > >> Hello, > >> > >> On Sat, Dec 20, 2014 at 11:29 PM, Pandruvada, Srinivas > >> wrote: > >> > +Mika > >> > > >> >

Re: [RFC PATCH] iio: ak8975: Make sure chipset is always initialized

2015-01-19 Thread Daniel Baluta
On Mon, Jan 19, 2015 at 6:44 PM, Pandruvada, Srinivas wrote: > On Mon, 2015-01-19 at 16:40 +0200, Daniel Baluta wrote: >> Hello, >> >> On Sat, Dec 20, 2014 at 11:29 PM, Pandruvada, Srinivas >> wrote: >> > +Mika >> > >> > On Sat, 2014-12-20 at 13:26 -0800, Srinivas Pandruvada wrote: >> >> On Sat,

Re: [RFC PATCH] iio: ak8975: Make sure chipset is always initialized

2015-01-19 Thread Pandruvada, Srinivas
On Mon, 2015-01-19 at 16:40 +0200, Daniel Baluta wrote: > Hello, > > On Sat, Dec 20, 2014 at 11:29 PM, Pandruvada, Srinivas > wrote: > > +Mika > > > > On Sat, 2014-12-20 at 13:26 -0800, Srinivas Pandruvada wrote: > >> On Sat, 2014-12-20 at 00:25 +0200, Daniel Baluta wrote: > >> > On Sat, Dec 20,

Re: [RFC PATCH] iio: ak8975: Make sure chipset is always initialized

2015-01-19 Thread Daniel Baluta
Hello, On Sat, Dec 20, 2014 at 11:29 PM, Pandruvada, Srinivas wrote: > +Mika > > On Sat, 2014-12-20 at 13:26 -0800, Srinivas Pandruvada wrote: >> On Sat, 2014-12-20 at 00:25 +0200, Daniel Baluta wrote: >> > On Sat, Dec 20, 2014 at 12:16 AM, Hartmut Knaack wrote: >> > > Daniel Baluta schrieb am 1

Re: [RFC PATCH] iio: ak8975: Make sure chipset is always initialized

2014-12-20 Thread Daniel Baluta
I will have closer look on why acpi_match_device could fail. This patch was only based on code reading when trying to fix the compiler warning mentioned in the commit message. [Sorry for top posting] On Sat, Dec 20, 2014 at 11:29 PM, Pandruvada, Srinivas wrote: > +Mika > > On Sat, 2014-12-20 at

Re: [RFC PATCH] iio: ak8975: Make sure chipset is always initialized

2014-12-20 Thread Pandruvada, Srinivas
+Mika On Sat, 2014-12-20 at 13:26 -0800, Srinivas Pandruvada wrote: > On Sat, 2014-12-20 at 00:25 +0200, Daniel Baluta wrote: > > On Sat, Dec 20, 2014 at 12:16 AM, Hartmut Knaack wrote: > > > Daniel Baluta schrieb am 18.12.2014 um 18:16: > > >> When using ACPI, if acpi_match_device fails then chi

Re: [RFC PATCH] iio: ak8975: Make sure chipset is always initialized

2014-12-20 Thread Srinivas Pandruvada
On Sat, 2014-12-20 at 00:25 +0200, Daniel Baluta wrote: > On Sat, Dec 20, 2014 at 12:16 AM, Hartmut Knaack wrote: > > Daniel Baluta schrieb am 18.12.2014 um 18:16: > >> When using ACPI, if acpi_match_device fails then chipset enum will be > >> uninitialized and &ak_def_array[chipset] will point to

Re: [RFC PATCH] iio: ak8975: Make sure chipset is always initialized

2014-12-19 Thread Daniel Baluta
On Sat, Dec 20, 2014 at 12:16 AM, Hartmut Knaack wrote: > Daniel Baluta schrieb am 18.12.2014 um 18:16: >> When using ACPI, if acpi_match_device fails then chipset enum will be >> uninitialized and &ak_def_array[chipset] will point to some bad address. >> >> This fixes the following compilation wa

Re: [RFC PATCH] iio: ak8975: Make sure chipset is always initialized

2014-12-19 Thread Hartmut Knaack
Daniel Baluta schrieb am 18.12.2014 um 18:16: > When using ACPI, if acpi_match_device fails then chipset enum will be > uninitialized and &ak_def_array[chipset] will point to some bad address. > > This fixes the following compilation warning: > > drivers/iio/magnetometer/ak8975.c: In function ‘ak

[RFC PATCH] iio: ak8975: Make sure chipset is always initialized

2014-12-18 Thread Daniel Baluta
When using ACPI, if acpi_match_device fails then chipset enum will be uninitialized and &ak_def_array[chipset] will point to some bad address. This fixes the following compilation warning: drivers/iio/magnetometer/ak8975.c: In function ‘ak8975_probe’: drivers/iio/magnetometer/ak8975.c:788:14: war