Re: [RFC PATCH] irqchip/gic-v3: Make gic_handle_irq() notrace

2019-04-03 Thread liwei (GF)
Hi Julien, On 2019/4/2 22:00, Julien Thierry wrote: I meet this issue by coincidence before too. > I finally found out what happens. > > When using interrupt priority masking, at the begining of > gic_handle_irq(), we are in this awkward state where we still have the I > bit set and PMR unmasked

Re: [RFC PATCH] irqchip/gic-v3: Make gic_handle_irq() notrace

2019-04-02 Thread Julien Thierry
Hi, On 29/03/2019 15:02, Zenghui Yu wrote: > Hi Marc, > > On 2019/3/29 21:58, Marc Zyngier wrote: >> Hi Zenghui, >> >> On 29/03/2019 13:23, Zenghui Yu wrote: >>> Enable pseudo NMI together with function_graph tracer, will lead >>> the system to a hang. This is easy to reproduce, >>> >>>    1) Set

Re: [RFC PATCH] irqchip/gic-v3: Make gic_handle_irq() notrace

2019-03-29 Thread Zenghui Yu
On Fri, Mar 29, 2019 at 11:46 PM Steven Rostedt wrote: > > On Fri, 29 Mar 2019 23:35:59 +0800 > Zenghui Yu wrote: > > > Hi Steven, > > > > On 2019/3/29 22:53, Steven Rostedt wrote: > > > On Fri, 29 Mar 2019 13:58:40 + > > > Marc Zyngier wrote: > > > > > >> On the other hand, if you can gener

Re: [RFC PATCH] irqchip/gic-v3: Make gic_handle_irq() notrace

2019-03-29 Thread Steven Rostedt
On Fri, 29 Mar 2019 23:35:59 +0800 Zenghui Yu wrote: > Hi Steven, > > On 2019/3/29 22:53, Steven Rostedt wrote: > > On Fri, 29 Mar 2019 13:58:40 + > > Marc Zyngier wrote: > > > >> On the other hand, if you can generate pseudo-NMIs, you could end-up > >> tracing gic_handle_irq whilst bein

Re: [RFC PATCH] irqchip/gic-v3: Make gic_handle_irq() notrace

2019-03-29 Thread Zenghui Yu
Hi Steven, On 2019/3/29 22:53, Steven Rostedt wrote: On Fri, 29 Mar 2019 13:58:40 + Marc Zyngier wrote: On the other hand, if you can generate pseudo-NMIs, you could end-up tracing gic_handle_irq whilst being inside the tracing code with interrupts being notionally disabled (and that coul

Re: [RFC PATCH] irqchip/gic-v3: Make gic_handle_irq() notrace

2019-03-29 Thread Zenghui Yu
Hi Marc, On 2019/3/29 21:58, Marc Zyngier wrote: Hi Zenghui, On 29/03/2019 13:23, Zenghui Yu wrote: Enable pseudo NMI together with function_graph tracer, will lead the system to a hang. This is easy to reproduce, 1) Set "irqchip.gicv3_pseudo_nmi=1" on the kernel command line 2) echo fu

Re: [RFC PATCH] irqchip/gic-v3: Make gic_handle_irq() notrace

2019-03-29 Thread Steven Rostedt
On Fri, 29 Mar 2019 13:58:40 + Marc Zyngier wrote: > On the other hand, if you can generate pseudo-NMIs, you could end-up > tracing gic_handle_irq whilst being inside the tracing code with > interrupts being notionally disabled (and that could be pretty bad). Actually, that should still be s

Re: [RFC PATCH] irqchip/gic-v3: Make gic_handle_irq() notrace

2019-03-29 Thread Marc Zyngier
Hi Zenghui, On 29/03/2019 13:23, Zenghui Yu wrote: > Enable pseudo NMI together with function_graph tracer, will lead > the system to a hang. This is easy to reproduce, > > 1) Set "irqchip.gicv3_pseudo_nmi=1" on the kernel command line > 2) echo function_graph > /sys/kernel/debug/tracing/curr

[RFC PATCH] irqchip/gic-v3: Make gic_handle_irq() notrace

2019-03-29 Thread Zenghui Yu
Enable pseudo NMI together with function_graph tracer, will lead the system to a hang. This is easy to reproduce, 1) Set "irqchip.gicv3_pseudo_nmi=1" on the kernel command line 2) echo function_graph > /sys/kernel/debug/tracing/current_tracer This patch (RFC) set gic_handle_irq() as notrace a