Re: [RFC PATCH] mm, oom: disable dump_tasks by default

2019-09-06 Thread Tetsuo Handa
On 2019/09/06 20:02, Michal Hocko wrote: > On Fri 06-09-19 19:46:10, Tetsuo Handa wrote: >> On 2019/09/05 23:08, Michal Hocko wrote: >>> On Thu 05-09-19 22:39:47, Tetsuo Handa wrote: >>> [...] There is nothing that prevents users from enabling oom_dump_tasks by sysctl. But that

Re: [RFC PATCH] mm, oom: disable dump_tasks by default

2019-09-06 Thread Michal Hocko
On Fri 06-09-19 19:46:10, Tetsuo Handa wrote: > On 2019/09/05 23:08, Michal Hocko wrote: > > On Thu 05-09-19 22:39:47, Tetsuo Handa wrote: > > [...] > >> There is nothing that prevents users from enabling oom_dump_tasks by > >> sysctl. > >> But that requires a solution for OOM stalling problem. >

Re: [RFC PATCH] mm, oom: disable dump_tasks by default

2019-09-06 Thread Tetsuo Handa
On 2019/09/05 23:08, Michal Hocko wrote: > On Thu 05-09-19 22:39:47, Tetsuo Handa wrote: > [...] >> There is nothing that prevents users from enabling oom_dump_tasks by sysctl. >> But that requires a solution for OOM stalling problem. > > You can hardly remove stalling if you are not reducing the

Re: [RFC PATCH] mm, oom: disable dump_tasks by default

2019-09-05 Thread Qian Cai
On Tue, 2019-09-03 at 17:13 +0200, Michal Hocko wrote: > On Tue 03-09-19 11:02:46, Qian Cai wrote: > > On Tue, 2019-09-03 at 16:45 +0200, Michal Hocko wrote: > > > From: Michal Hocko > > > > > > dump_tasks has been introduced by quite some time ago fef1bdd68c81 > > > ("oom: add sysctl to enable

Re: [RFC PATCH] mm, oom: disable dump_tasks by default

2019-09-05 Thread Michal Hocko
On Thu 05-09-19 22:39:47, Tetsuo Handa wrote: [...] > There is nothing that prevents users from enabling oom_dump_tasks by sysctl. > But that requires a solution for OOM stalling problem. You can hardly remove stalling if you are not reducing the amount of output or get it into a different

Re: [RFC PATCH] mm, oom: disable dump_tasks by default

2019-09-05 Thread Tetsuo Handa
On 2019/09/05 5:04, David Rientjes wrote: > On Wed, 4 Sep 2019, Michal Hocko wrote: > It's primary purpose is to help analyse oom victim selection decision. >>> >>> I disagree, for I use the process list for understanding what / how many >>> processes are consuming what kind of memory

Re: [RFC PATCH] mm, oom: disable dump_tasks by default

2019-09-04 Thread David Rientjes
On Wed, 4 Sep 2019, Michal Hocko wrote: > > > It's primary purpose is > > > to help analyse oom victim selection decision. > > > > I disagree, for I use the process list for understanding what / how many > > processes are consuming what kind of memory (without crashing the system) > > for

Re: [RFC PATCH] mm, oom: disable dump_tasks by default

2019-09-03 Thread Michal Hocko
On Wed 04-09-19 05:52:43, Tetsuo Handa wrote: > On 2019/09/03 23:45, Michal Hocko wrote: > > It's primary purpose is > > to help analyse oom victim selection decision. > > I disagree, for I use the process list for understanding what / how many > processes are consuming what kind of memory

Re: [RFC PATCH] mm, oom: disable dump_tasks by default

2019-09-03 Thread Tetsuo Handa
On 2019/09/03 23:45, Michal Hocko wrote: > It's primary purpose is > to help analyse oom victim selection decision. I disagree, for I use the process list for understanding what / how many processes are consuming what kind of memory (without crashing the system) for anomaly detection purpose.

Re: [RFC PATCH] mm, oom: disable dump_tasks by default

2019-09-03 Thread Michal Hocko
On Tue 03-09-19 11:32:58, Qian Cai wrote: > On Tue, 2019-09-03 at 17:13 +0200, Michal Hocko wrote: > > On Tue 03-09-19 11:02:46, Qian Cai wrote: > > > On Tue, 2019-09-03 at 16:45 +0200, Michal Hocko wrote: > > > > From: Michal Hocko > > > > > > > > dump_tasks has been introduced by quite some

Re: [RFC PATCH] mm, oom: disable dump_tasks by default

2019-09-03 Thread Qian Cai
On Tue, 2019-09-03 at 17:13 +0200, Michal Hocko wrote: > On Tue 03-09-19 11:02:46, Qian Cai wrote: > > On Tue, 2019-09-03 at 16:45 +0200, Michal Hocko wrote: > > > From: Michal Hocko > > > > > > dump_tasks has been introduced by quite some time ago fef1bdd68c81 > > > ("oom: add sysctl to enable

Re: [RFC PATCH] mm, oom: disable dump_tasks by default

2019-09-03 Thread Michal Hocko
On Tue 03-09-19 11:02:46, Qian Cai wrote: > On Tue, 2019-09-03 at 16:45 +0200, Michal Hocko wrote: > > From: Michal Hocko > > > > dump_tasks has been introduced by quite some time ago fef1bdd68c81 > > ("oom: add sysctl to enable task memory dump"). It's primary purpose is > > to help analyse oom

Re: [RFC PATCH] mm, oom: disable dump_tasks by default

2019-09-03 Thread Qian Cai
On Tue, 2019-09-03 at 16:45 +0200, Michal Hocko wrote: > From: Michal Hocko > > dump_tasks has been introduced by quite some time ago fef1bdd68c81 > ("oom: add sysctl to enable task memory dump"). It's primary purpose is > to help analyse oom victim selection decision. This has been certainly >

[RFC PATCH] mm, oom: disable dump_tasks by default

2019-09-03 Thread Michal Hocko
From: Michal Hocko dump_tasks has been introduced by quite some time ago fef1bdd68c81 ("oom: add sysctl to enable task memory dump"). It's primary purpose is to help analyse oom victim selection decision. This has been certainly useful at times when the heuristic to chose a victim was much more