Re: [RFC PATCH] mm/page_alloc.c: clean code by merging two functions

2020-09-21 Thread Mel Gorman
On Mon, Sep 21, 2020 at 03:36:07PM +0300, Mike Rapoport wrote: > Hi, > > (added Mel) > > On Wed, Sep 16, 2020 at 01:01:18PM +0200, mateusznos...@gmail.com wrote: > > From: Mateusz Nosek > > > > The 'finalise_ac' function is just 'epilogue' for 'prepare_alloc_pages'. > > Therefore there is no ne

Re: [RFC PATCH] mm/page_alloc.c: clean code by merging two functions

2020-09-21 Thread Mike Rapoport
Hi, (added Mel) On Wed, Sep 16, 2020 at 01:01:18PM +0200, mateusznos...@gmail.com wrote: > From: Mateusz Nosek > > The 'finalise_ac' function is just 'epilogue' for 'prepare_alloc_pages'. > Therefore there is no need to keep them both so 'finalise_ac' content can > be merged into 'prepare_alloc

[RFC PATCH] mm/page_alloc.c: clean code by merging two functions

2020-09-16 Thread mateusznosek0
From: Mateusz Nosek The 'finalise_ac' function is just 'epilogue' for 'prepare_alloc_pages'. Therefore there is no need to keep them both so 'finalise_ac' content can be merged into 'prepare_alloc_pages' code. It would make '__alloc_pages_nodemask' cleaner when it comes to readability. Signed-of