Re: [RFC PATCH] mm/zsmalloc: remove unnecessary check

2014-11-23 Thread Minchan Kim
Hello Ganesh, On Fri, Nov 21, 2014 at 10:56:10PM +0800, Ganesh Mahendran wrote: > Hello Minchan > > 2014-11-21 18:32 GMT+08:00 Minchan Kim : > > On Fri, Nov 21, 2014 at 06:48:49AM +, Minchan Kim wrote: > >> On Fri, Nov 21, 2014 at 01:33:26PM +0800, Ganesh Mahendran wrote: > >> > Hello > >> >

Re: [RFC PATCH] mm/zsmalloc: remove unnecessary check

2014-11-23 Thread Minchan Kim
Hello Ganesh, On Fri, Nov 21, 2014 at 10:56:10PM +0800, Ganesh Mahendran wrote: Hello Minchan 2014-11-21 18:32 GMT+08:00 Minchan Kim minc...@kernel.org: On Fri, Nov 21, 2014 at 06:48:49AM +, Minchan Kim wrote: On Fri, Nov 21, 2014 at 01:33:26PM +0800, Ganesh Mahendran wrote: Hello

Re: [RFC PATCH] mm/zsmalloc: remove unnecessary check

2014-11-21 Thread Ganesh Mahendran
Hello Minchan 2014-11-21 18:32 GMT+08:00 Minchan Kim : > On Fri, Nov 21, 2014 at 06:48:49AM +, Minchan Kim wrote: >> On Fri, Nov 21, 2014 at 01:33:26PM +0800, Ganesh Mahendran wrote: >> > Hello >> > >> > 2014-11-21 11:54 GMT+08:00 Minchan Kim : >> > > On Thu, Nov 20, 2014 at 09:21:56PM +0800,

Re: [RFC PATCH] mm/zsmalloc: remove unnecessary check

2014-11-21 Thread Minchan Kim
On Fri, Nov 21, 2014 at 06:48:49AM +, Minchan Kim wrote: > On Fri, Nov 21, 2014 at 01:33:26PM +0800, Ganesh Mahendran wrote: > > Hello > > > > 2014-11-21 11:54 GMT+08:00 Minchan Kim : > > > On Thu, Nov 20, 2014 at 09:21:56PM +0800, Mahendran Ganesh wrote: > > >> ZS_SIZE_CLASSES is calc by: >

Re: [RFC PATCH] mm/zsmalloc: remove unnecessary check

2014-11-21 Thread Minchan Kim
On Fri, Nov 21, 2014 at 06:48:49AM +, Minchan Kim wrote: On Fri, Nov 21, 2014 at 01:33:26PM +0800, Ganesh Mahendran wrote: Hello 2014-11-21 11:54 GMT+08:00 Minchan Kim minc...@kernel.org: On Thu, Nov 20, 2014 at 09:21:56PM +0800, Mahendran Ganesh wrote: ZS_SIZE_CLASSES is calc

Re: [RFC PATCH] mm/zsmalloc: remove unnecessary check

2014-11-21 Thread Ganesh Mahendran
Hello Minchan 2014-11-21 18:32 GMT+08:00 Minchan Kim minc...@kernel.org: On Fri, Nov 21, 2014 at 06:48:49AM +, Minchan Kim wrote: On Fri, Nov 21, 2014 at 01:33:26PM +0800, Ganesh Mahendran wrote: Hello 2014-11-21 11:54 GMT+08:00 Minchan Kim minc...@kernel.org: On Thu, Nov 20, 2014

Re: [RFC PATCH] mm/zsmalloc: remove unnecessary check

2014-11-20 Thread Minchan Kim
On Fri, Nov 21, 2014 at 01:33:26PM +0800, Ganesh Mahendran wrote: > Hello > > 2014-11-21 11:54 GMT+08:00 Minchan Kim : > > On Thu, Nov 20, 2014 at 09:21:56PM +0800, Mahendran Ganesh wrote: > >> ZS_SIZE_CLASSES is calc by: > >> ((ZS_MAX_ALLOC_SIZE - ZS_MIN_ALLOC_SIZE) / ZS_SIZE_CLASS_DELTA + 1)

Re: [RFC PATCH] mm/zsmalloc: remove unnecessary check

2014-11-20 Thread Ganesh Mahendran
Hello 2014-11-21 11:54 GMT+08:00 Minchan Kim : > On Thu, Nov 20, 2014 at 09:21:56PM +0800, Mahendran Ganesh wrote: >> ZS_SIZE_CLASSES is calc by: >> ((ZS_MAX_ALLOC_SIZE - ZS_MIN_ALLOC_SIZE) / ZS_SIZE_CLASS_DELTA + 1) >> >> So when i is in [0, ZS_SIZE_CLASSES - 1), the size: >> size =

Re: [RFC PATCH] mm/zsmalloc: remove unnecessary check

2014-11-20 Thread Minchan Kim
On Thu, Nov 20, 2014 at 09:21:56PM +0800, Mahendran Ganesh wrote: > ZS_SIZE_CLASSES is calc by: > ((ZS_MAX_ALLOC_SIZE - ZS_MIN_ALLOC_SIZE) / ZS_SIZE_CLASS_DELTA + 1) > > So when i is in [0, ZS_SIZE_CLASSES - 1), the size: > size = ZS_MIN_ALLOC_SIZE + i * ZS_SIZE_CLASS_DELTA > will not be

[RFC PATCH] mm/zsmalloc: remove unnecessary check

2014-11-20 Thread Mahendran Ganesh
ZS_SIZE_CLASSES is calc by: ((ZS_MAX_ALLOC_SIZE - ZS_MIN_ALLOC_SIZE) / ZS_SIZE_CLASS_DELTA + 1) So when i is in [0, ZS_SIZE_CLASSES - 1), the size: size = ZS_MIN_ALLOC_SIZE + i * ZS_SIZE_CLASS_DELTA will not be greater than ZS_MAX_ALLOC_SIZE This patch removes the unnecessary check.

[RFC PATCH] mm/zsmalloc: remove unnecessary check

2014-11-20 Thread Mahendran Ganesh
ZS_SIZE_CLASSES is calc by: ((ZS_MAX_ALLOC_SIZE - ZS_MIN_ALLOC_SIZE) / ZS_SIZE_CLASS_DELTA + 1) So when i is in [0, ZS_SIZE_CLASSES - 1), the size: size = ZS_MIN_ALLOC_SIZE + i * ZS_SIZE_CLASS_DELTA will not be greater than ZS_MAX_ALLOC_SIZE This patch removes the unnecessary check.

Re: [RFC PATCH] mm/zsmalloc: remove unnecessary check

2014-11-20 Thread Minchan Kim
On Thu, Nov 20, 2014 at 09:21:56PM +0800, Mahendran Ganesh wrote: ZS_SIZE_CLASSES is calc by: ((ZS_MAX_ALLOC_SIZE - ZS_MIN_ALLOC_SIZE) / ZS_SIZE_CLASS_DELTA + 1) So when i is in [0, ZS_SIZE_CLASSES - 1), the size: size = ZS_MIN_ALLOC_SIZE + i * ZS_SIZE_CLASS_DELTA will not be greater

Re: [RFC PATCH] mm/zsmalloc: remove unnecessary check

2014-11-20 Thread Ganesh Mahendran
Hello 2014-11-21 11:54 GMT+08:00 Minchan Kim minc...@kernel.org: On Thu, Nov 20, 2014 at 09:21:56PM +0800, Mahendran Ganesh wrote: ZS_SIZE_CLASSES is calc by: ((ZS_MAX_ALLOC_SIZE - ZS_MIN_ALLOC_SIZE) / ZS_SIZE_CLASS_DELTA + 1) So when i is in [0, ZS_SIZE_CLASSES - 1), the size: size =

Re: [RFC PATCH] mm/zsmalloc: remove unnecessary check

2014-11-20 Thread Minchan Kim
On Fri, Nov 21, 2014 at 01:33:26PM +0800, Ganesh Mahendran wrote: Hello 2014-11-21 11:54 GMT+08:00 Minchan Kim minc...@kernel.org: On Thu, Nov 20, 2014 at 09:21:56PM +0800, Mahendran Ganesh wrote: ZS_SIZE_CLASSES is calc by: ((ZS_MAX_ALLOC_SIZE - ZS_MIN_ALLOC_SIZE) /