Re: [RFC PATCH] mm: vmscan: do not iterate all mem cgroups for global direct reclaim

2019-01-25 Thread Yang Shi
On 1/24/19 12:43 AM, Michal Hocko wrote: On Wed 23-01-19 12:24:38, Yang Shi wrote: On 1/23/19 1:59 AM, Michal Hocko wrote: On Wed 23-01-19 04:09:42, Yang Shi wrote: In current implementation, both kswapd and direct reclaim has to iterate all mem cgroups. It is not a problem before offline

Re: [RFC PATCH] mm: vmscan: do not iterate all mem cgroups for global direct reclaim

2019-01-24 Thread Michal Hocko
On Wed 23-01-19 12:24:38, Yang Shi wrote: > > > On 1/23/19 1:59 AM, Michal Hocko wrote: > > On Wed 23-01-19 04:09:42, Yang Shi wrote: > > > In current implementation, both kswapd and direct reclaim has to iterate > > > all mem cgroups. It is not a problem before offline mem cgroups could > > > b

Re: [RFC PATCH] mm: vmscan: do not iterate all mem cgroups for global direct reclaim

2019-01-23 Thread Yang Shi
On 1/23/19 1:59 AM, Michal Hocko wrote: On Wed 23-01-19 04:09:42, Yang Shi wrote: In current implementation, both kswapd and direct reclaim has to iterate all mem cgroups. It is not a problem before offline mem cgroups could be iterated. But, currently with iterating offline mem cgroups, it

Re: [RFC PATCH] mm: vmscan: do not iterate all mem cgroups for global direct reclaim

2019-01-23 Thread Michal Hocko
On Wed 23-01-19 14:05:28, Kirill Tkhai wrote: > On 23.01.2019 14:02, Michal Hocko wrote: > > On Wed 23-01-19 13:28:03, Kirill Tkhai wrote: > >> On 22.01.2019 23:09, Yang Shi wrote: > >>> In current implementation, both kswapd and direct reclaim has to iterate > >>> all mem cgroups. It is not a pro

Re: [RFC PATCH] mm: vmscan: do not iterate all mem cgroups for global direct reclaim

2019-01-23 Thread Kirill Tkhai
On 23.01.2019 14:02, Michal Hocko wrote: > On Wed 23-01-19 13:28:03, Kirill Tkhai wrote: >> On 22.01.2019 23:09, Yang Shi wrote: >>> In current implementation, both kswapd and direct reclaim has to iterate >>> all mem cgroups. It is not a problem before offline mem cgroups could >>> be iterated.

Re: [RFC PATCH] mm: vmscan: do not iterate all mem cgroups for global direct reclaim

2019-01-23 Thread Michal Hocko
On Wed 23-01-19 13:28:03, Kirill Tkhai wrote: > On 22.01.2019 23:09, Yang Shi wrote: > > In current implementation, both kswapd and direct reclaim has to iterate > > all mem cgroups. It is not a problem before offline mem cgroups could > > be iterated. But, currently with iterating offline mem cg

Re: [RFC PATCH] mm: vmscan: do not iterate all mem cgroups for global direct reclaim

2019-01-23 Thread Kirill Tkhai
On 22.01.2019 23:09, Yang Shi wrote: > In current implementation, both kswapd and direct reclaim has to iterate > all mem cgroups. It is not a problem before offline mem cgroups could > be iterated. But, currently with iterating offline mem cgroups, it > could be very time consuming. In our work

Re: [RFC PATCH] mm: vmscan: do not iterate all mem cgroups for global direct reclaim

2019-01-23 Thread Michal Hocko
On Wed 23-01-19 04:09:42, Yang Shi wrote: > In current implementation, both kswapd and direct reclaim has to iterate > all mem cgroups. It is not a problem before offline mem cgroups could > be iterated. But, currently with iterating offline mem cgroups, it > could be very time consuming. In our

[RFC PATCH] mm: vmscan: do not iterate all mem cgroups for global direct reclaim

2019-01-22 Thread Yang Shi
In current implementation, both kswapd and direct reclaim has to iterate all mem cgroups. It is not a problem before offline mem cgroups could be iterated. But, currently with iterating offline mem cgroups, it could be very time consuming. In our workloads, we saw over 400K mem cgroups accumulat