Re: [RFC PATCH] net, tun: remove the flow cache

2013-12-22 Thread Jason Wang
On 12/18/2013 10:08 AM, Zhi Yong Wu wrote: > On Tue, Dec 17, 2013 at 6:05 PM, Jason Wang wrote: >> On 12/17/2013 05:13 PM, Zhi Yong Wu wrote: >>> On Tue, Dec 17, 2013 at 4:49 PM, Jason Wang wrote: > On 12/17/2013 03:26 PM, Zhi Yong Wu wrote: >>> From: Zhi Yong Wu >>> >>> The

Re: [RFC PATCH] net, tun: remove the flow cache

2013-12-22 Thread Jason Wang
On 12/18/2013 10:08 AM, Zhi Yong Wu wrote: On Tue, Dec 17, 2013 at 6:05 PM, Jason Wang jasow...@redhat.com wrote: On 12/17/2013 05:13 PM, Zhi Yong Wu wrote: On Tue, Dec 17, 2013 at 4:49 PM, Jason Wang jasow...@redhat.com wrote: On 12/17/2013 03:26 PM, Zhi Yong Wu wrote: From: Zhi Yong Wu

Re: [RFC PATCH] net, tun: remove the flow cache

2013-12-17 Thread Zhi Yong Wu
On Wed, Dec 18, 2013 at 12:58 PM, Tom Herbert wrote: >>> Yes , in it's current state it's broken. But maybe we can try to fix >>> it instead of arbitrarily removing it. Please see my patches on >>> plumbing RFS into tuntap which may start to make it useful. >> Do you mean you patch [5/5] tun:

Re: [RFC PATCH] net, tun: remove the flow cache

2013-12-17 Thread Tom Herbert
>> Yes , in it's current state it's broken. But maybe we can try to fix >> it instead of arbitrarily removing it. Please see my patches on >> plumbing RFS into tuntap which may start to make it useful. > Do you mean you patch [5/5] tun: Added support for RFS on tun flows? > Sorry, can you say with

Re: [RFC PATCH] net, tun: remove the flow cache

2013-12-17 Thread Zhi Yong Wu
HI, Tom, On Wed, Dec 18, 2013 at 12:06 PM, Tom Herbert wrote: > On Mon, Dec 16, 2013 at 11:26 PM, Zhi Yong Wu wrote: >> From: Zhi Yong Wu >> >> The flow cache is an extremely broken concept, and it usually brings up >> growth issues and DoS attacks, so this patch is trying to remove it from >>

Re: [RFC PATCH] net, tun: remove the flow cache

2013-12-17 Thread Tom Herbert
On Mon, Dec 16, 2013 at 11:26 PM, Zhi Yong Wu wrote: > From: Zhi Yong Wu > > The flow cache is an extremely broken concept, and it usually brings up > growth issues and DoS attacks, so this patch is trying to remove it from > the tuntap driver, and insteadly use a simpler way for its flow

Re: [RFC PATCH] net, tun: remove the flow cache

2013-12-17 Thread Zhi Yong Wu
On Tue, Dec 17, 2013 at 6:05 PM, Jason Wang wrote: > On 12/17/2013 05:13 PM, Zhi Yong Wu wrote: >> On Tue, Dec 17, 2013 at 4:49 PM, Jason Wang wrote: >>> > On 12/17/2013 03:26 PM, Zhi Yong Wu wrote: >> From: Zhi Yong Wu >> >> The flow cache is an extremely broken concept, and it

Re: [RFC PATCH] net, tun: remove the flow cache

2013-12-17 Thread Jason Wang
On 12/17/2013 05:13 PM, Zhi Yong Wu wrote: > On Tue, Dec 17, 2013 at 4:49 PM, Jason Wang wrote: >> > On 12/17/2013 03:26 PM, Zhi Yong Wu wrote: >>> >> From: Zhi Yong Wu >>> >> >>> >> The flow cache is an extremely broken concept, and it usually brings up >>> >> growth issues and DoS attacks, so

Re: [RFC PATCH] net, tun: remove the flow cache

2013-12-17 Thread Zhi Yong Wu
On Tue, Dec 17, 2013 at 4:49 PM, Jason Wang wrote: > On 12/17/2013 03:26 PM, Zhi Yong Wu wrote: >> From: Zhi Yong Wu >> >> The flow cache is an extremely broken concept, and it usually brings up >> growth issues and DoS attacks, so this patch is trying to remove it from >> the tuntap driver, and

Re: [RFC PATCH] net, tun: remove the flow cache

2013-12-17 Thread Jason Wang
On 12/17/2013 03:26 PM, Zhi Yong Wu wrote: > From: Zhi Yong Wu > > The flow cache is an extremely broken concept, and it usually brings up > growth issues and DoS attacks, so this patch is trying to remove it from > the tuntap driver, and insteadly use a simpler way for its flow control. NACK.

Re: [RFC PATCH] net, tun: remove the flow cache

2013-12-17 Thread Zhi Yong Wu
On Mon, 2013-12-16 at 23:47 -0800, Stephen Hemminger wrote: > On Tue, 17 Dec 2013 15:26:22 +0800 > Zhi Yong Wu wrote: > > > From: Zhi Yong Wu > > > > The flow cache is an extremely broken concept, and it usually brings up > > growth issues and DoS attacks, so this patch is trying to remove it

Re: [RFC PATCH] net, tun: remove the flow cache

2013-12-17 Thread Zhi Yong Wu
On Mon, 2013-12-16 at 23:47 -0800, Stephen Hemminger wrote: On Tue, 17 Dec 2013 15:26:22 +0800 Zhi Yong Wu zwu.ker...@gmail.com wrote: From: Zhi Yong Wu wu...@linux.vnet.ibm.com The flow cache is an extremely broken concept, and it usually brings up growth issues and DoS attacks, so

Re: [RFC PATCH] net, tun: remove the flow cache

2013-12-17 Thread Jason Wang
On 12/17/2013 03:26 PM, Zhi Yong Wu wrote: From: Zhi Yong Wu wu...@linux.vnet.ibm.com The flow cache is an extremely broken concept, and it usually brings up growth issues and DoS attacks, so this patch is trying to remove it from the tuntap driver, and insteadly use a simpler way for its

Re: [RFC PATCH] net, tun: remove the flow cache

2013-12-17 Thread Zhi Yong Wu
On Tue, Dec 17, 2013 at 4:49 PM, Jason Wang jasow...@redhat.com wrote: On 12/17/2013 03:26 PM, Zhi Yong Wu wrote: From: Zhi Yong Wu wu...@linux.vnet.ibm.com The flow cache is an extremely broken concept, and it usually brings up growth issues and DoS attacks, so this patch is trying to remove

Re: [RFC PATCH] net, tun: remove the flow cache

2013-12-17 Thread Jason Wang
On 12/17/2013 05:13 PM, Zhi Yong Wu wrote: On Tue, Dec 17, 2013 at 4:49 PM, Jason Wang jasow...@redhat.com wrote: On 12/17/2013 03:26 PM, Zhi Yong Wu wrote: From: Zhi Yong Wu wu...@linux.vnet.ibm.com The flow cache is an extremely broken concept, and it usually brings up growth issues

Re: [RFC PATCH] net, tun: remove the flow cache

2013-12-17 Thread Zhi Yong Wu
On Tue, Dec 17, 2013 at 6:05 PM, Jason Wang jasow...@redhat.com wrote: On 12/17/2013 05:13 PM, Zhi Yong Wu wrote: On Tue, Dec 17, 2013 at 4:49 PM, Jason Wang jasow...@redhat.com wrote: On 12/17/2013 03:26 PM, Zhi Yong Wu wrote: From: Zhi Yong Wu wu...@linux.vnet.ibm.com The flow cache is

Re: [RFC PATCH] net, tun: remove the flow cache

2013-12-17 Thread Tom Herbert
On Mon, Dec 16, 2013 at 11:26 PM, Zhi Yong Wu zwu.ker...@gmail.com wrote: From: Zhi Yong Wu wu...@linux.vnet.ibm.com The flow cache is an extremely broken concept, and it usually brings up growth issues and DoS attacks, so this patch is trying to remove it from the tuntap driver, and

Re: [RFC PATCH] net, tun: remove the flow cache

2013-12-17 Thread Zhi Yong Wu
HI, Tom, On Wed, Dec 18, 2013 at 12:06 PM, Tom Herbert therb...@google.com wrote: On Mon, Dec 16, 2013 at 11:26 PM, Zhi Yong Wu zwu.ker...@gmail.com wrote: From: Zhi Yong Wu wu...@linux.vnet.ibm.com The flow cache is an extremely broken concept, and it usually brings up growth issues and DoS

Re: [RFC PATCH] net, tun: remove the flow cache

2013-12-17 Thread Tom Herbert
Yes , in it's current state it's broken. But maybe we can try to fix it instead of arbitrarily removing it. Please see my patches on plumbing RFS into tuntap which may start to make it useful. Do you mean you patch [5/5] tun: Added support for RFS on tun flows? Sorry, can you say with more

Re: [RFC PATCH] net, tun: remove the flow cache

2013-12-17 Thread Zhi Yong Wu
On Wed, Dec 18, 2013 at 12:58 PM, Tom Herbert therb...@google.com wrote: Yes , in it's current state it's broken. But maybe we can try to fix it instead of arbitrarily removing it. Please see my patches on plumbing RFS into tuntap which may start to make it useful. Do you mean you patch [5/5]

Re: [RFC PATCH] net, tun: remove the flow cache

2013-12-16 Thread Stephen Hemminger
On Tue, 17 Dec 2013 15:26:22 +0800 Zhi Yong Wu wrote: > From: Zhi Yong Wu > > The flow cache is an extremely broken concept, and it usually brings up > growth issues and DoS attacks, so this patch is trying to remove it from > the tuntap driver, and insteadly use a simpler way for its flow

[RFC PATCH] net, tun: remove the flow cache

2013-12-16 Thread Zhi Yong Wu
From: Zhi Yong Wu The flow cache is an extremely broken concept, and it usually brings up growth issues and DoS attacks, so this patch is trying to remove it from the tuntap driver, and insteadly use a simpler way for its flow control. Signed-off-by: Zhi Yong Wu --- drivers/net/tun.c | 208

[RFC PATCH] net, tun: remove the flow cache

2013-12-16 Thread Zhi Yong Wu
From: Zhi Yong Wu wu...@linux.vnet.ibm.com The flow cache is an extremely broken concept, and it usually brings up growth issues and DoS attacks, so this patch is trying to remove it from the tuntap driver, and insteadly use a simpler way for its flow control. Signed-off-by: Zhi Yong Wu

Re: [RFC PATCH] net, tun: remove the flow cache

2013-12-16 Thread Stephen Hemminger
On Tue, 17 Dec 2013 15:26:22 +0800 Zhi Yong Wu zwu.ker...@gmail.com wrote: From: Zhi Yong Wu wu...@linux.vnet.ibm.com The flow cache is an extremely broken concept, and it usually brings up growth issues and DoS attacks, so this patch is trying to remove it from the tuntap driver, and