Re: [RFC PATCH] nvme-pci: Move the sg table allocation/free into init/exit_request

2020-06-28 Thread Keith Busch
On Sun, Jun 28, 2020 at 06:34:46PM +0800, Baolin Wang wrote: > Move the sg table allocation and free into the init_request() and > exit_request(), instead of allocating sg table when queuing requests, > which can benefit the IO performance. If you want to pre-allocate something per-request, you ca

Re: [RFC PATCH] nvme-pci: Move the sg table allocation/free into init/exit_request

2020-06-28 Thread Chaitanya Kulkarni
On 6/28/20 3:44 AM, Baolin Wang wrote: > Move the sg table allocation and free into the init_request() and > exit_request(), instead of allocating sg table when queuing requests, > which can benefit the IO performance. > > Signed-off-by: Baolin Wang The call to sg_init_table() uses blk_rq_nr_phys

[RFC PATCH] nvme-pci: Move the sg table allocation/free into init/exit_request

2020-06-28 Thread Baolin Wang
Move the sg table allocation and free into the init_request() and exit_request(), instead of allocating sg table when queuing requests, which can benefit the IO performance. Signed-off-by: Baolin Wang --- drivers/nvme/host/pci.c | 24 ++-- 1 file changed, 18 insertions(+), 6