Re: [RFC PATCH] sched/cputime: drop local_irq_safe() in vtime_init_idle()

2016-04-14 Thread Frederic Weisbecker
On Thu, Apr 14, 2016 at 03:41:17PM +0200, Sebastian Andrzej Siewior wrote: > On 04/14/2016 03:18 PM, Frederic Weisbecker wrote: > > I think I tried this but I got lockdep warnings because the other updaters > > happen on IRQ. > > I booted and played a little but lockdep didn't scream here so far.

Re: [RFC PATCH] sched/cputime: drop local_irq_safe() in vtime_init_idle()

2016-04-14 Thread Sebastian Andrzej Siewior
On 04/14/2016 03:18 PM, Frederic Weisbecker wrote: > I think I tried this but I got lockdep warnings because the other updaters > happen on IRQ. I booted and played a little but lockdep didn't scream here so far. > In practive we can't be interrupted since the idle task hasn't even started. > >

Re: [RFC PATCH] sched/cputime: drop local_irq_safe() in vtime_init_idle()

2016-04-14 Thread Frederic Weisbecker
On Thu, Apr 14, 2016 at 02:29:14PM +0200, Sebastian Andrzej Siewior wrote: > A while ago vtime_init_idle() used to invoke sched_clock_cpu() and had > write_seqlock_irqsave() because sched_clock_cpu() required to be called > with interrupts off. > This requirement is written before the body of the f

Re: [RFC PATCH] sched/cputime: drop local_irq_safe() in vtime_init_idle()

2016-04-14 Thread Rik van Riel
On Thu, 2016-04-14 at 14:29 +0200, Sebastian Andrzej Siewior wrote: > A while ago vtime_init_idle() used to invoke sched_clock_cpu() and > had > write_seqlock_irqsave() because sched_clock_cpu() required to be > called > with interrupts off. > This requirement is written before the body of the func

[RFC PATCH] sched/cputime: drop local_irq_safe() in vtime_init_idle()

2016-04-14 Thread Sebastian Andrzej Siewior
A while ago vtime_init_idle() used to invoke sched_clock_cpu() and had write_seqlock_irqsave() because sched_clock_cpu() required to be called with interrupts off. This requirement is written before the body of the function and was introduced in 2010 via c676329abb2b ("sched_clock: Add local_clock(