Re: [RFC PATCH] sched: Add cpu based entries to debugfs

2015-04-05 Thread Mike Galbraith
On Sun, 2015-04-05 at 20:10 -0600, David Ahern wrote: > > Can someone clarify on the duplication concerns and such? My concern was eg you display flags in /sys, but to tweak flags etc, you must visit /proc. Seems to me the missing info should either be added to /proc (some under DEBUG?), or

Re: [RFC PATCH] sched: Add cpu based entries to debugfs

2015-04-05 Thread David Ahern
On 3/31/15 3:13 AM, Ingo Molnar wrote: * Peter Zijlstra wrote: On Mon, Mar 30, 2015 at 10:43:14AM +0200, Mike Galbraith wrote: I think it would be a good thing if we can get away with it, but I also think you could safely bet your life that somebody will squeak. The thing I worry most

Re: [RFC PATCH] sched: Add cpu based entries to debugfs

2015-04-05 Thread Mike Galbraith
On Sun, 2015-04-05 at 20:10 -0600, David Ahern wrote: Can someone clarify on the duplication concerns and such? My concern was eg you display flags in /sys, but to tweak flags etc, you must visit /proc. Seems to me the missing info should either be added to /proc (some under DEBUG?), or the

Re: [RFC PATCH] sched: Add cpu based entries to debugfs

2015-04-05 Thread David Ahern
On 3/31/15 3:13 AM, Ingo Molnar wrote: * Peter Zijlstra pet...@infradead.org wrote: On Mon, Mar 30, 2015 at 10:43:14AM +0200, Mike Galbraith wrote: I think it would be a good thing if we can get away with it, but I also think you could safely bet your life that somebody will squeak. The

Re: [RFC PATCH] sched: Add cpu based entries to debugfs

2015-03-31 Thread Ingo Molnar
* Peter Zijlstra wrote: > On Mon, Mar 30, 2015 at 10:43:14AM +0200, Mike Galbraith wrote: > > > I think it would be a good thing if we can get away with it, but I > > also think you could safely bet your life that somebody will > > squeak. > > The thing I worry most about is that squeaking

Re: [RFC PATCH] sched: Add cpu based entries to debugfs

2015-03-31 Thread Ingo Molnar
* Peter Zijlstra pet...@infradead.org wrote: On Mon, Mar 30, 2015 at 10:43:14AM +0200, Mike Galbraith wrote: I think it would be a good thing if we can get away with it, but I also think you could safely bet your life that somebody will squeak. The thing I worry most about is that

Re: [RFC PATCH] sched: Add cpu based entries to debugfs

2015-03-30 Thread Mike Galbraith
On Mon, 2015-03-30 at 07:03 -0600, David Ahern wrote: > On 3/29/15 9:08 PM, Mike Galbraith wrote: > > > > Oh, you can add /proc/sys/kernel/sched_domain diddling to the hotplug > > todo... which will either create read /sys, poke modify buttons over > > yonder in /proc situation, or have to

Re: [RFC PATCH] sched: Add cpu based entries to debugfs

2015-03-30 Thread David Ahern
On 3/29/15 9:08 PM, Mike Galbraith wrote: Oh, you can add /proc/sys/kernel/sched_domain diddling to the hotplug todo... which will either create read /sys, poke modify buttons over yonder in /proc situation, or have to duplicate that. -EPARSE. you mean the /proc/sys/kernel/sched_domain/

Re: [RFC PATCH] sched: Add cpu based entries to debugfs

2015-03-30 Thread David Ahern
On 3/30/15 1:44 AM, Peter Zijlstra wrote: On Sun, Mar 29, 2015 at 10:13:33PM -0400, David Ahern wrote: Before spending too much time formalizing this I wanted to see if you guys would entertain the idea of making this info available via debugfs. It does move the existing sched_features file to

Re: [RFC PATCH] sched: Add cpu based entries to debugfs

2015-03-30 Thread Peter Zijlstra
On Mon, Mar 30, 2015 at 10:43:14AM +0200, Mike Galbraith wrote: > I think it would be a good thing if we can get away with it, but I also > think you could safely bet your life that somebody will squeak. The thing I worry most about is that squeaking only happening 5 years later :/ -- To

Re: [RFC PATCH] sched: Add cpu based entries to debugfs

2015-03-30 Thread Mike Galbraith
On Mon, 2015-03-30 at 10:28 +0200, Peter Zijlstra wrote: > On Mon, Mar 30, 2015 at 10:26:03AM +0200, Mike Galbraith wrote: > > On Mon, 2015-03-30 at 09:44 +0200, Peter Zijlstra wrote: > > > On Sun, Mar 29, 2015 at 10:13:33PM -0400, David Ahern wrote: > > > > Before spending too much time

Re: [RFC PATCH] sched: Add cpu based entries to debugfs

2015-03-30 Thread Peter Zijlstra
On Mon, Mar 30, 2015 at 10:26:03AM +0200, Mike Galbraith wrote: > On Mon, 2015-03-30 at 09:44 +0200, Peter Zijlstra wrote: > > On Sun, Mar 29, 2015 at 10:13:33PM -0400, David Ahern wrote: > > > Before spending too much time formalizing this I wanted to see if you guys > > > would entertain the

Re: [RFC PATCH] sched: Add cpu based entries to debugfs

2015-03-30 Thread Mike Galbraith
On Mon, 2015-03-30 at 09:44 +0200, Peter Zijlstra wrote: > On Sun, Mar 29, 2015 at 10:13:33PM -0400, David Ahern wrote: > > Before spending too much time formalizing this I wanted to see if you guys > > would entertain the idea of making this info available via debugfs. It does > > move the

Re: [RFC PATCH] sched: Add cpu based entries to debugfs

2015-03-30 Thread Peter Zijlstra
On Sun, Mar 29, 2015 at 10:13:33PM -0400, David Ahern wrote: > Before spending too much time formalizing this I wanted to see if you guys > would entertain the idea of making this info available via debugfs. It does > move the existing sched_features file to sched/features -- not sure how >

Re: [RFC PATCH] sched: Add cpu based entries to debugfs

2015-03-30 Thread Peter Zijlstra
On Sun, Mar 29, 2015 at 10:13:33PM -0400, David Ahern wrote: Before spending too much time formalizing this I wanted to see if you guys would entertain the idea of making this info available via debugfs. It does move the existing sched_features file to sched/features -- not sure how

Re: [RFC PATCH] sched: Add cpu based entries to debugfs

2015-03-30 Thread Mike Galbraith
On Mon, 2015-03-30 at 10:28 +0200, Peter Zijlstra wrote: On Mon, Mar 30, 2015 at 10:26:03AM +0200, Mike Galbraith wrote: On Mon, 2015-03-30 at 09:44 +0200, Peter Zijlstra wrote: On Sun, Mar 29, 2015 at 10:13:33PM -0400, David Ahern wrote: Before spending too much time formalizing this I

Re: [RFC PATCH] sched: Add cpu based entries to debugfs

2015-03-30 Thread Mike Galbraith
On Mon, 2015-03-30 at 09:44 +0200, Peter Zijlstra wrote: On Sun, Mar 29, 2015 at 10:13:33PM -0400, David Ahern wrote: Before spending too much time formalizing this I wanted to see if you guys would entertain the idea of making this info available via debugfs. It does move the existing

Re: [RFC PATCH] sched: Add cpu based entries to debugfs

2015-03-30 Thread Peter Zijlstra
On Mon, Mar 30, 2015 at 10:26:03AM +0200, Mike Galbraith wrote: On Mon, 2015-03-30 at 09:44 +0200, Peter Zijlstra wrote: On Sun, Mar 29, 2015 at 10:13:33PM -0400, David Ahern wrote: Before spending too much time formalizing this I wanted to see if you guys would entertain the idea of

Re: [RFC PATCH] sched: Add cpu based entries to debugfs

2015-03-30 Thread Peter Zijlstra
On Mon, Mar 30, 2015 at 10:43:14AM +0200, Mike Galbraith wrote: I think it would be a good thing if we can get away with it, but I also think you could safely bet your life that somebody will squeak. The thing I worry most about is that squeaking only happening 5 years later :/ -- To

Re: [RFC PATCH] sched: Add cpu based entries to debugfs

2015-03-30 Thread David Ahern
On 3/30/15 1:44 AM, Peter Zijlstra wrote: On Sun, Mar 29, 2015 at 10:13:33PM -0400, David Ahern wrote: Before spending too much time formalizing this I wanted to see if you guys would entertain the idea of making this info available via debugfs. It does move the existing sched_features file to

Re: [RFC PATCH] sched: Add cpu based entries to debugfs

2015-03-30 Thread David Ahern
On 3/29/15 9:08 PM, Mike Galbraith wrote: Oh, you can add /proc/sys/kernel/sched_domain diddling to the hotplug todo... which will either create read /sys, poke modify buttons over yonder in /proc situation, or have to duplicate that. -EPARSE. you mean the /proc/sys/kernel/sched_domain/

Re: [RFC PATCH] sched: Add cpu based entries to debugfs

2015-03-30 Thread Mike Galbraith
On Mon, 2015-03-30 at 07:03 -0600, David Ahern wrote: On 3/29/15 9:08 PM, Mike Galbraith wrote: Oh, you can add /proc/sys/kernel/sched_domain diddling to the hotplug todo... which will either create read /sys, poke modify buttons over yonder in /proc situation, or have to duplicate that.

Re: [RFC PATCH] sched: Add cpu based entries to debugfs

2015-03-29 Thread Mike Galbraith
Oh, you can add /proc/sys/kernel/sched_domain diddling to the hotplug todo... which will either create read /sys, poke modify buttons over yonder in /proc situation, or have to duplicate that. -Mike -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body

Re: [RFC PATCH] sched: Add cpu based entries to debugfs

2015-03-29 Thread David Ahern
On 3/29/15 8:32 PM, Mike Galbraith wrote: On Sun, 2015-03-29 at 22:13 -0400, David Ahern wrote: diff --git a/kernel/sched/core.c b/kernel/sched/core.c index 62671f53202a..b4d8d0c8260e 100644 --- a/kernel/sched/core.c +++ b/kernel/sched/core.c @@ -268,12 +268,173 @@ static const struct

Re: [RFC PATCH] sched: Add cpu based entries to debugfs

2015-03-29 Thread Mike Galbraith
On Sun, 2015-03-29 at 22:13 -0400, David Ahern wrote: > diff --git a/kernel/sched/core.c b/kernel/sched/core.c > index 62671f53202a..b4d8d0c8260e 100644 > --- a/kernel/sched/core.c > +++ b/kernel/sched/core.c > @@ -268,12 +268,173 @@ static const struct file_operations sched_feat_fops = { >

[RFC PATCH] sched: Add cpu based entries to debugfs

2015-03-29 Thread David Ahern
Currently sched_debug can be added to the kernel commandline parameters to dump domain information during boot. This method is not practical with a large number of CPUs. This patch adds per-cpu entries to debugfs under a sched directory. Reading the per-cpu file shows the domain information in a

[RFC PATCH] sched: Add cpu based entries to debugfs

2015-03-29 Thread David Ahern
Currently sched_debug can be added to the kernel commandline parameters to dump domain information during boot. This method is not practical with a large number of CPUs. This patch adds per-cpu entries to debugfs under a sched directory. Reading the per-cpu file shows the domain information in a

Re: [RFC PATCH] sched: Add cpu based entries to debugfs

2015-03-29 Thread David Ahern
On 3/29/15 8:32 PM, Mike Galbraith wrote: On Sun, 2015-03-29 at 22:13 -0400, David Ahern wrote: diff --git a/kernel/sched/core.c b/kernel/sched/core.c index 62671f53202a..b4d8d0c8260e 100644 --- a/kernel/sched/core.c +++ b/kernel/sched/core.c @@ -268,12 +268,173 @@ static const struct

Re: [RFC PATCH] sched: Add cpu based entries to debugfs

2015-03-29 Thread Mike Galbraith
Oh, you can add /proc/sys/kernel/sched_domain diddling to the hotplug todo... which will either create read /sys, poke modify buttons over yonder in /proc situation, or have to duplicate that. -Mike -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of

Re: [RFC PATCH] sched: Add cpu based entries to debugfs

2015-03-29 Thread Mike Galbraith
On Sun, 2015-03-29 at 22:13 -0400, David Ahern wrote: diff --git a/kernel/sched/core.c b/kernel/sched/core.c index 62671f53202a..b4d8d0c8260e 100644 --- a/kernel/sched/core.c +++ b/kernel/sched/core.c @@ -268,12 +268,173 @@ static const struct file_operations sched_feat_fops = {