Re: [RFC PATCH] scsi: fix oops in scsi_uninit_cmd()

2019-02-21 Thread Jason Yan
Hi, Christoph On 2019/2/20 23:18, Christoph Hellwig wrote: [fullquote removed, please follow proper mail etiquette] On Tue, Feb 19, 2019 at 08:56:28AM -0800, Bart Van Assche wrote: regression in the SCSI sd driver due to the switch from the legacy block layer to scsi-mq. The above patch

Re: [RFC PATCH] scsi: fix oops in scsi_uninit_cmd()

2019-02-20 Thread Christoph Hellwig
[fullquote removed, please follow proper mail etiquette] On Tue, Feb 19, 2019 at 08:56:28AM -0800, Bart Van Assche wrote: > regression in the SCSI sd driver due to the switch from the legacy block > layer to scsi-mq. The above patch introduces two atomic operations in the > hot path and hence

Re: [RFC PATCH] scsi: fix oops in scsi_uninit_cmd()

2019-02-19 Thread Bart Van Assche
On Tue, 2019-02-19 at 15:27 +0800, Jason Yan wrote: > If we remove the scsi disk when running io with fio, oops occured with > the following condition. > > [scsi_eh_0] [fio] > scsi_end_request > ->blk_update_request > ->end_bio(io returned to userspace) >

Re: [RFC PATCH] scsi: fix oops in scsi_uninit_cmd()

2019-02-19 Thread Steffen Maier
On 02/19/2019 08:27 AM, Jason Yan wrote: If we remove the scsi disk when running io with fio, oops occured with the following condition. [scsi_eh_0] [fio] scsi_end_request ->blk_update_request ->end_bio(io returned to userspace)

[RFC PATCH] scsi: fix oops in scsi_uninit_cmd()

2019-02-18 Thread Jason Yan
If we remove the scsi disk when running io with fio, oops occured with the following condition. [scsi_eh_0] [fio] scsi_end_request ->blk_update_request ->end_bio(io returned to userspace) close