Re: [RFC PATCH] tools lib traceevent: Allow setting an alternative symbol resolver

2015-07-23 Thread Steven Rostedt
On Thu, 23 Jul 2015 22:34:48 -0300 Arnaldo Carvalho de Melo wrote: > > > One more try: > > > Third time's a charm, or was this the forth? > > As many as needed would be put forth! And the Lord said unto John, "Come forth and you will receive eternal life" But John came fifth, and won a

Re: [RFC PATCH] tools lib traceevent: Allow setting an alternative symbol resolver

2015-07-23 Thread Arnaldo Carvalho de Melo
Em Thu, Jul 23, 2015 at 06:07:30PM -0400, Steven Rostedt escreveu: > On Thu, 23 Jul 2015 18:58:36 -0300 > Arnaldo Carvalho de Melo wrote: > > > Em Thu, Jul 23, 2015 at 06:52:46PM -0300, Arnaldo Carvalho de Melo escreveu: > > > Em Thu, Jul 23, 2015 at 05:35:24PM -0400, Steven Rostedt escreveu: >

Re: [RFC PATCH] tools lib traceevent: Allow setting an alternative symbol resolver

2015-07-23 Thread Steven Rostedt
On Thu, 23 Jul 2015 18:58:36 -0300 Arnaldo Carvalho de Melo wrote: > Em Thu, Jul 23, 2015 at 06:52:46PM -0300, Arnaldo Carvalho de Melo escreveu: > > Em Thu, Jul 23, 2015 at 05:35:24PM -0400, Steven Rostedt escreveu: > > > On Thu, 23 Jul 2015 18:25:36 -0300 > > > Arnaldo Carvalho de Melo wrote:

Re: [RFC PATCH] tools lib traceevent: Allow setting an alternative symbol resolver

2015-07-23 Thread Arnaldo Carvalho de Melo
Em Thu, Jul 23, 2015 at 06:52:46PM -0300, Arnaldo Carvalho de Melo escreveu: > Em Thu, Jul 23, 2015 at 05:35:24PM -0400, Steven Rostedt escreveu: > > On Thu, 23 Jul 2015 18:25:36 -0300 > > Arnaldo Carvalho de Melo wrote: > > > + if (resolver == NULL) { > > > + errno = ENOMEM; > > > > Why

Re: [RFC PATCH] tools lib traceevent: Allow setting an alternative symbol resolver

2015-07-23 Thread Arnaldo Carvalho de Melo
Em Thu, Jul 23, 2015 at 05:35:24PM -0400, Steven Rostedt escreveu: > On Thu, 23 Jul 2015 18:25:36 -0300 > Arnaldo Carvalho de Melo wrote: > > > Like this? > > Yep, but some comments. > > > +int pevent_set_function_resolver(struct pevent *pevent, > > +

Re: [RFC PATCH] tools lib traceevent: Allow setting an alternative symbol resolver

2015-07-23 Thread Steven Rostedt
On Thu, 23 Jul 2015 18:25:36 -0300 Arnaldo Carvalho de Melo wrote: > Like this? Yep, but some comments. > diff --git a/tools/lib/traceevent/event-parse.c > b/tools/lib/traceevent/event-parse.c > index cc25f059ab3d..7f9266225f11 100644 > --- a/tools/lib/traceevent/event-parse.c > +++

Re: [RFC PATCH] tools lib traceevent: Allow setting an alternative symbol resolver

2015-07-23 Thread Arnaldo Carvalho de Melo
Em Thu, Jul 23, 2015 at 02:11:33PM -0400, Steven Rostedt escreveu: > On Thu, 23 Jul 2015 14:10:39 -0400 > Steven Rostedt wrote: > > > On Thu, 23 Jul 2015 14:25:54 -0300 > > Arnaldo Carvalho de Melo wrote: > > > > > diff --git a/tools/lib/traceevent/event-parse.c > > >

Re: [RFC PATCH] tools lib traceevent: Allow setting an alternative symbol resolver

2015-07-23 Thread Arnaldo Carvalho de Melo
Em Thu, Jul 23, 2015 at 02:11:33PM -0400, Steven Rostedt escreveu: > On Thu, 23 Jul 2015 14:10:39 -0400 Steven Rostedt wrote: > > On Thu, 23 Jul 2015 14:25:54 -0300 > > Arnaldo Carvalho de Melo wrote: > > > diff --git a/tools/lib/traceevent/event-parse.c > > >

Re: [RFC PATCH] tools lib traceevent: Allow setting an alternative symbol resolver

2015-07-23 Thread Steven Rostedt
On Thu, 23 Jul 2015 14:25:54 -0300 Arnaldo Carvalho de Melo wrote: > diff --git a/tools/lib/traceevent/event-parse.c > b/tools/lib/traceevent/event-parse.c > index cc25f059ab3d..2750e7e7efff 100644 > --- a/tools/lib/traceevent/event-parse.c > +++ b/tools/lib/traceevent/event-parse.c > @@ -418,7

Re: [RFC PATCH] tools lib traceevent: Allow setting an alternative symbol resolver

2015-07-23 Thread Steven Rostedt
On Thu, 23 Jul 2015 14:10:39 -0400 Steven Rostedt wrote: > On Thu, 23 Jul 2015 14:25:54 -0300 > Arnaldo Carvalho de Melo wrote: > > > diff --git a/tools/lib/traceevent/event-parse.c > > b/tools/lib/traceevent/event-parse.c > > index cc25f059ab3d..2750e7e7efff 100644 > > ---

Re: [RFC PATCH] tools lib traceevent: Allow setting an alternative symbol resolver

2015-07-23 Thread Arnaldo Carvalho de Melo
Em Thu, Jul 23, 2015 at 12:21:30PM -0400, Steven Rostedt escreveu: > On Thu, 23 Jul 2015 12:04:33 -0300 Arnaldo Carvalho de Melo > wrote: > > +static struct func_map * > > +find_func(struct pevent *pevent, unsigned long long addr) > > +{ > > + static struct func_map map; > I know there's

Re: [RFC PATCH] tools lib traceevent: Allow setting an alternative symbol resolver

2015-07-23 Thread Steven Rostedt
On Thu, 23 Jul 2015 12:04:33 -0300 Arnaldo Carvalho de Melo wrote: > > +static struct func_map * > +find_func(struct pevent *pevent, unsigned long long addr) > +{ > + static struct func_map map; I know there's other cases of static variables in functions, but I plan on cleaning that up in

[RFC PATCH] tools lib traceevent: Allow setting an alternative symbol resolver

2015-07-23 Thread Arnaldo Carvalho de Melo
Hi Steven, Can you take a look if this is ok with you? This is the part that touches tools/lib/traceevent/, the rest of the patchset that then uses it is at: git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tmp.perf/core Best regards, - Arnaldo commit

Re: [RFC PATCH] tools lib traceevent: Allow setting an alternative symbol resolver

2015-07-23 Thread Arnaldo Carvalho de Melo
Em Thu, Jul 23, 2015 at 06:52:46PM -0300, Arnaldo Carvalho de Melo escreveu: Em Thu, Jul 23, 2015 at 05:35:24PM -0400, Steven Rostedt escreveu: On Thu, 23 Jul 2015 18:25:36 -0300 Arnaldo Carvalho de Melo a...@kernel.org wrote: + if (resolver == NULL) { + errno = ENOMEM; Why

Re: [RFC PATCH] tools lib traceevent: Allow setting an alternative symbol resolver

2015-07-23 Thread Arnaldo Carvalho de Melo
Em Thu, Jul 23, 2015 at 02:11:33PM -0400, Steven Rostedt escreveu: On Thu, 23 Jul 2015 14:10:39 -0400 Steven Rostedt rost...@goodmis.org wrote: On Thu, 23 Jul 2015 14:25:54 -0300 Arnaldo Carvalho de Melo a...@kernel.org wrote: diff --git a/tools/lib/traceevent/event-parse.c

Re: [RFC PATCH] tools lib traceevent: Allow setting an alternative symbol resolver

2015-07-23 Thread Steven Rostedt
On Thu, 23 Jul 2015 18:25:36 -0300 Arnaldo Carvalho de Melo a...@kernel.org wrote: Like this? Yep, but some comments. diff --git a/tools/lib/traceevent/event-parse.c b/tools/lib/traceevent/event-parse.c index cc25f059ab3d..7f9266225f11 100644 --- a/tools/lib/traceevent/event-parse.c +++

Re: [RFC PATCH] tools lib traceevent: Allow setting an alternative symbol resolver

2015-07-23 Thread Arnaldo Carvalho de Melo
Em Thu, Jul 23, 2015 at 05:35:24PM -0400, Steven Rostedt escreveu: On Thu, 23 Jul 2015 18:25:36 -0300 Arnaldo Carvalho de Melo a...@kernel.org wrote: Like this? Yep, but some comments. +int pevent_set_function_resolver(struct pevent *pevent, +

Re: [RFC PATCH] tools lib traceevent: Allow setting an alternative symbol resolver

2015-07-23 Thread Arnaldo Carvalho de Melo
Em Thu, Jul 23, 2015 at 06:07:30PM -0400, Steven Rostedt escreveu: On Thu, 23 Jul 2015 18:58:36 -0300 Arnaldo Carvalho de Melo a...@kernel.org wrote: Em Thu, Jul 23, 2015 at 06:52:46PM -0300, Arnaldo Carvalho de Melo escreveu: Em Thu, Jul 23, 2015 at 05:35:24PM -0400, Steven Rostedt

Re: [RFC PATCH] tools lib traceevent: Allow setting an alternative symbol resolver

2015-07-23 Thread Steven Rostedt
On Thu, 23 Jul 2015 22:34:48 -0300 Arnaldo Carvalho de Melo a...@kernel.org wrote: One more try: Third time's a charm, or was this the forth? As many as needed would be put forth! And the Lord said unto John, Come forth and you will receive eternal life But John came fifth, and won a

Re: [RFC PATCH] tools lib traceevent: Allow setting an alternative symbol resolver

2015-07-23 Thread Steven Rostedt
On Thu, 23 Jul 2015 18:58:36 -0300 Arnaldo Carvalho de Melo a...@kernel.org wrote: Em Thu, Jul 23, 2015 at 06:52:46PM -0300, Arnaldo Carvalho de Melo escreveu: Em Thu, Jul 23, 2015 at 05:35:24PM -0400, Steven Rostedt escreveu: On Thu, 23 Jul 2015 18:25:36 -0300 Arnaldo Carvalho de Melo

[RFC PATCH] tools lib traceevent: Allow setting an alternative symbol resolver

2015-07-23 Thread Arnaldo Carvalho de Melo
Hi Steven, Can you take a look if this is ok with you? This is the part that touches tools/lib/traceevent/, the rest of the patchset that then uses it is at: git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tmp.perf/core Best regards, - Arnaldo commit

Re: [RFC PATCH] tools lib traceevent: Allow setting an alternative symbol resolver

2015-07-23 Thread Arnaldo Carvalho de Melo
Em Thu, Jul 23, 2015 at 12:21:30PM -0400, Steven Rostedt escreveu: On Thu, 23 Jul 2015 12:04:33 -0300 Arnaldo Carvalho de Melo a...@kernel.org wrote: +static struct func_map * +find_func(struct pevent *pevent, unsigned long long addr) +{ + static struct func_map map; I know there's

Re: [RFC PATCH] tools lib traceevent: Allow setting an alternative symbol resolver

2015-07-23 Thread Steven Rostedt
On Thu, 23 Jul 2015 14:10:39 -0400 Steven Rostedt rost...@goodmis.org wrote: On Thu, 23 Jul 2015 14:25:54 -0300 Arnaldo Carvalho de Melo a...@kernel.org wrote: diff --git a/tools/lib/traceevent/event-parse.c b/tools/lib/traceevent/event-parse.c index cc25f059ab3d..2750e7e7efff 100644

Re: [RFC PATCH] tools lib traceevent: Allow setting an alternative symbol resolver

2015-07-23 Thread Steven Rostedt
On Thu, 23 Jul 2015 14:25:54 -0300 Arnaldo Carvalho de Melo a...@kernel.org wrote: diff --git a/tools/lib/traceevent/event-parse.c b/tools/lib/traceevent/event-parse.c index cc25f059ab3d..2750e7e7efff 100644 --- a/tools/lib/traceevent/event-parse.c +++ b/tools/lib/traceevent/event-parse.c

Re: [RFC PATCH] tools lib traceevent: Allow setting an alternative symbol resolver

2015-07-23 Thread Arnaldo Carvalho de Melo
Em Thu, Jul 23, 2015 at 02:11:33PM -0400, Steven Rostedt escreveu: On Thu, 23 Jul 2015 14:10:39 -0400 Steven Rostedt rost...@goodmis.org wrote: On Thu, 23 Jul 2015 14:25:54 -0300 Arnaldo Carvalho de Melo a...@kernel.org wrote: diff --git a/tools/lib/traceevent/event-parse.c

Re: [RFC PATCH] tools lib traceevent: Allow setting an alternative symbol resolver

2015-07-23 Thread Steven Rostedt
On Thu, 23 Jul 2015 12:04:33 -0300 Arnaldo Carvalho de Melo a...@kernel.org wrote: +static struct func_map * +find_func(struct pevent *pevent, unsigned long long addr) +{ + static struct func_map map; I know there's other cases of static variables in functions, but I plan on cleaning