Re: [RFC PATCH 0/2] Fix linux/swap.h build wart

2007-10-26 Thread Jeff Dike
On Fri, Oct 26, 2007 at 01:38:12PM -0700, Luck, Tony wrote: > Not fundamental reasons, but these patches break the ia64 build for most > configs with: > > In file included from kernel/futex.c:59: > include/asm/futex.h: In function `futex_atomic_op_inuser': > include/asm/futex.h:62: error:

RE: [RFC PATCH 0/2] Fix linux/swap.h build wart

2007-10-26 Thread Luck, Tony
> These patches propose to break the recursion instead by removing the > linux/pagemap.h -> linux/highmem.h inclusion. I'd like to know > whether there are any fundamental reasons that this include should be > preserved. Not fundamental reasons, but these patches break the ia64 build for most

[RFC PATCH 0/2] Fix linux/swap.h build wart

2007-10-26 Thread Jeff Dike
For some time, there has been a problem of linux/swap.h using page_cache_release and release_pages without declaring them by including linux/pagemap.h. pagemap.h isn't included because that breaks the sparc build. The full details are in the next post, but the short story is that sparc's

[RFC PATCH 0/2] Fix linux/swap.h build wart

2007-10-26 Thread Jeff Dike
For some time, there has been a problem of linux/swap.h using page_cache_release and release_pages without declaring them by including linux/pagemap.h. pagemap.h isn't included because that breaks the sparc build. The full details are in the next post, but the short story is that sparc's

RE: [RFC PATCH 0/2] Fix linux/swap.h build wart

2007-10-26 Thread Luck, Tony
These patches propose to break the recursion instead by removing the linux/pagemap.h - linux/highmem.h inclusion. I'd like to know whether there are any fundamental reasons that this include should be preserved. Not fundamental reasons, but these patches break the ia64 build for most configs

Re: [RFC PATCH 0/2] Fix linux/swap.h build wart

2007-10-26 Thread Jeff Dike
On Fri, Oct 26, 2007 at 01:38:12PM -0700, Luck, Tony wrote: Not fundamental reasons, but these patches break the ia64 build for most configs with: In file included from kernel/futex.c:59: include/asm/futex.h: In function `futex_atomic_op_inuser': include/asm/futex.h:62: error: implicit