Re: [RFC PATCH 0/2] improve vmalloc allocation

2018-10-25 Thread Uladzislau Rezki
On Thu, Oct 25, 2018 at 10:43:27AM +0200, Michal Hocko wrote: > On Wed 24-10-18 19:34:18, Uladzislau Rezki wrote: > > Hi. > > > > On Wed, Oct 24, 2018 at 08:22:52AM +0200, Michal Hocko wrote: > > > On Tue 23-10-18 12:30:44, Joel Fernandes wrote: > > > > On Tue, Oct 23, 2018 at 11:13:36AM -0600, Sh

Re: [RFC PATCH 0/2] improve vmalloc allocation

2018-10-25 Thread Uladzislau Rezki
On Wed, Oct 24, 2018 at 04:01:06PM -0700, Andrew Morton wrote: > On Fri, 19 Oct 2018 19:35:36 +0200 "Uladzislau Rezki (Sony)" > wrote: > > > improving vmalloc allocator > > It's about time ;) > > Are you aware of https://lwn.net/Articles/285341/ ? If not, please do > take a look through Nick'

Re: [RFC PATCH 0/2] improve vmalloc allocation

2018-10-25 Thread Michal Hocko
On Wed 24-10-18 19:34:18, Uladzislau Rezki wrote: > Hi. > > On Wed, Oct 24, 2018 at 08:22:52AM +0200, Michal Hocko wrote: > > On Tue 23-10-18 12:30:44, Joel Fernandes wrote: > > > On Tue, Oct 23, 2018 at 11:13:36AM -0600, Shuah Khan wrote: > > > > On 10/23/2018 11:05 AM, Michal Hocko wrote: > > >

Re: [RFC PATCH 0/2] improve vmalloc allocation

2018-10-24 Thread Andrew Morton
On Fri, 19 Oct 2018 19:35:36 +0200 "Uladzislau Rezki (Sony)" wrote: > improving vmalloc allocator It's about time ;) Are you aware of https://lwn.net/Articles/285341/ ? If not, please do take a look through Nick's work and see if there are any good things there which can be borrowed.

Re: [RFC PATCH 0/2] improve vmalloc allocation

2018-10-24 Thread Uladzislau Rezki
Hi. On Wed, Oct 24, 2018 at 08:22:52AM +0200, Michal Hocko wrote: > On Tue 23-10-18 12:30:44, Joel Fernandes wrote: > > On Tue, Oct 23, 2018 at 11:13:36AM -0600, Shuah Khan wrote: > > > On 10/23/2018 11:05 AM, Michal Hocko wrote: > > > > On Tue 23-10-18 08:26:40, Matthew Wilcox wrote: > > > >> On

Re: [RFC PATCH 0/2] improve vmalloc allocation

2018-10-24 Thread Uladzislau Rezki
On Tue, Oct 23, 2018 at 08:26:40AM -0700, Matthew Wilcox wrote: > On Tue, Oct 23, 2018 at 09:02:56AM -0600, Shuah Khan wrote: > > Hi Michal, > > > > On 10/23/2018 01:23 AM, Michal Hocko wrote: > > > Hi Shuah, > > > > > > On Mon 22-10-18 18:52:53, Uladzislau Rezki wrote: > > >> On Mon, Oct 22, 201

Re: [RFC PATCH 0/2] improve vmalloc allocation

2018-10-23 Thread Michal Hocko
On Tue 23-10-18 12:30:44, Joel Fernandes wrote: > On Tue, Oct 23, 2018 at 11:13:36AM -0600, Shuah Khan wrote: > > On 10/23/2018 11:05 AM, Michal Hocko wrote: > > > On Tue 23-10-18 08:26:40, Matthew Wilcox wrote: > > >> On Tue, Oct 23, 2018 at 09:02:56AM -0600, Shuah Khan wrote: > > > [...] > > >>>

Re: [RFC PATCH 0/2] improve vmalloc allocation

2018-10-23 Thread Joel Fernandes
On Tue, Oct 23, 2018 at 01:09:23PM -0700, Matthew Wilcox wrote: > On Tue, Oct 23, 2018 at 01:48:32PM -0600, Shuah Khan wrote: > > On 10/23/2018 01:30 PM, Joel Fernandes wrote: > > > On Tue, Oct 23, 2018 at 11:13:36AM -0600, Shuah Khan wrote: > > >> I like this proposal. I think we will open up lot

Re: [RFC PATCH 0/2] improve vmalloc allocation

2018-10-23 Thread Shuah Khan
On 10/23/2018 02:09 PM, Matthew Wilcox wrote: > On Tue, Oct 23, 2018 at 01:48:32PM -0600, Shuah Khan wrote: >> On 10/23/2018 01:30 PM, Joel Fernandes wrote: >>> On Tue, Oct 23, 2018 at 11:13:36AM -0600, Shuah Khan wrote: I like this proposal. I think we will open up lot of test opportunities

Re: [RFC PATCH 0/2] improve vmalloc allocation

2018-10-23 Thread Matthew Wilcox
On Tue, Oct 23, 2018 at 01:48:32PM -0600, Shuah Khan wrote: > On 10/23/2018 01:30 PM, Joel Fernandes wrote: > > On Tue, Oct 23, 2018 at 11:13:36AM -0600, Shuah Khan wrote: > >> I like this proposal. I think we will open up lot of test opportunities > >> with > >> this approach. > >> > >> Maybe we

Re: [RFC PATCH 0/2] improve vmalloc allocation

2018-10-23 Thread Shuah Khan
On 10/23/2018 01:30 PM, Joel Fernandes wrote: > On Tue, Oct 23, 2018 at 11:13:36AM -0600, Shuah Khan wrote: >> On 10/23/2018 11:05 AM, Michal Hocko wrote: >>> On Tue 23-10-18 08:26:40, Matthew Wilcox wrote: On Tue, Oct 23, 2018 at 09:02:56AM -0600, Shuah Khan wrote: >>> [...] > The way it

Re: [RFC PATCH 0/2] improve vmalloc allocation

2018-10-23 Thread Joel Fernandes
On Tue, Oct 23, 2018 at 11:13:36AM -0600, Shuah Khan wrote: > On 10/23/2018 11:05 AM, Michal Hocko wrote: > > On Tue 23-10-18 08:26:40, Matthew Wilcox wrote: > >> On Tue, Oct 23, 2018 at 09:02:56AM -0600, Shuah Khan wrote: > > [...] > >>> The way it can be handled is by adding a test module under l

Re: [RFC PATCH 0/2] improve vmalloc allocation

2018-10-23 Thread Shuah Khan
On 10/23/2018 11:05 AM, Michal Hocko wrote: > On Tue 23-10-18 08:26:40, Matthew Wilcox wrote: >> On Tue, Oct 23, 2018 at 09:02:56AM -0600, Shuah Khan wrote: > [...] >>> The way it can be handled is by adding a test module under lib. test_kmod, >>> test_sysctl, test_user_copy etc. >> >> The problem

Re: [RFC PATCH 0/2] improve vmalloc allocation

2018-10-23 Thread Michal Hocko
On Tue 23-10-18 08:26:40, Matthew Wilcox wrote: > On Tue, Oct 23, 2018 at 09:02:56AM -0600, Shuah Khan wrote: [...] > > The way it can be handled is by adding a test module under lib. test_kmod, > > test_sysctl, test_user_copy etc. > > The problem is that said module can only invoke functions whic

Re: [RFC PATCH 0/2] improve vmalloc allocation

2018-10-23 Thread Matthew Wilcox
On Tue, Oct 23, 2018 at 09:02:56AM -0600, Shuah Khan wrote: > Hi Michal, > > On 10/23/2018 01:23 AM, Michal Hocko wrote: > > Hi Shuah, > > > > On Mon 22-10-18 18:52:53, Uladzislau Rezki wrote: > >> On Mon, Oct 22, 2018 at 02:51:42PM +0200, Michal Hocko wrote: > >>> Hi, > >>> I haven't read throug

Re: [RFC PATCH 0/2] improve vmalloc allocation

2018-10-23 Thread Shuah Khan
Hi Michal, On 10/23/2018 01:23 AM, Michal Hocko wrote: > Hi Shuah, > > On Mon 22-10-18 18:52:53, Uladzislau Rezki wrote: >> On Mon, Oct 22, 2018 at 02:51:42PM +0200, Michal Hocko wrote: >>> Hi, >>> I haven't read through the implementation yet but I have say that I >>> really love this cover lett

Re: [RFC PATCH 0/2] improve vmalloc allocation

2018-10-23 Thread Michal Hocko
Hi Shuah, On Mon 22-10-18 18:52:53, Uladzislau Rezki wrote: > On Mon, Oct 22, 2018 at 02:51:42PM +0200, Michal Hocko wrote: > > Hi, > > I haven't read through the implementation yet but I have say that I > > really love this cover letter. It is clear on intetion, it covers design > > from high lev

Re: [RFC PATCH 0/2] improve vmalloc allocation

2018-10-22 Thread Joel Fernandes
On Mon, Oct 22, 2018 at 04:50:06PM +0200, Uladzislau Rezki wrote: > On Fri, Oct 19, 2018 at 05:11:45PM -0700, Joel Fernandes wrote: > > On Fri, Oct 19, 2018 at 07:35:36PM +0200, Uladzislau Rezki (Sony) wrote: > > > Objective > > > - > > > Initiative of improving vmalloc allocator comes from

Re: [RFC PATCH 0/2] improve vmalloc allocation

2018-10-22 Thread Uladzislau Rezki
On Mon, Oct 22, 2018 at 02:51:42PM +0200, Michal Hocko wrote: > Hi, > I haven't read through the implementation yet but I have say that I > really love this cover letter. It is clear on intetion, it covers design > from high level enough to start discussion and provides a very nice > testing covera

Re: [RFC PATCH 0/2] improve vmalloc allocation

2018-10-22 Thread Uladzislau Rezki
On Fri, Oct 19, 2018 at 05:11:45PM -0700, Joel Fernandes wrote: > On Fri, Oct 19, 2018 at 07:35:36PM +0200, Uladzislau Rezki (Sony) wrote: > > Objective > > - > > Initiative of improving vmalloc allocator comes from getting many issues > > related to allocation time, i.e. sometimes it is te

Re: [RFC PATCH 0/2] improve vmalloc allocation

2018-10-22 Thread Uladzislau Rezki
On Fri, Oct 19, 2018 at 10:44:39PM +, Roman Gushchin wrote: > On Fri, Oct 19, 2018 at 07:35:36PM +0200, Uladzislau Rezki (Sony) wrote: > > Objective > > - > > Initiative of improving vmalloc allocator comes from getting many issues > > related to allocation time, i.e. sometimes it is te

Re: [RFC PATCH 0/2] improve vmalloc allocation

2018-10-22 Thread Michal Hocko
Hi, I haven't read through the implementation yet but I have say that I really love this cover letter. It is clear on intetion, it covers design from high level enough to start discussion and provides a very nice testing coverage. Nice work! I also think that we need a better performing vmalloc im

Re: [RFC PATCH 0/2] improve vmalloc allocation

2018-10-19 Thread Joel Fernandes
On Fri, Oct 19, 2018 at 07:35:36PM +0200, Uladzislau Rezki (Sony) wrote: > Objective > - > Initiative of improving vmalloc allocator comes from getting many issues > related to allocation time, i.e. sometimes it is terribly slow. As a result > many workloads which are sensitive for long (mo

Re: [RFC PATCH 0/2] improve vmalloc allocation

2018-10-19 Thread Roman Gushchin
On Fri, Oct 19, 2018 at 07:35:36PM +0200, Uladzislau Rezki (Sony) wrote: > Objective > - > Initiative of improving vmalloc allocator comes from getting many issues > related to allocation time, i.e. sometimes it is terribly slow. As a result > many workloads which are sensitive for long (mo

[RFC PATCH 0/2] improve vmalloc allocation

2018-10-19 Thread Uladzislau Rezki (Sony)
Objective - Initiative of improving vmalloc allocator comes from getting many issues related to allocation time, i.e. sometimes it is terribly slow. As a result many workloads which are sensitive for long (more than 1 millisecond) preemption off scenario are affected by that slowness(test c