Re: [RFC PATCH 0/2] tracing: Teach FETCH_MTD_symbol to handle per-cpu data

2013-11-27 Thread Masami Hiramatsu
(2013/11/28 2:41), Oleg Nesterov wrote: > On 11/27, Masami Hiramatsu wrote: >> >> (2013/11/27 2:43), Oleg Nesterov wrote: >>> >>> This doesn't allow to read the data from other CPUs, but at least >>> the changes are simple and this_cpu_ is better than the reading >>> from the obviously wrong addres

Re: [RFC PATCH 0/2] tracing: Teach FETCH_MTD_symbol to handle per-cpu data

2013-11-27 Thread Oleg Nesterov
On 11/27, Masami Hiramatsu wrote: > > (2013/11/27 2:43), Oleg Nesterov wrote: > > > > This doesn't allow to read the data from other CPUs, but at least > > the changes are simple and this_cpu_ is better than the reading > > from the obviously wrong address. > > Yeah, usually per_cpu variable is use

Re: [RFC PATCH 0/2] tracing: Teach FETCH_MTD_symbol to handle per-cpu data

2013-11-27 Thread Masami Hiramatsu
(2013/11/27 2:43), Oleg Nesterov wrote: > On 11/26, Masami Hiramatsu wrote: >> >> (2013/11/26 2:22), Oleg Nesterov wrote: >>> @symbol can't be used to dump the per-cpu variables. The same is >>> true for +offset(something) if "something" results in __percpu >>> pointer. >>> >>> With this patch pars

Re: [RFC PATCH 0/2] tracing: Teach FETCH_MTD_symbol to handle per-cpu data

2013-11-26 Thread Namhyung Kim
Hi Oleg, (Please use my korg email address, otherwise I might not see - at least in time - the messages.) 2013-11-27 AM 2:43, Oleg Nesterov wrote: On 11/26, Masami Hiramatsu wrote: If the symbol is percpu, it should be automatically translated to something like FETCH_percpu, instead of such

[RFC PATCH 0/2] tracing: Teach FETCH_MTD_symbol to handle per-cpu data

2013-11-26 Thread Oleg Nesterov
On 11/26, Masami Hiramatsu wrote: > > (2013/11/26 2:22), Oleg Nesterov wrote: > > @symbol can't be used to dump the per-cpu variables. The same is > > true for +offset(something) if "something" results in __percpu > > pointer. > > > > With this patch parse_probe_offset() treats "~" before the numer