Re: [RFC PATCH 0/7] runtime format string checking

2018-11-05 Thread Rasmus Villemoes
On 2018-11-01 23:57, Kees Cook wrote: >> Yes, gcc should be able to infer the constness of drv from the fact that >> it's never assigned to elsewhere in the function... I think I saw that >> on some gcc todo list at some point. > > If you find that bug, I'll add it to my gcc bug tracking list.

Re: [RFC PATCH 0/7] runtime format string checking

2018-11-05 Thread Rasmus Villemoes
On 2018-11-01 23:57, Kees Cook wrote: >> Yes, gcc should be able to infer the constness of drv from the fact that >> it's never assigned to elsewhere in the function... I think I saw that >> on some gcc todo list at some point. > > If you find that bug, I'll add it to my gcc bug tracking list.

Re: [RFC PATCH 0/7] runtime format string checking

2018-11-02 Thread Kees Cook
On Fri, Nov 2, 2018 at 1:09 PM, Rasmus Villemoes wrote: > That's a bit too naive. At the very least, you must exclude static > stuff, i.e. restrict to actual auto variables. Otherwise you're making > things worse (a "static const char []" just occupies some space in > .rodata, a "static const

Re: [RFC PATCH 0/7] runtime format string checking

2018-11-02 Thread Kees Cook
On Fri, Nov 2, 2018 at 1:09 PM, Rasmus Villemoes wrote: > That's a bit too naive. At the very least, you must exclude static > stuff, i.e. restrict to actual auto variables. Otherwise you're making > things worse (a "static const char []" just occupies some space in > .rodata, a "static const

Re: [RFC PATCH 0/7] runtime format string checking

2018-11-02 Thread Rasmus Villemoes
[trimming cc list] On 2018-11-01 23:57, Kees Cook wrote: > On Thu, Nov 1, 2018 at 3:06 PM, Rasmus Villemoes > wrote: >> referring to an anonymous object in .rodata; one gets code gen like >> >> +: 31 c0 xor%eax,%eax >> +: 48 b8 61 63 70 69 2dmovabs

Re: [RFC PATCH 0/7] runtime format string checking

2018-11-02 Thread Rasmus Villemoes
[trimming cc list] On 2018-11-01 23:57, Kees Cook wrote: > On Thu, Nov 1, 2018 at 3:06 PM, Rasmus Villemoes > wrote: >> referring to an anonymous object in .rodata; one gets code gen like >> >> +: 31 c0 xor%eax,%eax >> +: 48 b8 61 63 70 69 2dmovabs