Re: [RFC PATCH 00/13][V3] kexec: A new system call to allow in kernel loading

2014-06-18 Thread Vivek Goyal
On Wed, Jun 18, 2014 at 09:52:46AM +0800, Dave Young wrote: [..] > > > > Hi, Vivek > > > > > > > > For efi ioremapping case, in 3.15 kernel efi runtime maps will not be > > > > saved > > > > if efi=old_map is used. So you need detect this and fail the kexec file > > > > load. > > > > > > Dave,

Re: [RFC PATCH 00/13][V3] kexec: A new system call to allow in kernel loading

2014-06-18 Thread Vivek Goyal
On Wed, Jun 18, 2014 at 09:52:46AM +0800, Dave Young wrote: [..] Hi, Vivek For efi ioremapping case, in 3.15 kernel efi runtime maps will not be saved if efi=old_map is used. So you need detect this and fail the kexec file load. Dave, Instead of failing

Re: [RFC PATCH 00/13][V3] kexec: A new system call to allow in kernel loading

2014-06-17 Thread Dave Young
On 06/18/14 at 09:45am, Dave Young wrote: > On 06/17/14 at 10:24am, Vivek Goyal wrote: > > On Thu, Jun 12, 2014 at 01:42:03PM +0800, Dave Young wrote: > > > On 06/03/14 at 09:06am, Vivek Goyal wrote: > > > > Hi, > > > > > > > > This is V3 of the patchset. Previous versions were posted here. > > >

Re: [RFC PATCH 00/13][V3] kexec: A new system call to allow in kernel loading

2014-06-17 Thread Dave Young
On 06/17/14 at 10:24am, Vivek Goyal wrote: > On Thu, Jun 12, 2014 at 01:42:03PM +0800, Dave Young wrote: > > On 06/03/14 at 09:06am, Vivek Goyal wrote: > > > Hi, > > > > > > This is V3 of the patchset. Previous versions were posted here. > > > > > > V1: https://lkml.org/lkml/2013/11/20/540 > > >

Re: [RFC PATCH 00/13][V3] kexec: A new system call to allow in kernel loading

2014-06-17 Thread Vivek Goyal
On Thu, Jun 12, 2014 at 01:42:03PM +0800, Dave Young wrote: > On 06/03/14 at 09:06am, Vivek Goyal wrote: > > Hi, > > > > This is V3 of the patchset. Previous versions were posted here. > > > > V1: https://lkml.org/lkml/2013/11/20/540 > > V2: https://lkml.org/lkml/2014/1/27/331 > > > > Changes

Re: [RFC PATCH 00/13][V3] kexec: A new system call to allow in kernel loading

2014-06-17 Thread Vivek Goyal
On Mon, Jun 16, 2014 at 11:13:28PM +0200, Borislav Petkov wrote: > On Tue, Jun 03, 2014 at 09:06:49AM -0400, Vivek Goyal wrote: > > This patch series does not do kernel signature verification yet. I > > plan to post another patch series for that. Now bzImage is already > > signed with PKCS7

Re: [RFC PATCH 00/13][V3] kexec: A new system call to allow in kernel loading

2014-06-17 Thread Vivek Goyal
On Mon, Jun 16, 2014 at 11:13:28PM +0200, Borislav Petkov wrote: On Tue, Jun 03, 2014 at 09:06:49AM -0400, Vivek Goyal wrote: This patch series does not do kernel signature verification yet. I plan to post another patch series for that. Now bzImage is already signed with PKCS7 signature I

Re: [RFC PATCH 00/13][V3] kexec: A new system call to allow in kernel loading

2014-06-17 Thread Vivek Goyal
On Thu, Jun 12, 2014 at 01:42:03PM +0800, Dave Young wrote: On 06/03/14 at 09:06am, Vivek Goyal wrote: Hi, This is V3 of the patchset. Previous versions were posted here. V1: https://lkml.org/lkml/2013/11/20/540 V2: https://lkml.org/lkml/2014/1/27/331 Changes since v2: -

Re: [RFC PATCH 00/13][V3] kexec: A new system call to allow in kernel loading

2014-06-17 Thread Dave Young
On 06/17/14 at 10:24am, Vivek Goyal wrote: On Thu, Jun 12, 2014 at 01:42:03PM +0800, Dave Young wrote: On 06/03/14 at 09:06am, Vivek Goyal wrote: Hi, This is V3 of the patchset. Previous versions were posted here. V1: https://lkml.org/lkml/2013/11/20/540 V2:

Re: [RFC PATCH 00/13][V3] kexec: A new system call to allow in kernel loading

2014-06-17 Thread Dave Young
On 06/18/14 at 09:45am, Dave Young wrote: On 06/17/14 at 10:24am, Vivek Goyal wrote: On Thu, Jun 12, 2014 at 01:42:03PM +0800, Dave Young wrote: On 06/03/14 at 09:06am, Vivek Goyal wrote: Hi, This is V3 of the patchset. Previous versions were posted here. V1:

Re: [RFC PATCH 00/13][V3] kexec: A new system call to allow in kernel loading

2014-06-16 Thread Borislav Petkov
On Tue, Jun 03, 2014 at 09:06:49AM -0400, Vivek Goyal wrote: > This patch series does not do kernel signature verification yet. I > plan to post another patch series for that. Now bzImage is already > signed with PKCS7 signature I plan to parse and verify those > signatures. Btw, do you have a

Re: [RFC PATCH 00/13][V3] kexec: A new system call to allow in kernel loading

2014-06-16 Thread Borislav Petkov
On Tue, Jun 03, 2014 at 09:06:49AM -0400, Vivek Goyal wrote: This patch series does not do kernel signature verification yet. I plan to post another patch series for that. Now bzImage is already signed with PKCS7 signature I plan to parse and verify those signatures. Btw, do you have a brief

Re: [RFC PATCH 00/13][V3] kexec: A new system call to allow in kernel loading

2014-06-12 Thread Vivek Goyal
On Thu, Jun 12, 2014 at 01:42:03PM +0800, Dave Young wrote: > On 06/03/14 at 09:06am, Vivek Goyal wrote: > > Hi, > > > > This is V3 of the patchset. Previous versions were posted here. > > > > V1: https://lkml.org/lkml/2013/11/20/540 > > V2: https://lkml.org/lkml/2014/1/27/331 > > > > Changes

Re: [RFC PATCH 00/13][V3] kexec: A new system call to allow in kernel loading

2014-06-12 Thread Vivek Goyal
On Thu, Jun 12, 2014 at 01:42:03PM +0800, Dave Young wrote: On 06/03/14 at 09:06am, Vivek Goyal wrote: Hi, This is V3 of the patchset. Previous versions were posted here. V1: https://lkml.org/lkml/2013/11/20/540 V2: https://lkml.org/lkml/2014/1/27/331 Changes since v2: -

Re: [RFC PATCH 00/13][V3] kexec: A new system call to allow in kernel loading

2014-06-11 Thread Dave Young
On 06/03/14 at 09:06am, Vivek Goyal wrote: > Hi, > > This is V3 of the patchset. Previous versions were posted here. > > V1: https://lkml.org/lkml/2013/11/20/540 > V2: https://lkml.org/lkml/2014/1/27/331 > > Changes since v2: > > - Took care of most of the review comments from V2. > - Added

Re: [RFC PATCH 00/13][V3] kexec: A new system call to allow in kernel loading

2014-06-11 Thread Dave Young
On 06/03/14 at 09:06am, Vivek Goyal wrote: Hi, This is V3 of the patchset. Previous versions were posted here. V1: https://lkml.org/lkml/2013/11/20/540 V2: https://lkml.org/lkml/2014/1/27/331 Changes since v2: - Took care of most of the review comments from V2. - Added support for

Re: [RFC PATCH 00/13][V3] kexec: A new system call to allow in kernel loading

2014-06-08 Thread Dave Young
On 06/06/14 at 04:04pm, Vivek Goyal wrote: > On Fri, Jun 06, 2014 at 03:37:48PM +0800, Dave Young wrote: > > On 06/05/14 at 11:01am, Vivek Goyal wrote: > > > On Thu, Jun 05, 2014 at 04:31:34PM +0800, Dave Young wrote: > > > > > > [..] > > > > > + ret = kexec_file_load(kernel_fd,

Re: [RFC PATCH 00/13][V3] kexec: A new system call to allow in kernel loading

2014-06-08 Thread Dave Young
On 06/06/14 at 04:04pm, Vivek Goyal wrote: On Fri, Jun 06, 2014 at 03:37:48PM +0800, Dave Young wrote: On 06/05/14 at 11:01am, Vivek Goyal wrote: On Thu, Jun 05, 2014 at 04:31:34PM +0800, Dave Young wrote: [..] + ret = kexec_file_load(kernel_fd, info.initrd_fd,

Re: [RFC PATCH 00/13][V3] kexec: A new system call to allow in kernel loading

2014-06-06 Thread Matt Fleming
On 6 June 2014 22:00, H. Peter Anvin wrote: > > Yes, presumably (as a separate patch since the actual commit is quite > large.) The patch needs to have a good description why the original > patch was wrong. Right. I'll take a look at this in the morning. -- To unsubscribe from this list: send

Re: [RFC PATCH 00/13][V3] kexec: A new system call to allow in kernel loading

2014-06-06 Thread H. Peter Anvin
On 06/06/2014 01:58 PM, Matt Fleming wrote: > On 6 June 2014 21:37, H. Peter Anvin wrote: >> >> OK... this is seriously problematic. >> >> #if defined(CONFIG_RELOCATABLE) && defined(CONFIG_X86_64) && \ >> !defined(CONFIG_EFI_MIXED) >>/* kernel/boot_param/ramdisk could be loaded above

Re: [RFC PATCH 00/13][V3] kexec: A new system call to allow in kernel loading

2014-06-06 Thread Matt Fleming
On 6 June 2014 21:37, H. Peter Anvin wrote: > > OK... this is seriously problematic. > > #if defined(CONFIG_RELOCATABLE) && defined(CONFIG_X86_64) && \ > !defined(CONFIG_EFI_MIXED) >/* kernel/boot_param/ramdisk could be loaded above 4g */ > # define XLF1 XLF_CAN_BE_LOADED_ABOVE_4G >

Re: [RFC PATCH 00/13][V3] kexec: A new system call to allow in kernel loading

2014-06-06 Thread H. Peter Anvin
On 06/06/2014 12:37 AM, Dave Young wrote: > On 06/05/14 at 11:01am, Vivek Goyal wrote: >> On Thu, Jun 05, 2014 at 04:31:34PM +0800, Dave Young wrote: >> >> [..] + ret = kexec_file_load(kernel_fd, info.initrd_fd, info.command_line, + info.command_line_len,

Re: [RFC PATCH 00/13][V3] kexec: A new system call to allow in kernel loading

2014-06-06 Thread Vivek Goyal
On Fri, Jun 06, 2014 at 03:37:48PM +0800, Dave Young wrote: > On 06/05/14 at 11:01am, Vivek Goyal wrote: > > On Thu, Jun 05, 2014 at 04:31:34PM +0800, Dave Young wrote: > > > > [..] > > > > + ret = kexec_file_load(kernel_fd, info.initrd_fd, > > > > info.command_line, > > > > +

Re: [RFC PATCH 00/13][V3] kexec: A new system call to allow in kernel loading

2014-06-06 Thread Vivek Goyal
On Fri, Jun 06, 2014 at 07:45:17AM +0200, Michael Kerrisk (man-pages) wrote: > On 06/05/2014 04:04 PM, Vivek Goyal wrote: > > On Wed, Jun 04, 2014 at 09:39:10PM +0200, Michael Kerrisk wrote: > >> Vivek, > >> > >> As per Documentation/SubmitChecklist , please CC linux-api@ on patces > >> that

Re: [RFC PATCH 00/13][V3] kexec: A new system call to allow in kernel loading

2014-06-06 Thread Dave Young
On 06/05/14 at 11:01am, Vivek Goyal wrote: > On Thu, Jun 05, 2014 at 04:31:34PM +0800, Dave Young wrote: > > [..] > > > + ret = kexec_file_load(kernel_fd, info.initrd_fd, info.command_line, > > > + info.command_line_len, info.kexec_flags); > > > > Vivek, > > > > I tried your

Re: [RFC PATCH 00/13][V3] kexec: A new system call to allow in kernel loading

2014-06-06 Thread Dave Young
On 06/05/14 at 11:01am, Vivek Goyal wrote: On Thu, Jun 05, 2014 at 04:31:34PM +0800, Dave Young wrote: [..] + ret = kexec_file_load(kernel_fd, info.initrd_fd, info.command_line, + info.command_line_len, info.kexec_flags); Vivek, I tried your patch on my uefi

Re: [RFC PATCH 00/13][V3] kexec: A new system call to allow in kernel loading

2014-06-06 Thread Vivek Goyal
On Fri, Jun 06, 2014 at 07:45:17AM +0200, Michael Kerrisk (man-pages) wrote: On 06/05/2014 04:04 PM, Vivek Goyal wrote: On Wed, Jun 04, 2014 at 09:39:10PM +0200, Michael Kerrisk wrote: Vivek, As per Documentation/SubmitChecklist , please CC linux-api@ on patces that change the ABI/API.

Re: [RFC PATCH 00/13][V3] kexec: A new system call to allow in kernel loading

2014-06-06 Thread Vivek Goyal
On Fri, Jun 06, 2014 at 03:37:48PM +0800, Dave Young wrote: On 06/05/14 at 11:01am, Vivek Goyal wrote: On Thu, Jun 05, 2014 at 04:31:34PM +0800, Dave Young wrote: [..] + ret = kexec_file_load(kernel_fd, info.initrd_fd, info.command_line, +

Re: [RFC PATCH 00/13][V3] kexec: A new system call to allow in kernel loading

2014-06-06 Thread H. Peter Anvin
On 06/06/2014 12:37 AM, Dave Young wrote: On 06/05/14 at 11:01am, Vivek Goyal wrote: On Thu, Jun 05, 2014 at 04:31:34PM +0800, Dave Young wrote: [..] + ret = kexec_file_load(kernel_fd, info.initrd_fd, info.command_line, + info.command_line_len, info.kexec_flags); Vivek,

Re: [RFC PATCH 00/13][V3] kexec: A new system call to allow in kernel loading

2014-06-06 Thread Matt Fleming
On 6 June 2014 21:37, H. Peter Anvin h...@zytor.com wrote: OK... this is seriously problematic. #if defined(CONFIG_RELOCATABLE) defined(CONFIG_X86_64) \ !defined(CONFIG_EFI_MIXED) /* kernel/boot_param/ramdisk could be loaded above 4g */ # define XLF1 XLF_CAN_BE_LOADED_ABOVE_4G

Re: [RFC PATCH 00/13][V3] kexec: A new system call to allow in kernel loading

2014-06-06 Thread H. Peter Anvin
On 06/06/2014 01:58 PM, Matt Fleming wrote: On 6 June 2014 21:37, H. Peter Anvin h...@zytor.com wrote: OK... this is seriously problematic. #if defined(CONFIG_RELOCATABLE) defined(CONFIG_X86_64) \ !defined(CONFIG_EFI_MIXED) /* kernel/boot_param/ramdisk could be loaded above 4g

Re: [RFC PATCH 00/13][V3] kexec: A new system call to allow in kernel loading

2014-06-06 Thread Matt Fleming
On 6 June 2014 22:00, H. Peter Anvin h...@zytor.com wrote: Yes, presumably (as a separate patch since the actual commit is quite large.) The patch needs to have a good description why the original patch was wrong. Right. I'll take a look at this in the morning. -- To unsubscribe from this

Re: [RFC PATCH 00/13][V3] kexec: A new system call to allow in kernel loading

2014-06-05 Thread Michael Kerrisk (man-pages)
On 06/05/2014 04:04 PM, Vivek Goyal wrote: > On Wed, Jun 04, 2014 at 09:39:10PM +0200, Michael Kerrisk wrote: >> Vivek, >> >> As per Documentation/SubmitChecklist , please CC linux-api@ on patces >> that change the ABI/API. See >> https://www.kernel.org/doc/man-pages/linux-api-ml.html. > > Hi

Re: [RFC PATCH 00/13][V3] kexec: A new system call to allow in kernel loading

2014-06-05 Thread Vivek Goyal
On Thu, Jun 05, 2014 at 04:31:34PM +0800, Dave Young wrote: [..] > > + ret = kexec_file_load(kernel_fd, info.initrd_fd, info.command_line, > > + info.command_line_len, info.kexec_flags); > > Vivek, > > I tried your patch on my uefi test machine, but kexec load fails like

Re: [RFC PATCH 00/13][V3] kexec: A new system call to allow in kernel loading

2014-06-05 Thread Vivek Goyal
On Wed, Jun 04, 2014 at 09:39:10PM +0200, Michael Kerrisk wrote: > Vivek, > > As per Documentation/SubmitChecklist , please CC linux-api@ on patces > that change the ABI/API. See > https://www.kernel.org/doc/man-pages/linux-api-ml.html. Hi Michael, Sorry, I did not notice that. I will CC

Re: [RFC PATCH 00/13][V3] kexec: A new system call to allow in kernel loading

2014-06-05 Thread Dave Young
On 06/03/14 at 09:12am, Vivek Goyal wrote: > On Tue, Jun 03, 2014 at 09:06:49AM -0400, Vivek Goyal wrote: > > Hi, > > > > This is V3 of the patchset. Previous versions were posted here. > > > > V1: https://lkml.org/lkml/2013/11/20/540 > > V2: https://lkml.org/lkml/2014/1/27/331 > > > > Changes

Re: [RFC PATCH 00/13][V3] kexec: A new system call to allow in kernel loading

2014-06-05 Thread Dave Young
On 06/03/14 at 09:12am, Vivek Goyal wrote: On Tue, Jun 03, 2014 at 09:06:49AM -0400, Vivek Goyal wrote: Hi, This is V3 of the patchset. Previous versions were posted here. V1: https://lkml.org/lkml/2013/11/20/540 V2: https://lkml.org/lkml/2014/1/27/331 Changes since v2: -

Re: [RFC PATCH 00/13][V3] kexec: A new system call to allow in kernel loading

2014-06-05 Thread Vivek Goyal
On Wed, Jun 04, 2014 at 09:39:10PM +0200, Michael Kerrisk wrote: Vivek, As per Documentation/SubmitChecklist , please CC linux-api@ on patces that change the ABI/API. See https://www.kernel.org/doc/man-pages/linux-api-ml.html. Hi Michael, Sorry, I did not notice that. I will CC linux-api@

Re: [RFC PATCH 00/13][V3] kexec: A new system call to allow in kernel loading

2014-06-05 Thread Vivek Goyal
On Thu, Jun 05, 2014 at 04:31:34PM +0800, Dave Young wrote: [..] + ret = kexec_file_load(kernel_fd, info.initrd_fd, info.command_line, + info.command_line_len, info.kexec_flags); Vivek, I tried your patch on my uefi test machine, but kexec load fails like below:

Re: [RFC PATCH 00/13][V3] kexec: A new system call to allow in kernel loading

2014-06-05 Thread Michael Kerrisk (man-pages)
On 06/05/2014 04:04 PM, Vivek Goyal wrote: On Wed, Jun 04, 2014 at 09:39:10PM +0200, Michael Kerrisk wrote: Vivek, As per Documentation/SubmitChecklist , please CC linux-api@ on patces that change the ABI/API. See https://www.kernel.org/doc/man-pages/linux-api-ml.html. Hi Michael,

Re: [RFC PATCH 00/13][V3] kexec: A new system call to allow in kernel loading

2014-06-04 Thread Michael Kerrisk
Vivek, As per Documentation/SubmitChecklist , please CC linux-api@ on patces that change the ABI/API. See https://www.kernel.org/doc/man-pages/linux-api-ml.html. Also, is there some draft man page for this new system call? Thanks, Michael On Wed, Jun 4, 2014 at 7:50 PM, Vivek Goyal wrote: >

Re: [RFC PATCH 00/13][V3] kexec: A new system call to allow in kernel loading

2014-06-04 Thread Vivek Goyal
On Wed, Jun 04, 2014 at 05:22:14PM +0800, WANG Chao wrote: [..] > > Index: kexec-tools/kexec/kexec.h > > === > > --- kexec-tools.orig/kexec/kexec.h 2014-06-02 14:34:16.719774316 -0400 > > +++ kexec-tools/kexec/kexec.h

Re: [RFC PATCH 00/13][V3] kexec: A new system call to allow in kernel loading

2014-06-04 Thread WANG Chao
On 06/03/14 at 09:12am, Vivek Goyal wrote: > On Tue, Jun 03, 2014 at 09:06:49AM -0400, Vivek Goyal wrote: > > Hi, > > > > This is V3 of the patchset. Previous versions were posted here. > > > > V1: https://lkml.org/lkml/2013/11/20/540 > > V2: https://lkml.org/lkml/2014/1/27/331 > > > > Changes

Re: [RFC PATCH 00/13][V3] kexec: A new system call to allow in kernel loading

2014-06-04 Thread WANG Chao
On 06/03/14 at 09:12am, Vivek Goyal wrote: On Tue, Jun 03, 2014 at 09:06:49AM -0400, Vivek Goyal wrote: Hi, This is V3 of the patchset. Previous versions were posted here. V1: https://lkml.org/lkml/2013/11/20/540 V2: https://lkml.org/lkml/2014/1/27/331 Changes since v2: -

Re: [RFC PATCH 00/13][V3] kexec: A new system call to allow in kernel loading

2014-06-04 Thread Vivek Goyal
On Wed, Jun 04, 2014 at 05:22:14PM +0800, WANG Chao wrote: [..] Index: kexec-tools/kexec/kexec.h === --- kexec-tools.orig/kexec/kexec.h 2014-06-02 14:34:16.719774316 -0400 +++ kexec-tools/kexec/kexec.h 2014-06-02

Re: [RFC PATCH 00/13][V3] kexec: A new system call to allow in kernel loading

2014-06-04 Thread Michael Kerrisk
Vivek, As per Documentation/SubmitChecklist , please CC linux-api@ on patces that change the ABI/API. See https://www.kernel.org/doc/man-pages/linux-api-ml.html. Also, is there some draft man page for this new system call? Thanks, Michael On Wed, Jun 4, 2014 at 7:50 PM, Vivek Goyal

Re: [RFC PATCH 00/13][V3] kexec: A new system call to allow in kernel loading

2014-06-03 Thread Vivek Goyal
On Tue, Jun 03, 2014 at 09:06:49AM -0400, Vivek Goyal wrote: > Hi, > > This is V3 of the patchset. Previous versions were posted here. > > V1: https://lkml.org/lkml/2013/11/20/540 > V2: https://lkml.org/lkml/2014/1/27/331 > > Changes since v2: > > - Took care of most of the review comments

[RFC PATCH 00/13][V3] kexec: A new system call to allow in kernel loading

2014-06-03 Thread Vivek Goyal
Hi, This is V3 of the patchset. Previous versions were posted here. V1: https://lkml.org/lkml/2013/11/20/540 V2: https://lkml.org/lkml/2014/1/27/331 Changes since v2: - Took care of most of the review comments from V2. - Added support for kexec/kdump on EFI systems. - Dropped support for

[RFC PATCH 00/13][V3] kexec: A new system call to allow in kernel loading

2014-06-03 Thread Vivek Goyal
Hi, This is V3 of the patchset. Previous versions were posted here. V1: https://lkml.org/lkml/2013/11/20/540 V2: https://lkml.org/lkml/2014/1/27/331 Changes since v2: - Took care of most of the review comments from V2. - Added support for kexec/kdump on EFI systems. - Dropped support for

Re: [RFC PATCH 00/13][V3] kexec: A new system call to allow in kernel loading

2014-06-03 Thread Vivek Goyal
On Tue, Jun 03, 2014 at 09:06:49AM -0400, Vivek Goyal wrote: Hi, This is V3 of the patchset. Previous versions were posted here. V1: https://lkml.org/lkml/2013/11/20/540 V2: https://lkml.org/lkml/2014/1/27/331 Changes since v2: - Took care of most of the review comments from V2. -