Re: [RFC PATCH 01/11] vfs: push __sync_blockdev calls down into sync_fs routines

2018-05-18 Thread Jeff Layton
On Fri, 2018-05-18 at 08:56 -0700, Christoph Hellwig wrote: > > --- a/fs/xfs/xfs_super.c > > +++ b/fs/xfs/xfs_super.c > > @@ -1097,7 +1097,7 @@ xfs_fs_sync_fs( > > * Doing anything during the async pass would be counterproductive. > > */ > > if (!wait) > > - return 0; > > +

Re: [RFC PATCH 01/11] vfs: push __sync_blockdev calls down into sync_fs routines

2018-05-18 Thread Christoph Hellwig
> --- a/fs/xfs/xfs_super.c > +++ b/fs/xfs/xfs_super.c > @@ -1097,7 +1097,7 @@ xfs_fs_sync_fs( >* Doing anything during the async pass would be counterproductive. >*/ > if (!wait) > - return 0; > + goto out; > > xfs_log_force(mp, XFS_LOG_SYNC); >

[RFC PATCH 01/11] vfs: push __sync_blockdev calls down into sync_fs routines

2018-05-18 Thread Jeff Layton
From: Jeff Layton In later patches, we're going to want allow the sync_fs routine to override the return value of __sync_blockdev in some situations. This call is pointless for filesystems that do not set sb->s_bdev, so we can also make things slightly more efficient for those filesystems by not