Re: [RFC PATCH 01/13] fs/userfaultfd: fix wrong error code on WP & !VM_MAYWRITE

2020-12-21 Thread Peter Xu
On Tue, Dec 01, 2020 at 01:22:32PM -0800, Mike Kravetz wrote: > On 11/28/20 4:45 PM, Nadav Amit wrote: > > From: Nadav Amit > > > > It is possible to get an EINVAL error instead of EPERM if the following > > test vm_flags have VM_UFFD_WP but do not have VM_MAYWRITE, as "ret" is > > overwritten si

Re: [RFC PATCH 01/13] fs/userfaultfd: fix wrong error code on WP & !VM_MAYWRITE

2020-12-01 Thread Mike Kravetz
On 11/28/20 4:45 PM, Nadav Amit wrote: > From: Nadav Amit > > It is possible to get an EINVAL error instead of EPERM if the following > test vm_flags have VM_UFFD_WP but do not have VM_MAYWRITE, as "ret" is > overwritten since commit cab350afcbc9 ("userfaultfd: hugetlbfs: allow > registration of

[RFC PATCH 01/13] fs/userfaultfd: fix wrong error code on WP & !VM_MAYWRITE

2020-11-28 Thread Nadav Amit
From: Nadav Amit It is possible to get an EINVAL error instead of EPERM if the following test vm_flags have VM_UFFD_WP but do not have VM_MAYWRITE, as "ret" is overwritten since commit cab350afcbc9 ("userfaultfd: hugetlbfs: allow registration of ranges containing huge pages"). Fix it. Cc: Mike