Re: [RFC PATCH 01/13] of: Remove comments that state the obvious

2016-10-27 Thread Frank Rowand
On 10/27/16 05:18, Rob Herring wrote: > On Tue, Oct 25, 2016 at 3:58 PM, wrote: >> From: Frank Rowand >> >> Remove comments that state the obvious, to reduce clutter > > I'm probably not the best reviewer, have you ever seen a comment in my

Re: [RFC PATCH 01/13] of: Remove comments that state the obvious

2016-10-27 Thread Frank Rowand
On 10/27/16 05:18, Rob Herring wrote: > On Tue, Oct 25, 2016 at 3:58 PM, wrote: >> From: Frank Rowand >> >> Remove comments that state the obvious, to reduce clutter > > I'm probably not the best reviewer, have you ever seen a comment in my code. > :) > >> >> Signed-off-by: Frank Rowand >>

Re: [RFC PATCH 01/13] of: Remove comments that state the obvious

2016-10-27 Thread Rob Herring
On Tue, Oct 25, 2016 at 3:58 PM, wrote: > From: Frank Rowand > > Remove comments that state the obvious, to reduce clutter I'm probably not the best reviewer, have you ever seen a comment in my code. :) > > Signed-off-by: Frank Rowand

Re: [RFC PATCH 01/13] of: Remove comments that state the obvious

2016-10-27 Thread Rob Herring
On Tue, Oct 25, 2016 at 3:58 PM, wrote: > From: Frank Rowand > > Remove comments that state the obvious, to reduce clutter I'm probably not the best reviewer, have you ever seen a comment in my code. :) > > Signed-off-by: Frank Rowand > --- > drivers/of/resolver.c | 31

Re: [RFC PATCH 01/13] of: Remove comments that state the obvious

2016-10-25 Thread Joe Perches
On Tue, 2016-10-25 at 13:58 -0700, frowand.l...@gmail.com wrote: > From: Frank Rowand > > Remove comments that state the obvious, to reduce clutter Some of these removals might be overly aggressive. > diff --git a/drivers/of/resolver.c b/drivers/of/resolver.c [] > @@

Re: [RFC PATCH 01/13] of: Remove comments that state the obvious

2016-10-25 Thread Joe Perches
On Tue, 2016-10-25 at 13:58 -0700, frowand.l...@gmail.com wrote: > From: Frank Rowand > > Remove comments that state the obvious, to reduce clutter Some of these removals might be overly aggressive. > diff --git a/drivers/of/resolver.c b/drivers/of/resolver.c [] > @@ -125,7 +114,6 @@ static

[RFC PATCH 01/13] of: Remove comments that state the obvious

2016-10-25 Thread frowand . list
From: Frank Rowand Remove comments that state the obvious, to reduce clutter Signed-off-by: Frank Rowand --- drivers/of/resolver.c | 31 ++- 1 file changed, 2 insertions(+), 29 deletions(-) diff --git

[RFC PATCH 01/13] of: Remove comments that state the obvious

2016-10-25 Thread frowand . list
From: Frank Rowand Remove comments that state the obvious, to reduce clutter Signed-off-by: Frank Rowand --- drivers/of/resolver.c | 31 ++- 1 file changed, 2 insertions(+), 29 deletions(-) diff --git a/drivers/of/resolver.c b/drivers/of/resolver.c index