Re: [RFC PATCH 01/40] soundwire: add debugfs support

2019-07-26 Thread Pierre-Louis Bossart
diff --git a/drivers/soundwire/debugfs.c b/drivers/soundwire/debugfs.c new file mode 100644 index ..8d86e100516e --- /dev/null +++ b/drivers/soundwire/debugfs.c @@ -0,0 +1,156 @@ +// SPDX-License-Identifier: (GPL-2.0 OR BSD-3-Clause) No, for debugfs-specific code, that dual licens

Re: [RFC PATCH 01/40] soundwire: add debugfs support

2019-07-26 Thread Greg KH
On Thu, Jul 25, 2019 at 06:39:53PM -0500, Pierre-Louis Bossart wrote: > Add base debugfs mechanism for SoundWire bus by creating soundwire > root and master-N and slave-x hierarchy. > > Also add SDW Slave SCP, DP0 and DP-N register debug file. > > Registers not implemented will print as "XX" > >

Re: [alsa-devel] [RFC PATCH 01/40] soundwire: add debugfs support

2019-07-26 Thread Pierre-Louis Bossart
Thanks for the feedback Cezary. +static ssize_t sdw_slave_reg_read(struct file *file, char __user *user_buf, +  size_t count, loff_t *ppos) +{ +    struct sdw_slave *slave = file->private_data; +    unsigned int reg; +    char *buf; +    ssize_t ret; +    int i, j; + +    buf =

Re: [alsa-devel] [RFC PATCH 01/40] soundwire: add debugfs support

2019-07-26 Thread Pierre-Louis Bossart
On 7/25/19 5:15 PM, Guennadi Liakhovetski wrote: Hi Pierre, A couple of nitpicks: Thanks for the feedback! create mode 100644 drivers/soundwire/debugfs.c [snip] diff --git a/drivers/soundwire/bus.h b/drivers/soundwire/bus.h index 3048ca153f22..06ac4adb0074 100644 --- a/drivers/sound

Re: [RFC PATCH 01/40] soundwire: add debugfs support

2019-07-26 Thread Cezary Rojewski
On 2019-07-26 01:39, Pierre-Louis Bossart wrote: +static ssize_t sdw_slave_reg_read(struct file *file, char __user *user_buf, + size_t count, loff_t *ppos) +{ + struct sdw_slave *slave = file->private_data; + unsigned int reg; + char *buf; +

Re: [alsa-devel] [RFC PATCH 01/40] soundwire: add debugfs support

2019-07-25 Thread Guennadi Liakhovetski
Hi Pierre, A couple of nitpicks: On Thu, Jul 25, 2019 at 06:39:53PM -0500, Pierre-Louis Bossart wrote: > Add base debugfs mechanism for SoundWire bus by creating soundwire > root and master-N and slave-x hierarchy. > > Also add SDW Slave SCP, DP0 and DP-N register debug file. > > Registers not

[RFC PATCH 01/40] soundwire: add debugfs support

2019-07-25 Thread Pierre-Louis Bossart
Add base debugfs mechanism for SoundWire bus by creating soundwire root and master-N and slave-x hierarchy. Also add SDW Slave SCP, DP0 and DP-N register debug file. Registers not implemented will print as "XX" Credits: this patch is based on an earlier internal contribution by Vinod Koul, Sanyo