Re: [RFC PATCH 02/13] switchtec: export class symbol for use in upper layer driver

2017-06-17 Thread Logan Gunthorpe
On 16/06/17 11:11 PM, Greg Kroah-Hartman wrote: > EXPORT_SYMBOL_GPL()? > > And do you really have to move from a dynamic class to a static one? I > know it will work just the same, but I hate seeing static structures > that have reference counts on them :) I'll change both for v1. I didn't

Re: [RFC PATCH 02/13] switchtec: export class symbol for use in upper layer driver

2017-06-17 Thread Logan Gunthorpe
On 16/06/17 11:11 PM, Greg Kroah-Hartman wrote: > EXPORT_SYMBOL_GPL()? > > And do you really have to move from a dynamic class to a static one? I > know it will work just the same, but I hate seeing static structures > that have reference counts on them :) I'll change both for v1. I didn't

Re: [RFC PATCH 02/13] switchtec: export class symbol for use in upper layer driver

2017-06-16 Thread Greg Kroah-Hartman
On Thu, Jun 15, 2017 at 02:37:18PM -0600, Logan Gunthorpe wrote: > We switch to class_register/unregister and a declared class which > is exported for use in the switchtec_ntb driver. > > Signed-off-by: Logan Gunthorpe > Reviewed-by: Stephen Bates >

Re: [RFC PATCH 02/13] switchtec: export class symbol for use in upper layer driver

2017-06-16 Thread Greg Kroah-Hartman
On Thu, Jun 15, 2017 at 02:37:18PM -0600, Logan Gunthorpe wrote: > We switch to class_register/unregister and a declared class which > is exported for use in the switchtec_ntb driver. > > Signed-off-by: Logan Gunthorpe > Reviewed-by: Stephen Bates > Reviewed-by: Kurt Schwemmer > --- >

[RFC PATCH 02/13] switchtec: export class symbol for use in upper layer driver

2017-06-15 Thread Logan Gunthorpe
We switch to class_register/unregister and a declared class which is exported for use in the switchtec_ntb driver. Signed-off-by: Logan Gunthorpe Reviewed-by: Stephen Bates Reviewed-by: Kurt Schwemmer ---

[RFC PATCH 02/13] switchtec: export class symbol for use in upper layer driver

2017-06-15 Thread Logan Gunthorpe
We switch to class_register/unregister and a declared class which is exported for use in the switchtec_ntb driver. Signed-off-by: Logan Gunthorpe Reviewed-by: Stephen Bates Reviewed-by: Kurt Schwemmer --- drivers/pci/switch/switchtec.c | 21 +++-- include/linux/switchtec.h