Re: [RFC PATCH 06/06] input/rmi4: F11 - 2D touch interface

2012-11-27 Thread Benjamin Tissoires
Hi Christopher, I did not made a full review, but at least, there is a problem in your rmi_f11_finger_handler function: On Sat, Nov 17, 2012 at 4:58 AM, Christopher Heiny wrote: > rmi_f11.c is a driver for 2D touch sensors using the RMI4 protocol. It > supports > both touchscreen and touchpad

Re: [RFC PATCH 06/06] input/rmi4: F11 - 2D touch interface

2012-11-17 Thread Linus Walleij
On Sat, Nov 17, 2012 at 4:58 AM, Christopher Heiny wrote: > rmi_f11.c is a driver for 2D touch sensors using the RMI4 protocol. It > supports > both touchscreen and touchpad input, in both absolute and relative formats. > Support for Type-B multitouch is the default, Type-A support is included

Re: [RFC PATCH 06/06] input/rmi4: F11 - 2D touch interface

2012-10-25 Thread Christopher Heiny
On 10/10/2012 11:21 AM, Henrik Rydberg wrote: Hi Christopher, rmi_f11.c is a driver for 2D touch sensors. It has been updated to support the MT-B specification, partition control attributes between debugfs andsysfs, and to use the standard bus model for loading/unloading. Please find comment

RE: [RFC PATCH 06/06] input/rmi4: F11 - 2D touch interface

2012-10-10 Thread Christopher Heiny
Linus Walleij wrote: > On Sat, Oct 6, 2012 at 6:10 AM, Christopher Heiny > wrote: > > So looking closer at this one since we will use it. Maybe it's in such a > good shape now that I should be able to actually test it with the hardware? Well, it's been possible to test at least since the patch s

Re: [RFC PATCH 06/06] input/rmi4: F11 - 2D touch interface

2012-10-10 Thread Henrik Rydberg
Hi Christopher, > rmi_f11.c is a driver for 2D touch sensors. It has been updated to support > the MT-B specification, partition control attributes between debugfs and > sysfs, > and to use the standard bus model for loading/unloading. Please find comments inline. Generally, if you want this m

Re: [RFC PATCH 06/06] input/rmi4: F11 - 2D touch interface

2012-10-09 Thread Linus Walleij
On Sat, Oct 6, 2012 at 6:10 AM, Christopher Heiny wrote: So looking closer at this one since we will use it. Maybe it's in such a good shape now that I should be able to actually test it with the hardware? (...) > diff --git a/drivers/input/rmi4/rmi_f11.c b/drivers/input/rmi4/rmi_f11.c (...) > +