Re: [alsa-devel] [RFC PATCH 06/40] soundwire: intel: prevent possible dereference in hw_params

2019-08-02 Thread Vinod Koul
On 02-08-19, 11:52, Pierre-Louis Bossart wrote: > > > On 8/2/19 10:57 AM, Vinod Koul wrote: > > On 02-08-19, 10:16, Pierre-Louis Bossart wrote: > > > > > > > > > On 8/2/19 6:55 AM, Vinod Koul wrote: > > > > On 25-07-19, 18:39, Pierre-Louis Bossart wrote: > > > > > This should not happen in

Re: [alsa-devel] [RFC PATCH 06/40] soundwire: intel: prevent possible dereference in hw_params

2019-08-02 Thread Pierre-Louis Bossart
On 8/2/19 10:57 AM, Vinod Koul wrote: On 02-08-19, 10:16, Pierre-Louis Bossart wrote: On 8/2/19 6:55 AM, Vinod Koul wrote: On 25-07-19, 18:39, Pierre-Louis Bossart wrote: This should not happen in production systems but we should test for all callback arguments before invoking the

Re: [alsa-devel] [RFC PATCH 06/40] soundwire: intel: prevent possible dereference in hw_params

2019-08-02 Thread Vinod Koul
On 02-08-19, 10:16, Pierre-Louis Bossart wrote: > > > On 8/2/19 6:55 AM, Vinod Koul wrote: > > On 25-07-19, 18:39, Pierre-Louis Bossart wrote: > > > This should not happen in production systems but we should test for > > > all callback arguments before invoking the config_stream callback. > > >

Re: [alsa-devel] [RFC PATCH 06/40] soundwire: intel: prevent possible dereference in hw_params

2019-08-02 Thread Pierre-Louis Bossart
On 8/2/19 6:55 AM, Vinod Koul wrote: On 25-07-19, 18:39, Pierre-Louis Bossart wrote: This should not happen in production systems but we should test for all callback arguments before invoking the config_stream callback. so you are saying callback arg is mandatory, if so please document

Re: [RFC PATCH 06/40] soundwire: intel: prevent possible dereference in hw_params

2019-08-02 Thread Vinod Koul
On 25-07-19, 18:39, Pierre-Louis Bossart wrote: > This should not happen in production systems but we should test for > all callback arguments before invoking the config_stream callback. so you are saying callback arg is mandatory, if so please document that assumption > Signed-off-by:

Re: [alsa-devel] [RFC PATCH 06/40] soundwire: intel: prevent possible dereference in hw_params

2019-07-26 Thread Pierre-Louis Bossart
diff --git a/drivers/soundwire/intel.c b/drivers/soundwire/intel.c index 68832e613b1e..497879dd9c0d 100644 --- a/drivers/soundwire/intel.c +++ b/drivers/soundwire/intel.c @@ -509,7 +509,7 @@ static int intel_config_stream(struct sdw_intel *sdw, struct snd_soc_dai *dai,

Re: [RFC PATCH 06/40] soundwire: intel: prevent possible dereference in hw_params

2019-07-26 Thread Cezary Rojewski
On 2019-07-26 01:39, Pierre-Louis Bossart wrote: This should not happen in production systems but we should test for all callback arguments before invoking the config_stream callback. Signed-off-by: Pierre-Louis Bossart --- drivers/soundwire/intel.c | 2 +- 1 file changed, 1 insertion(+), 1

[RFC PATCH 06/40] soundwire: intel: prevent possible dereference in hw_params

2019-07-25 Thread Pierre-Louis Bossart
This should not happen in production systems but we should test for all callback arguments before invoking the config_stream callback. Signed-off-by: Pierre-Louis Bossart --- drivers/soundwire/intel.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/soundwire/intel.c