On 03/31/2015 01:47 AM, ira.weiny wrote:
> On Mon, Mar 30, 2015 at 06:20:48PM +0200, Michael Wang wrote:
>> [snip]
Cc: Jason Gunthorpe
Cc: Doug Ledford
Cc: Ira Weiny
Cc: Sean Hefty
Signed-off-by: Michael Wang
---
drivers/infiniband/core/cma.c | 2 +-
>
On Mon, Mar 30, 2015 at 06:20:48PM +0200, Michael Wang wrote:
> On 03/30/2015 06:11 PM, Doug Ledford wrote:
> > On Fri, 2015-03-27 at 16:46 +0100, Michael Wang wrote:
> >> Introduce helper has_mcast() and cap_mcast() to help us check if an
> >> IB device or it's port support Multicast.
> > This pro
On Mon, Mar 30, 2015 at 10:30:36AM +0200, Michael Wang wrote:
> Thus I also agreed check inside mcast_event_handler() is unnecessary,
> maybe we can change that logical to WARN_ON(!cap_mcast()) ?
Seems reasonable to me.
Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-ker
On 03/30/2015 06:11 PM, Doug Ledford wrote:
> On Fri, 2015-03-27 at 16:46 +0100, Michael Wang wrote:
>> Introduce helper has_mcast() and cap_mcast() to help us check if an
>> IB device or it's port support Multicast.
> This probably needs reworded or rethought. In truth, *all* rdma devices
> are m
On Fri, 2015-03-27 at 16:46 +0100, Michael Wang wrote:
> Introduce helper has_mcast() and cap_mcast() to help us check if an
> IB device or it's port support Multicast.
This probably needs reworded or rethought. In truth, *all* rdma devices
are multicast capable. *BUT*, IB/OPA devices require mu
On 03/27/2015 06:47 PM, Jason Gunthorpe wrote:
> On Fri, Mar 27, 2015 at 01:05:08PM -0400, ira.weiny wrote:
>
>>> But it seems redudent, since mcast_add_one will already not add a port that
>>> is
>>> not IB, so mcast_event_handler is not callable. Something to do with
>>> rocee/ib switching?
>>
On Fri, Mar 27, 2015 at 6:49 PM, Jason Gunthorpe
wrote:
> On Fri, Mar 27, 2015 at 06:31:26PM +0100, Yun Wang wrote:
>
>> Maybe we can temporarily reserve the old logical, and gradually solve
>> these problems?
>
> It is best to make behavioral changes in small patches, yes.
>
> I think it is best
On Fri, Mar 27, 2015 at 06:31:26PM +0100, Yun Wang wrote:
> Maybe we can temporarily reserve the old logical, and gradually solve
> these problems?
It is best to make behavioral changes in small patches, yes.
I think it is best to address these sorts of problems before trying to
tackle the drive
On Fri, Mar 27, 2015 at 01:05:08PM -0400, ira.weiny wrote:
> > But it seems redudent, since mcast_add_one will already not add a port that
> > is
> > not IB, so mcast_event_handler is not callable. Something to do with
> > rocee/ib switching?
>
> I'm not sure about this either. This check seems
On Fri, Mar 27, 2015 at 6:05 PM, ira.weiny wrote:
> On Fri, Mar 27, 2015 at 10:28:20AM -0600, Jason Gunthorpe wrote:
>> On Fri, Mar 27, 2015 at 04:46:57PM +0100, Michael Wang wrote:
>> >
[snip]
>> > -if (rdma_transport_is_ib(id_priv->cma_dev->device)) {
>> > +if (has_mcast(
On Fri, Mar 27, 2015 at 10:28:20AM -0600, Jason Gunthorpe wrote:
> On Fri, Mar 27, 2015 at 04:46:57PM +0100, Michael Wang wrote:
> >
> > Introduce helper has_mcast() and cap_mcast() to help us check if an
> > IB device or it's port support Multicast.
> >
> > Cc: Jason Gunthorpe
> > Cc: Doug Ledf
On Fri, Mar 27, 2015 at 04:46:57PM +0100, Michael Wang wrote:
>
> Introduce helper has_mcast() and cap_mcast() to help us check if an
> IB device or it's port support Multicast.
>
> Cc: Jason Gunthorpe
> Cc: Doug Ledford
> Cc: Ira Weiny
> Cc: Sean Hefty
> Signed-off-by: Michael Wang
> drive
Introduce helper has_mcast() and cap_mcast() to help us check if an
IB device or it's port support Multicast.
Cc: Jason Gunthorpe
Cc: Doug Ledford
Cc: Ira Weiny
Cc: Sean Hefty
Signed-off-by: Michael Wang
---
drivers/infiniband/core/cma.c | 2 +-
drivers/infiniband/core/multicast.c |
13 matches
Mail list logo
