Re: [RFC PATCH 08/11] IB/Verbs: Use management helper has_iwarp() for, iwarp-check

2015-03-31 Thread Jason Gunthorpe
On Mon, Mar 30, 2015 at 12:13:00PM -0400, Doug Ledford wrote: > On Fri, 2015-03-27 at 16:47 +0100, Michael Wang wrote: > > Introduce helper has_iwarp() to help us check if an IB device > > support IWARP protocol. > > This is a needless redirection. Just stick with the original >

Re: [RFC PATCH 08/11] IB/Verbs: Use management helper has_iwarp() for, iwarp-check

2015-03-31 Thread Michael Wang
On 03/31/2015 03:42 PM, Tom Talpey wrote: > On 3/31/2015 7:41 AM, Michael Wang wrote: >> [snip] > Yes, in fact the iWARP protocol does not preclude multiple read SGEs, > even though most iWARP implementations have chosen to support just one. > > Even for multi-SGE-capable adapters, there is a

Re: [RFC PATCH 08/11] IB/Verbs: Use management helper has_iwarp() for, iwarp-check

2015-03-31 Thread Tom Talpey
On 3/31/2015 7:41 AM, Michael Wang wrote: Hi, Tom Thanks for the comments :-) On 03/31/2015 01:19 PM, Tom Talpey wrote: [oops - repeating my reply with full cc's] [snip] Actually I'm thinking about Doug's idea to use rdma_transport_is_XX() instead of the current basic helper, thus may

Re: [RFC PATCH 08/11] IB/Verbs: Use management helper has_iwarp() for, iwarp-check

2015-03-31 Thread Michael Wang
Hi, Tom Thanks for the comments :-) On 03/31/2015 01:19 PM, Tom Talpey wrote: > [snip] > >> >> Actually I'm thinking about Doug's idea to use rdma_transport_is_XX() >> instead of the current basic helper, thus may be use >> rdma_transport_is_iwarp() >> in here could be better, since it's

Re: [RFC PATCH 08/11] IB/Verbs: Use management helper has_iwarp() for, iwarp-check

2015-03-31 Thread Tom Talpey
On 3/31/2015 3:39 AM, Michael Wang wrote: On 03/31/2015 12:35 AM, Jason Gunthorpe wrote: On Mon, Mar 30, 2015 at 05:10:12PM +0200, Michael Wang wrote: I found that actually we don't have to touch this one which only used by HW driver currently. I'm having a hard time understanding this, the

Re: [RFC PATCH 08/11] IB/Verbs: Use management helper has_iwarp() for, iwarp-check

2015-03-31 Thread Michael Wang
On 03/31/2015 12:35 AM, Jason Gunthorpe wrote: > On Mon, Mar 30, 2015 at 05:10:12PM +0200, Michael Wang wrote: >> I found that actually we don't have to touch this one which >> only used by HW driver currently. > I'm having a hard time understanding this, the code in question was in > >

Re: [RFC PATCH 08/11] IB/Verbs: Use management helper has_iwarp() for, iwarp-check

2015-03-31 Thread Michael Wang
On 03/31/2015 12:35 AM, Jason Gunthorpe wrote: On Mon, Mar 30, 2015 at 05:10:12PM +0200, Michael Wang wrote: I found that actually we don't have to touch this one which only used by HW driver currently. I'm having a hard time understanding this, the code in question was in

Re: [RFC PATCH 08/11] IB/Verbs: Use management helper has_iwarp() for, iwarp-check

2015-03-31 Thread Tom Talpey
On 3/31/2015 3:39 AM, Michael Wang wrote: On 03/31/2015 12:35 AM, Jason Gunthorpe wrote: On Mon, Mar 30, 2015 at 05:10:12PM +0200, Michael Wang wrote: I found that actually we don't have to touch this one which only used by HW driver currently. I'm having a hard time understanding this, the

Re: [RFC PATCH 08/11] IB/Verbs: Use management helper has_iwarp() for, iwarp-check

2015-03-31 Thread Michael Wang
Hi, Tom Thanks for the comments :-) On 03/31/2015 01:19 PM, Tom Talpey wrote: [snip] Actually I'm thinking about Doug's idea to use rdma_transport_is_XX() instead of the current basic helper, thus may be use rdma_transport_is_iwarp() in here could be better, since it's actually a feature

Re: [RFC PATCH 08/11] IB/Verbs: Use management helper has_iwarp() for, iwarp-check

2015-03-31 Thread Tom Talpey
On 3/31/2015 7:41 AM, Michael Wang wrote: Hi, Tom Thanks for the comments :-) On 03/31/2015 01:19 PM, Tom Talpey wrote: [oops - repeating my reply with full cc's] [snip] Actually I'm thinking about Doug's idea to use rdma_transport_is_XX() instead of the current basic helper, thus may

Re: [RFC PATCH 08/11] IB/Verbs: Use management helper has_iwarp() for, iwarp-check

2015-03-31 Thread Michael Wang
On 03/31/2015 03:42 PM, Tom Talpey wrote: On 3/31/2015 7:41 AM, Michael Wang wrote: [snip] Yes, in fact the iWARP protocol does not preclude multiple read SGEs, even though most iWARP implementations have chosen to support just one. Even for multi-SGE-capable adapters, there is a limit of

Re: [RFC PATCH 08/11] IB/Verbs: Use management helper has_iwarp() for, iwarp-check

2015-03-31 Thread Jason Gunthorpe
On Mon, Mar 30, 2015 at 12:13:00PM -0400, Doug Ledford wrote: On Fri, 2015-03-27 at 16:47 +0100, Michael Wang wrote: Introduce helper has_iwarp() to help us check if an IB device support IWARP protocol. This is a needless redirection. Just stick with the original

Re: [RFC PATCH 08/11] IB/Verbs: Use management helper has_iwarp() for, iwarp-check

2015-03-30 Thread Jason Gunthorpe
On Mon, Mar 30, 2015 at 05:10:12PM +0200, Michael Wang wrote: > I found that actually we don't have to touch this one which > only used by HW driver currently. I'm having a hard time understanding this, the code in question was in net/sunrpc/xprtrdma/svc_rdma_recvfrom.c Which is the NFS ULP,

Re: [RFC PATCH 08/11] IB/Verbs: Use management helper has_iwarp() for, iwarp-check

2015-03-30 Thread Michael Wang
On 03/30/2015 06:13 PM, Doug Ledford wrote: > On Fri, 2015-03-27 at 16:47 +0100, Michael Wang wrote: >> Introduce helper has_iwarp() to help us check if an IB device >> support IWARP protocol. > This is a needless redirection. Just stick with the original > rdma_transport_is_iwarp(). Agree, will

Re: [RFC PATCH 08/11] IB/Verbs: Use management helper has_iwarp() for, iwarp-check

2015-03-30 Thread Doug Ledford
On Fri, 2015-03-27 at 16:47 +0100, Michael Wang wrote: > Introduce helper has_iwarp() to help us check if an IB device > support IWARP protocol. This is a needless redirection. Just stick with the original rdma_transport_is_iwarp(). > Cc: Jason Gunthorpe > Cc: Doug Ledford > Cc: Ira Weiny >

Re: [RFC PATCH 08/11] IB/Verbs: Use management helper has_iwarp() for, iwarp-check

2015-03-30 Thread Michael Wang
On 03/27/2015 06:29 PM, Jason Gunthorpe wrote: > On Fri, Mar 27, 2015 at 01:16:31PM -0400, ira.weiny wrote: >> [snip] > http://www.spinics.net/lists/linux-rdma/msg22565.html > > ''Unlike IB, the iWARP protocol only allows 1 target/sink SGE in an > rdma read'' > > It is one of those annoying verbs

Re: [RFC PATCH 08/11] IB/Verbs: Use management helper has_iwarp() for, iwarp-check

2015-03-30 Thread Michael Wang
On 03/27/2015 06:29 PM, Jason Gunthorpe wrote: On Fri, Mar 27, 2015 at 01:16:31PM -0400, ira.weiny wrote: [snip] http://www.spinics.net/lists/linux-rdma/msg22565.html ''Unlike IB, the iWARP protocol only allows 1 target/sink SGE in an rdma read'' It is one of those annoying verbs is

Re: [RFC PATCH 08/11] IB/Verbs: Use management helper has_iwarp() for, iwarp-check

2015-03-30 Thread Michael Wang
On 03/30/2015 06:13 PM, Doug Ledford wrote: On Fri, 2015-03-27 at 16:47 +0100, Michael Wang wrote: Introduce helper has_iwarp() to help us check if an IB device support IWARP protocol. This is a needless redirection. Just stick with the original rdma_transport_is_iwarp(). Agree, will leave

Re: [RFC PATCH 08/11] IB/Verbs: Use management helper has_iwarp() for, iwarp-check

2015-03-30 Thread Jason Gunthorpe
On Mon, Mar 30, 2015 at 05:10:12PM +0200, Michael Wang wrote: I found that actually we don't have to touch this one which only used by HW driver currently. I'm having a hard time understanding this, the code in question was in net/sunrpc/xprtrdma/svc_rdma_recvfrom.c Which is the NFS ULP, not

Re: [RFC PATCH 08/11] IB/Verbs: Use management helper has_iwarp() for, iwarp-check

2015-03-30 Thread Doug Ledford
On Fri, 2015-03-27 at 16:47 +0100, Michael Wang wrote: Introduce helper has_iwarp() to help us check if an IB device support IWARP protocol. This is a needless redirection. Just stick with the original rdma_transport_is_iwarp(). Cc: Jason Gunthorpe jguntho...@obsidianresearch.com Cc: Doug

Re: [RFC PATCH 08/11] IB/Verbs: Use management helper has_iwarp() for, iwarp-check

2015-03-27 Thread Yun Wang
On Fri, Mar 27, 2015 at 6:16 PM, ira.weiny wrote: > On Fri, Mar 27, 2015 at 10:13:19AM -0600, Jason Gunthorpe wrote: >> On Fri, Mar 27, 2015 at 04:47:36PM +0100, Michael Wang wrote: >> > >> > Introduce helper has_iwarp() to help us check if an IB device >> > support IWARP protocol. >> >> Should

Re: [RFC PATCH 08/11] IB/Verbs: Use management helper has_iwarp() for, iwarp-check

2015-03-27 Thread Jason Gunthorpe
On Fri, Mar 27, 2015 at 01:16:31PM -0400, ira.weiny wrote: > On Fri, Mar 27, 2015 at 10:13:19AM -0600, Jason Gunthorpe wrote: > > On Fri, Mar 27, 2015 at 04:47:36PM +0100, Michael Wang wrote: > > > > > > Introduce helper has_iwarp() to help us check if an IB device > > > support IWARP protocol. >

Re: [RFC PATCH 08/11] IB/Verbs: Use management helper has_iwarp() for, iwarp-check

2015-03-27 Thread ira.weiny
On Fri, Mar 27, 2015 at 10:13:19AM -0600, Jason Gunthorpe wrote: > On Fri, Mar 27, 2015 at 04:47:36PM +0100, Michael Wang wrote: > > > > Introduce helper has_iwarp() to help us check if an IB device > > support IWARP protocol. > > Should probably be !has_rdma_read_sges() > > True if the device

Re: [RFC PATCH 08/11] IB/Verbs: Use management helper has_iwarp() for, iwarp-check

2015-03-27 Thread Michael Wang
On 03/27/2015 05:13 PM, Jason Gunthorpe wrote: > On Fri, Mar 27, 2015 at 04:47:36PM +0100, Michael Wang wrote: >> Introduce helper has_iwarp() to help us check if an IB device >> support IWARP protocol. > Should probably be !has_rdma_read_sges() > > True if the device can handle more than one SGE

Re: [RFC PATCH 08/11] IB/Verbs: Use management helper has_iwarp() for, iwarp-check

2015-03-27 Thread Jason Gunthorpe
On Fri, Mar 27, 2015 at 04:47:36PM +0100, Michael Wang wrote: > > Introduce helper has_iwarp() to help us check if an IB device > support IWARP protocol. Should probably be !has_rdma_read_sges() True if the device can handle more than one SGE entry on a RDMA READ work request. Jason -- To

[RFC PATCH 08/11] IB/Verbs: Use management helper has_iwarp() for, iwarp-check

2015-03-27 Thread Michael Wang
Introduce helper has_iwarp() to help us check if an IB device support IWARP protocol. Cc: Jason Gunthorpe Cc: Doug Ledford Cc: Ira Weiny Cc: Sean Hefty Signed-off-by: Michael Wang --- include/rdma/ib_verbs.h | 13 + net/sunrpc/xprtrdma/svc_rdma_recvfrom.c | 2

Re: [RFC PATCH 08/11] IB/Verbs: Use management helper has_iwarp() for, iwarp-check

2015-03-27 Thread Jason Gunthorpe
On Fri, Mar 27, 2015 at 01:16:31PM -0400, ira.weiny wrote: On Fri, Mar 27, 2015 at 10:13:19AM -0600, Jason Gunthorpe wrote: On Fri, Mar 27, 2015 at 04:47:36PM +0100, Michael Wang wrote: Introduce helper has_iwarp() to help us check if an IB device support IWARP protocol. Should

Re: [RFC PATCH 08/11] IB/Verbs: Use management helper has_iwarp() for, iwarp-check

2015-03-27 Thread Yun Wang
On Fri, Mar 27, 2015 at 6:16 PM, ira.weiny ira.we...@intel.com wrote: On Fri, Mar 27, 2015 at 10:13:19AM -0600, Jason Gunthorpe wrote: On Fri, Mar 27, 2015 at 04:47:36PM +0100, Michael Wang wrote: Introduce helper has_iwarp() to help us check if an IB device support IWARP protocol.

[RFC PATCH 08/11] IB/Verbs: Use management helper has_iwarp() for, iwarp-check

2015-03-27 Thread Michael Wang
Introduce helper has_iwarp() to help us check if an IB device support IWARP protocol. Cc: Jason Gunthorpe jguntho...@obsidianresearch.com Cc: Doug Ledford dledf...@redhat.com Cc: Ira Weiny ira.we...@intel.com Cc: Sean Hefty sean.he...@intel.com Signed-off-by: Michael Wang

Re: [RFC PATCH 08/11] IB/Verbs: Use management helper has_iwarp() for, iwarp-check

2015-03-27 Thread ira.weiny
On Fri, Mar 27, 2015 at 10:13:19AM -0600, Jason Gunthorpe wrote: On Fri, Mar 27, 2015 at 04:47:36PM +0100, Michael Wang wrote: Introduce helper has_iwarp() to help us check if an IB device support IWARP protocol. Should probably be !has_rdma_read_sges() True if the device can handle

Re: [RFC PATCH 08/11] IB/Verbs: Use management helper has_iwarp() for, iwarp-check

2015-03-27 Thread Michael Wang
On 03/27/2015 05:13 PM, Jason Gunthorpe wrote: On Fri, Mar 27, 2015 at 04:47:36PM +0100, Michael Wang wrote: Introduce helper has_iwarp() to help us check if an IB device support IWARP protocol. Should probably be !has_rdma_read_sges() True if the device can handle more than one SGE entry on

Re: [RFC PATCH 08/11] IB/Verbs: Use management helper has_iwarp() for, iwarp-check

2015-03-27 Thread Jason Gunthorpe
On Fri, Mar 27, 2015 at 04:47:36PM +0100, Michael Wang wrote: Introduce helper has_iwarp() to help us check if an IB device support IWARP protocol. Should probably be !has_rdma_read_sges() True if the device can handle more than one SGE entry on a RDMA READ work request. Jason -- To