Re: [RFC PATCH 08/12] nfs: convert lock handling to use file_lock_context

2014-09-10 Thread J. Bruce Fields
On Wed, Sep 10, 2014 at 03:28:10PM -0400, Jeff Layton wrote: > Yes, that's the downside of moving to multiple list_heads. Still, I > think it's worth doing that even if we end up with the code a bit more > verbose. > > It may be best to consider moving some of this into helpers that live > in lock

Re: [RFC PATCH 08/12] nfs: convert lock handling to use file_lock_context

2014-09-10 Thread Jeff Layton
On Wed, 10 Sep 2014 15:17:34 -0400 "J. Bruce Fields" wrote: > On Wed, Sep 10, 2014 at 10:28:46AM -0400, Jeff Layton wrote: > > Signed-off-by: Jeff Layton > > --- > > fs/nfs/delegation.c | 37 + > > fs/nfs/nfs4state.c | 24 +++- > > fs/nfs

Re: [RFC PATCH 08/12] nfs: convert lock handling to use file_lock_context

2014-09-10 Thread Al Viro
On Wed, Sep 10, 2014 at 03:17:34PM -0400, J. Bruce Fields wrote: > On Wed, Sep 10, 2014 at 10:28:46AM -0400, Jeff Layton wrote: > > Signed-off-by: Jeff Layton > > --- > > fs/nfs/delegation.c | 37 + > > fs/nfs/nfs4state.c | 24 +++- > > fs/

Re: [RFC PATCH 08/12] nfs: convert lock handling to use file_lock_context

2014-09-10 Thread J. Bruce Fields
On Wed, Sep 10, 2014 at 10:28:46AM -0400, Jeff Layton wrote: > Signed-off-by: Jeff Layton > --- > fs/nfs/delegation.c | 37 + > fs/nfs/nfs4state.c | 24 +++- > fs/nfs/pagelist.c | 3 ++- > fs/nfs/write.c | 39 +++

[RFC PATCH 08/12] nfs: convert lock handling to use file_lock_context

2014-09-10 Thread Jeff Layton
Signed-off-by: Jeff Layton --- fs/nfs/delegation.c | 37 + fs/nfs/nfs4state.c | 24 +++- fs/nfs/pagelist.c | 3 ++- fs/nfs/write.c | 39 +-- 4 files changed, 71 insertions(+), 32 deletions(-) dif