Re: [RFC PATCH 08/35] KVM: SVM: Prevent debugging under SEV-ES

2020-09-17 Thread Tom Lendacky
On 9/16/20 5:50 PM, Sean Christopherson wrote: On Wed, Sep 16, 2020 at 03:27:13PM -0500, Tom Lendacky wrote: On 9/16/20 11:49 AM, Sean Christopherson wrote: On Wed, Sep 16, 2020 at 11:38:38AM -0500, Tom Lendacky wrote: On 9/16/20 11:02 AM, Sean Christopherson wrote: On Wed, Sep 16, 2020 at

Re: [RFC PATCH 08/35] KVM: SVM: Prevent debugging under SEV-ES

2020-09-16 Thread Sean Christopherson
On Wed, Sep 16, 2020 at 03:27:13PM -0500, Tom Lendacky wrote: > On 9/16/20 11:49 AM, Sean Christopherson wrote: > > On Wed, Sep 16, 2020 at 11:38:38AM -0500, Tom Lendacky wrote: > >> > >> > >> On 9/16/20 11:02 AM, Sean Christopherson wrote: > >>> On Wed, Sep 16, 2020 at 10:11:10AM -0500, Tom Lendac

Re: [RFC PATCH 08/35] KVM: SVM: Prevent debugging under SEV-ES

2020-09-16 Thread Sean Christopherson
On Wed, Sep 16, 2020 at 11:38:38AM -0500, Tom Lendacky wrote: > > > On 9/16/20 11:02 AM, Sean Christopherson wrote: > > On Wed, Sep 16, 2020 at 10:11:10AM -0500, Tom Lendacky wrote: > >> On 9/15/20 3:13 PM, Tom Lendacky wrote: > >>> On 9/15/20 11:30 AM, Sean Christopherson wrote: > I don't q

Re: [RFC PATCH 08/35] KVM: SVM: Prevent debugging under SEV-ES

2020-09-16 Thread Tom Lendacky
On 9/15/20 3:13 PM, Tom Lendacky wrote: > On 9/15/20 11:30 AM, Sean Christopherson wrote: >> On Tue, Sep 15, 2020 at 08:37:12AM -0500, Tom Lendacky wrote: >>> On 9/14/20 4:26 PM, Sean Christopherson wrote: On Mon, Sep 14, 2020 at 03:15:22PM -0500, Tom Lendacky wrote: > From: Tom Lendacky

Re: [RFC PATCH 08/35] KVM: SVM: Prevent debugging under SEV-ES

2020-09-16 Thread Tom Lendacky
On 9/16/20 11:49 AM, Sean Christopherson wrote: > On Wed, Sep 16, 2020 at 11:38:38AM -0500, Tom Lendacky wrote: >> >> >> On 9/16/20 11:02 AM, Sean Christopherson wrote: >>> On Wed, Sep 16, 2020 at 10:11:10AM -0500, Tom Lendacky wrote: On 9/15/20 3:13 PM, Tom Lendacky wrote: > On 9/15/20 11

Re: [RFC PATCH 08/35] KVM: SVM: Prevent debugging under SEV-ES

2020-09-16 Thread Sean Christopherson
On Wed, Sep 16, 2020 at 10:11:10AM -0500, Tom Lendacky wrote: > On 9/15/20 3:13 PM, Tom Lendacky wrote: > > On 9/15/20 11:30 AM, Sean Christopherson wrote: > >> I don't quite follow the "doesn't mean debugging can't be done in the > >> future". > >> Does that imply that debugging could be supporte

Re: [RFC PATCH 08/35] KVM: SVM: Prevent debugging under SEV-ES

2020-09-16 Thread Tom Lendacky
On 9/16/20 11:02 AM, Sean Christopherson wrote: > On Wed, Sep 16, 2020 at 10:11:10AM -0500, Tom Lendacky wrote: >> On 9/15/20 3:13 PM, Tom Lendacky wrote: >>> On 9/15/20 11:30 AM, Sean Christopherson wrote: I don't quite follow the "doesn't mean debugging can't be done in the future".

Re: [RFC PATCH 08/35] KVM: SVM: Prevent debugging under SEV-ES

2020-09-15 Thread Tom Lendacky
On 9/15/20 11:30 AM, Sean Christopherson wrote: > On Tue, Sep 15, 2020 at 08:37:12AM -0500, Tom Lendacky wrote: >> On 9/14/20 4:26 PM, Sean Christopherson wrote: >>> On Mon, Sep 14, 2020 at 03:15:22PM -0500, Tom Lendacky wrote: From: Tom Lendacky Since the guest register state of an

Re: [RFC PATCH 08/35] KVM: SVM: Prevent debugging under SEV-ES

2020-09-15 Thread Sean Christopherson
On Tue, Sep 15, 2020 at 08:37:12AM -0500, Tom Lendacky wrote: > On 9/14/20 4:26 PM, Sean Christopherson wrote: > > On Mon, Sep 14, 2020 at 03:15:22PM -0500, Tom Lendacky wrote: > >> From: Tom Lendacky > >> > >> Since the guest register state of an SEV-ES guest is encrypted, debugging > >> is not s

Re: [RFC PATCH 08/35] KVM: SVM: Prevent debugging under SEV-ES

2020-09-15 Thread Tom Lendacky
On 9/14/20 4:26 PM, Sean Christopherson wrote: > On Mon, Sep 14, 2020 at 03:15:22PM -0500, Tom Lendacky wrote: >> From: Tom Lendacky >> >> Since the guest register state of an SEV-ES guest is encrypted, debugging >> is not supported. Update the code to prevent guest debugging when the >> guest is

Re: [RFC PATCH 08/35] KVM: SVM: Prevent debugging under SEV-ES

2020-09-14 Thread Sean Christopherson
On Mon, Sep 14, 2020 at 03:15:22PM -0500, Tom Lendacky wrote: > From: Tom Lendacky > > Since the guest register state of an SEV-ES guest is encrypted, debugging > is not supported. Update the code to prevent guest debugging when the > guest is an SEV-ES guest. This includes adding a callable func

[RFC PATCH 08/35] KVM: SVM: Prevent debugging under SEV-ES

2020-09-14 Thread Tom Lendacky
From: Tom Lendacky Since the guest register state of an SEV-ES guest is encrypted, debugging is not supported. Update the code to prevent guest debugging when the guest is an SEV-ES guest. This includes adding a callable function that is used to determine if the guest supports being debugged. Si