Re: [RFC PATCH 09/14] cxl/mem: Add basic IOCTL interface

2020-12-14 Thread Ben Widawsky
On 20-12-09 19:32:19, Randy Dunlap wrote: > On 12/8/20 4:24 PM, Ben Widawsky wrote: > > + > > +#define CXL_MEM_QUERY_COMMANDS _IOR('C', 1, struct cxl_mem_query_commands) > > Hi, > I could have missed it, but IOCTL major "numbers" (like 'C') should be > listed in Documentation/userspace-api/ioctl/i

Re: [RFC PATCH 09/14] cxl/mem: Add basic IOCTL interface

2020-12-09 Thread Randy Dunlap
On 12/8/20 4:24 PM, Ben Widawsky wrote: > + > +#define CXL_MEM_QUERY_COMMANDS _IOR('C', 1, struct cxl_mem_query_commands) Hi, I could have missed it, but IOCTL major "numbers" (like 'C') should be listed in Documentation/userspace-api/ioctl/ioctl-number.rst. thanks. -- ~Randy

Re: [RFC PATCH 09/14] cxl/mem: Add basic IOCTL interface

2020-12-09 Thread Ben Widawsky
On 20-12-08 19:33:13, Dan Williams wrote: > On Tue, Dec 8, 2020 at 6:13 PM Ben Widawsky wrote: > > > > On 20-12-08 17:37:50, Dan Williams wrote: > > > On Tue, Dec 8, 2020 at 4:24 PM Ben Widawsky > > > wrote: > > > > > > > > Add a straightforward IOCTL that provides a mechanism for userspace to >

Re: [RFC PATCH 09/14] cxl/mem: Add basic IOCTL interface

2020-12-08 Thread Dan Williams
On Tue, Dec 8, 2020 at 6:13 PM Ben Widawsky wrote: > > On 20-12-08 17:37:50, Dan Williams wrote: > > On Tue, Dec 8, 2020 at 4:24 PM Ben Widawsky wrote: > > > > > > Add a straightforward IOCTL that provides a mechanism for userspace to > > > query the supported memory device commands. > > > > > >

Re: [RFC PATCH 09/14] cxl/mem: Add basic IOCTL interface

2020-12-08 Thread Ben Widawsky
On 20-12-08 17:37:50, Dan Williams wrote: > On Tue, Dec 8, 2020 at 4:24 PM Ben Widawsky wrote: > > > > Add a straightforward IOCTL that provides a mechanism for userspace to > > query the supported memory device commands. > > > > Memory device commands are specified in 8.2.9 of the CXL 2.0 > > spe

Re: [RFC PATCH 09/14] cxl/mem: Add basic IOCTL interface

2020-12-08 Thread Dan Williams
On Tue, Dec 8, 2020 at 4:24 PM Ben Widawsky wrote: > > Add a straightforward IOCTL that provides a mechanism for userspace to > query the supported memory device commands. > > Memory device commands are specified in 8.2.9 of the CXL 2.0 > specification. They are submitted through a mailbox mechani

[RFC PATCH 09/14] cxl/mem: Add basic IOCTL interface

2020-12-08 Thread Ben Widawsky
Add a straightforward IOCTL that provides a mechanism for userspace to query the supported memory device commands. Memory device commands are specified in 8.2.9 of the CXL 2.0 specification. They are submitted through a mailbox mechanism specified in 8.2.8.4. Signed-off-by: Ben Widawsky --- I