Re: [RFC PATCH 09/35] ovl: stack file ops

2018-04-26 Thread Miklos Szeredi
On Thu, Apr 26, 2018 at 5:13 PM, Vivek Goyal wrote: > Aha, cool. thanks. While I am at it, let me just ask one more stupid > question. > > I am wondering while opening the underlying realfile, why do we pass > in the path/dentry of ovl layer (and not underlying real layer). > > realfile =

Re: [RFC PATCH 09/35] ovl: stack file ops

2018-04-26 Thread Vivek Goyal
On Thu, Apr 26, 2018 at 05:01:37PM +0200, Miklos Szeredi wrote: > On Thu, Apr 26, 2018 at 4:56 PM, Vivek Goyal wrote: > > On Thu, Apr 26, 2018 at 04:43:53PM +0200, Miklos Szeredi wrote: > >> On Thu, Apr 26, 2018 at 4:13 PM, Vivek Goyal wrote: > >> > On Thu, Apr 12, 2018 at 05:08:00PM +0200, Miklo

Re: [RFC PATCH 09/35] ovl: stack file ops

2018-04-26 Thread Miklos Szeredi
On Thu, Apr 26, 2018 at 4:56 PM, Vivek Goyal wrote: > On Thu, Apr 26, 2018 at 04:43:53PM +0200, Miklos Szeredi wrote: >> On Thu, Apr 26, 2018 at 4:13 PM, Vivek Goyal wrote: >> > On Thu, Apr 12, 2018 at 05:08:00PM +0200, Miklos Szeredi wrote: >> > >> > [..] >> >> diff --git a/fs/overlayfs/file.c b

Re: [RFC PATCH 09/35] ovl: stack file ops

2018-04-26 Thread Vivek Goyal
On Thu, Apr 26, 2018 at 04:43:53PM +0200, Miklos Szeredi wrote: > On Thu, Apr 26, 2018 at 4:13 PM, Vivek Goyal wrote: > > On Thu, Apr 12, 2018 at 05:08:00PM +0200, Miklos Szeredi wrote: > > > > [..] > >> diff --git a/fs/overlayfs/file.c b/fs/overlayfs/file.c > >> new file mode 100644 > >> index 00

Re: [RFC PATCH 09/35] ovl: stack file ops

2018-04-26 Thread Miklos Szeredi
On Thu, Apr 26, 2018 at 4:13 PM, Vivek Goyal wrote: > On Thu, Apr 12, 2018 at 05:08:00PM +0200, Miklos Szeredi wrote: > > [..] >> diff --git a/fs/overlayfs/file.c b/fs/overlayfs/file.c >> new file mode 100644 >> index ..a0b606885c41 >> --- /dev/null >> +++ b/fs/overlayfs/file.c >> @@ -

Re: [RFC PATCH 09/35] ovl: stack file ops

2018-04-26 Thread Vivek Goyal
On Thu, Apr 12, 2018 at 05:08:00PM +0200, Miklos Szeredi wrote: [..] > diff --git a/fs/overlayfs/file.c b/fs/overlayfs/file.c > new file mode 100644 > index ..a0b606885c41 > --- /dev/null > +++ b/fs/overlayfs/file.c > @@ -0,0 +1,76 @@ > +/* > + * Copyright (C) 2017 Red Hat, Inc. > + *

[RFC PATCH 09/35] ovl: stack file ops

2018-04-12 Thread Miklos Szeredi
Implement file operations on a regular overlay file. The underlying file is opened separately and cached in ->private_data. It might be worth making an exception for such files when accounting in nr_file to confirm to userspace expectations. We are only adding a small overhead (248bytes for the