Re: [RFC PATCH 1/3] PCI: rockchip: Add support for pcie wake irq

2017-08-17 Thread jeffy
Hi Brian, i've tried dev_pm_set_dedicated_wake_irq, it doesn't work well on upstream kernel(for level irq). it looks like we would delay real set trigger type to request irq after this commit: 1e2a7d78499e irqdomain: Don't set type when mapping an IRQ so calling irq_set_status_flags before

Re: [RFC PATCH 1/3] PCI: rockchip: Add support for pcie wake irq

2017-08-16 Thread jeffy
hi shawn, On 08/16/2017 05:00 PM, Shawn Lin wrote: Hi Jeffy, On 2017/8/16 15:52, Jeffy Chen wrote: Add support for PCIE_WAKE pin in rockchip pcie driver. Signed-off-by: Jeffy Chen --- drivers/pci/host/pcie-rockchip.c | 58 1 file changed, 58 inse

Re: [RFC PATCH 1/3] PCI: rockchip: Add support for pcie wake irq

2017-08-16 Thread Brian Norris
Hi, On Wed, Aug 16, 2017 at 03:52:22PM +0800, Jeffy Chen wrote: > Add support for PCIE_WAKE pin in rockchip pcie driver. > > Signed-off-by: Jeffy Chen > --- > > drivers/pci/host/pcie-rockchip.c | 58 > > 1 file changed, 58 insertions(+) > > diff --git

Re: [RFC PATCH 1/3] PCI: rockchip: Add support for pcie wake irq

2017-08-16 Thread Shawn Lin
Hi Jeffy, On 2017/8/16 15:52, Jeffy Chen wrote: Add support for PCIE_WAKE pin in rockchip pcie driver. Signed-off-by: Jeffy Chen --- drivers/pci/host/pcie-rockchip.c | 58 1 file changed, 58 insertions(+) diff --git a/drivers/pci/host/pcie-rockchip

[RFC PATCH 1/3] PCI: rockchip: Add support for pcie wake irq

2017-08-16 Thread Jeffy Chen
Add support for PCIE_WAKE pin in rockchip pcie driver. Signed-off-by: Jeffy Chen --- drivers/pci/host/pcie-rockchip.c | 58 1 file changed, 58 insertions(+) diff --git a/drivers/pci/host/pcie-rockchip.c b/drivers/pci/host/pcie-rockchip.c index 7bb9870f6