Re: [RFC PATCH 1/3] hugetlb: use page.private for hugetlb specific page flags

2021-01-13 Thread Mike Kravetz
On 1/13/21 6:45 AM, Matthew Wilcox wrote: > On Mon, Jan 11, 2021 at 01:01:50PM -0800, Mike Kravetz wrote: >> +if (hpage_spool(page)) { > > Could this be named hpage_subpool(), please? > Of course! -- Mike Kravetz

Re: [RFC PATCH 1/3] hugetlb: use page.private for hugetlb specific page flags

2021-01-13 Thread Mike Kravetz
On 1/13/21 5:54 AM, Oscar Salvador wrote: > On Mon, Jan 11, 2021 at 01:01:50PM -0800, Mike Kravetz wrote: >> As hugetlbfs evolved, state information about hugetlb pages was added. >> One 'convenient' way of doing this was to use available fields in tail >> pages. Over time, it has become

Re: [RFC PATCH 1/3] hugetlb: use page.private for hugetlb specific page flags

2021-01-13 Thread Matthew Wilcox
On Mon, Jan 11, 2021 at 01:01:50PM -0800, Mike Kravetz wrote: > + if (hpage_spool(page)) { Could this be named hpage_subpool(), please?

Re: [RFC PATCH 1/3] hugetlb: use page.private for hugetlb specific page flags

2021-01-13 Thread Oscar Salvador
On Mon, Jan 11, 2021 at 01:01:50PM -0800, Mike Kravetz wrote: > As hugetlbfs evolved, state information about hugetlb pages was added. > One 'convenient' way of doing this was to use available fields in tail > pages. Over time, it has become difficult to know the meaning or contents > of fields

Re: [External] [RFC PATCH 1/3] hugetlb: use page.private for hugetlb specific page flags

2021-01-11 Thread Muchun Song
On Tue, Jan 12, 2021 at 5:04 AM Mike Kravetz wrote: > > As hugetlbfs evolved, state information about hugetlb pages was added. > One 'convenient' way of doing this was to use available fields in tail > pages. Over time, it has become difficult to know the meaning or contents > of fields simply

[RFC PATCH 1/3] hugetlb: use page.private for hugetlb specific page flags

2021-01-11 Thread Mike Kravetz
As hugetlbfs evolved, state information about hugetlb pages was added. One 'convenient' way of doing this was to use available fields in tail pages. Over time, it has become difficult to know the meaning or contents of fields simply be looking at a small bit of code. Sometimes, the naming is