Re: [RFC PATCH 1/3] mm: Drop locked from isolate_migratepages_block

2020-08-14 Thread Alex Shi
在 2020/8/13 下午10:32, Alexander Duyck 写道: >> Thanks a lot! >> Don't know if community is ok if we keep the patch following whole patchset >> alone? > I am fine with you squashing it with another patch if you want. In > theory this could probably be squashed in with the earlier patch I > submitte

Re: [RFC PATCH 1/3] mm: Drop locked from isolate_migratepages_block

2020-08-13 Thread Alexander Duyck
On Wed, Aug 12, 2020 at 11:57 PM Alex Shi wrote: > > > > 在 2020/8/13 下午12:02, Alexander Duyck 写道: > > From: Alexander Duyck > > > > We can drop the need for the locked variable by making use of the > > lruvec_holds_page_lru_lock function. By doing this we can avoid some rcu > > locking ugliness f

Re: [RFC PATCH 1/3] mm: Drop locked from isolate_migratepages_block

2020-08-13 Thread Alexander Duyck
On Thu, Aug 13, 2020 at 12:45 AM Alex Shi wrote: > > > > 在 2020/8/13 下午12:02, Alexander Duyck 写道: > > - rcu_read_lock(); > > - lruvec = mem_cgroup_page_lruvec(page, pgdat); > > - > > /* If we already hold the lock, we can skip some rechecking */ > > -

Re: [RFC PATCH 1/3] mm: Drop locked from isolate_migratepages_block

2020-08-13 Thread Alex Shi
在 2020/8/13 下午12:02, Alexander Duyck 写道: > - rcu_read_lock(); > - lruvec = mem_cgroup_page_lruvec(page, pgdat); > - > /* If we already hold the lock, we can skip some rechecking */ > - if (lruvec != locked) { > - if (locked) >

Re: [RFC PATCH 1/3] mm: Drop locked from isolate_migratepages_block

2020-08-12 Thread Alex Shi
在 2020/8/13 下午12:02, Alexander Duyck 写道: > From: Alexander Duyck > > We can drop the need for the locked variable by making use of the > lruvec_holds_page_lru_lock function. By doing this we can avoid some rcu > locking ugliness for the case where the lruvec is still holding the LRU > lock ass

[RFC PATCH 1/3] mm: Drop locked from isolate_migratepages_block

2020-08-12 Thread Alexander Duyck
From: Alexander Duyck We can drop the need for the locked variable by making use of the lruvec_holds_page_lru_lock function. By doing this we can avoid some rcu locking ugliness for the case where the lruvec is still holding the LRU lock associated with the page. Instead we can just use the lruve