Re: [RFC PATCH 1/3] opp: Reduce code duplication in _set_required_opps()

2020-08-24 Thread Stephan Gerhold
On Mon, Aug 24, 2020 at 05:40:04PM +0530, Viresh Kumar wrote: > On 24-08-20, 13:30, Stephan Gerhold wrote: > > You're right. Not sure why I removed it. > > > > I suspect I had it in _set_required_opp() at some point, but I moved > > code around several times until I was happy with the result. > >

Re: [RFC PATCH 1/3] opp: Reduce code duplication in _set_required_opps()

2020-08-24 Thread Viresh Kumar
On 24-08-20, 13:30, Stephan Gerhold wrote: > You're right. Not sure why I removed it. > > I suspect I had it in _set_required_opp() at some point, but I moved > code around several times until I was happy with the result. > > We should just add it back. > Should I send a v2 with it fixed or

Re: [RFC PATCH 1/3] opp: Reduce code duplication in _set_required_opps()

2020-08-24 Thread Stephan Gerhold
On Mon, Aug 24, 2020 at 04:48:20PM +0530, Viresh Kumar wrote: > On 30-07-20, 10:01, Stephan Gerhold wrote: > > Move call to dev_pm_genpd_set_performance_state() to a separate > > function so we can avoid duplicating the code for the single and > > multiple genpd case. > > > > Signed-off-by:

Re: [RFC PATCH 1/3] opp: Reduce code duplication in _set_required_opps()

2020-08-24 Thread Viresh Kumar
On 30-07-20, 10:01, Stephan Gerhold wrote: > Move call to dev_pm_genpd_set_performance_state() to a separate > function so we can avoid duplicating the code for the single and > multiple genpd case. > > Signed-off-by: Stephan Gerhold > --- > drivers/opp/core.c | 40

[RFC PATCH 1/3] opp: Reduce code duplication in _set_required_opps()

2020-07-30 Thread Stephan Gerhold
Move call to dev_pm_genpd_set_performance_state() to a separate function so we can avoid duplicating the code for the single and multiple genpd case. Signed-off-by: Stephan Gerhold --- drivers/opp/core.c | 40 +--- 1 file changed, 21 insertions(+), 19