Re: [RFC PATCH 1/4] RAS: Add a Corrected Errors Collector

2016-06-07 Thread Borislav Petkov
On Tue, Jun 07, 2016 at 11:11:09AM -0700, Luck, Tony wrote: > Is there a reason that we need to call the ce_add_elem() inline > here instead of having it just register on the mce_notifier chain? > This series just cleaned out all the /dev/mcelog special code from > here, and you are adding

Re: [RFC PATCH 1/4] RAS: Add a Corrected Errors Collector

2016-06-07 Thread Borislav Petkov
On Tue, Jun 07, 2016 at 11:11:09AM -0700, Luck, Tony wrote: > Is there a reason that we need to call the ce_add_elem() inline > here instead of having it just register on the mce_notifier chain? > This series just cleaned out all the /dev/mcelog special code from > here, and you are adding

Re: [RFC PATCH 1/4] RAS: Add a Corrected Errors Collector

2016-06-07 Thread Luck, Tony
On Tue, Jun 07, 2016 at 06:52:22PM +0200, Borislav Petkov wrote: > +void mce_log(struct mce *m) > { > unsigned next, entry; > > + if (!in_atomic() && memory_error(m) && mce_usable_address(m)) > + if (!ce_add_elem(m->addr >> PAGE_SHIFT)) > + return; > +

Re: [RFC PATCH 1/4] RAS: Add a Corrected Errors Collector

2016-06-07 Thread Luck, Tony
On Tue, Jun 07, 2016 at 06:52:22PM +0200, Borislav Petkov wrote: > +void mce_log(struct mce *m) > { > unsigned next, entry; > > + if (!in_atomic() && memory_error(m) && mce_usable_address(m)) > + if (!ce_add_elem(m->addr >> PAGE_SHIFT)) > + return; > +

[RFC PATCH 1/4] RAS: Add a Corrected Errors Collector

2016-06-07 Thread Borislav Petkov
From: Borislav Petkov A simple data structure for collecting correctable errors along with accessors. More detailed description in the code itself. Signed-off-by: Borislav Petkov --- arch/x86/kernel/cpu/mcheck/mce.c | 120 +-- arch/x86/ras/Kconfig

[RFC PATCH 1/4] RAS: Add a Corrected Errors Collector

2016-06-07 Thread Borislav Petkov
From: Borislav Petkov A simple data structure for collecting correctable errors along with accessors. More detailed description in the code itself. Signed-off-by: Borislav Petkov --- arch/x86/kernel/cpu/mcheck/mce.c | 120 +-- arch/x86/ras/Kconfig | 11 +