Re: [RFC PATCH 1/4] watchdog: hpwdt: Don't disable watchdog on NMI

2019-02-14 Thread Ivan Mironov
On Thu, 2019-02-07 at 18:26 -0700, Jerry Hoemann wrote: > The name is not the best given its current use, but I'm not sure a > name change would be allowed. > > However, I will send a patch to update the documentation in Kconfig. > > Thanks!

Re: [RFC PATCH 1/4] watchdog: hpwdt: Don't disable watchdog on NMI

2019-02-07 Thread Guenter Roeck
On 2/7/19 5:26 PM, Jerry Hoemann wrote: On Sat, Feb 02, 2019 at 09:55:29AM +0500, Ivan Mironov wrote: On Tue, 2019-01-15 at 19:27 -0700, Jerry Hoemann wrote: On Mon, Jan 14, 2019 at 07:36:14AM +0500, Ivan Mironov wrote: Somehow I missed the whole pretimout thing when reading about the

Re: [RFC PATCH 1/4] watchdog: hpwdt: Don't disable watchdog on NMI

2019-02-07 Thread Jerry Hoemann
On Sat, Feb 02, 2019 at 09:55:29AM +0500, Ivan Mironov wrote: > On Tue, 2019-01-15 at 19:27 -0700, Jerry Hoemann wrote: > > On Mon, Jan 14, 2019 at 07:36:14AM +0500, Ivan Mironov wrote: > > Somehow I missed the whole pretimout thing when reading about the > watchdog API. Thanks for clarification,

Re: [RFC PATCH 1/4] watchdog: hpwdt: Don't disable watchdog on NMI

2019-02-01 Thread Ivan Mironov
On Tue, 2019-01-15 at 19:27 -0700, Jerry Hoemann wrote: > On Mon, Jan 14, 2019 at 07:36:14AM +0500, Ivan Mironov wrote: > > Existing code disables watchdog on NMI right before completely hanging > > the system. > > > > There are two problems here: > > > > * First, watchdog is expected to reset

Re: [RFC PATCH 1/4] watchdog: hpwdt: Don't disable watchdog on NMI

2019-01-16 Thread Jerry Hoemann
On Mon, Jan 14, 2019 at 07:36:14AM +0500, Ivan Mironov wrote: > Existing code disables watchdog on NMI right before completely hanging > the system. > > There are two problems here: > > * First, watchdog is expected to reset the system in a case of such >failure, no matter what.

Re: [RFC PATCH 1/4] watchdog: hpwdt: Don't disable watchdog on NMI

2019-01-15 Thread Guenter Roeck
On 1/15/19 6:27 PM, Jerry Hoemann wrote: On Mon, Jan 14, 2019 at 07:36:14AM +0500, Ivan Mironov wrote: Existing code disables watchdog on NMI right before completely hanging the system. There are two problems here: * First, watchdog is expected to reset the system in a case of such

[RFC PATCH 1/4] watchdog: hpwdt: Don't disable watchdog on NMI

2019-01-13 Thread Ivan Mironov
Existing code disables watchdog on NMI right before completely hanging the system. There are two problems here: * First, watchdog is expected to reset the system in a case of such failure, no matter what. * Second, this code has no effect if there are more than one watchdog. Signed-off-by: