Re: [RFC PATCH 1/4] zbud: use page ref counter for zbud pages

2013-09-10 Thread Krzysztof Kozlowski
Hi, On pon, 2013-09-09 at 14:47 -0500, Seth Jennings wrote: > On Fri, Aug 30, 2013 at 10:42:53AM +0200, Krzysztof Kozlowski wrote: > > Use page reference counter for zbud pages. The ref counter replaces > > zbud_header.under_reclaim flag and ensures that zbud page won't be freed > > when

Re: [RFC PATCH 1/4] zbud: use page ref counter for zbud pages

2013-09-10 Thread Krzysztof Kozlowski
Hi, On pon, 2013-09-09 at 14:47 -0500, Seth Jennings wrote: On Fri, Aug 30, 2013 at 10:42:53AM +0200, Krzysztof Kozlowski wrote: Use page reference counter for zbud pages. The ref counter replaces zbud_header.under_reclaim flag and ensures that zbud page won't be freed when zbud_free() is

Re: [RFC PATCH 1/4] zbud: use page ref counter for zbud pages

2013-09-09 Thread Seth Jennings
On Fri, Aug 30, 2013 at 10:42:53AM +0200, Krzysztof Kozlowski wrote: > Use page reference counter for zbud pages. The ref counter replaces > zbud_header.under_reclaim flag and ensures that zbud page won't be freed > when zbud_free() is called during reclaim. It allows implementation of >

Re: [RFC PATCH 1/4] zbud: use page ref counter for zbud pages

2013-09-09 Thread Krzysztof Kozlowski
Hi Bob, On nie, 2013-09-08 at 17:04 +0800, Bob Liu wrote: > Hi Krzysztof, > > On 08/30/2013 04:42 PM, Krzysztof Kozlowski wrote: > > Use page reference counter for zbud pages. The ref counter replaces > > zbud_header.under_reclaim flag and ensures that zbud page won't be freed > > when

Re: [RFC PATCH 1/4] zbud: use page ref counter for zbud pages

2013-09-09 Thread Seth Jennings
On Fri, Aug 30, 2013 at 10:42:53AM +0200, Krzysztof Kozlowski wrote: Use page reference counter for zbud pages. The ref counter replaces zbud_header.under_reclaim flag and ensures that zbud page won't be freed when zbud_free() is called during reclaim. It allows implementation of additional

Re: [RFC PATCH 1/4] zbud: use page ref counter for zbud pages

2013-09-09 Thread Krzysztof Kozlowski
Hi Bob, On nie, 2013-09-08 at 17:04 +0800, Bob Liu wrote: Hi Krzysztof, On 08/30/2013 04:42 PM, Krzysztof Kozlowski wrote: Use page reference counter for zbud pages. The ref counter replaces zbud_header.under_reclaim flag and ensures that zbud page won't be freed when zbud_free() is

Re: [RFC PATCH 1/4] zbud: use page ref counter for zbud pages

2013-09-08 Thread Bob Liu
Hi Krzysztof, On 08/30/2013 04:42 PM, Krzysztof Kozlowski wrote: > Use page reference counter for zbud pages. The ref counter replaces > zbud_header.under_reclaim flag and ensures that zbud page won't be freed > when zbud_free() is called during reclaim. It allows implementation of > additional

Re: [RFC PATCH 1/4] zbud: use page ref counter for zbud pages

2013-09-08 Thread Bob Liu
Hi Krzysztof, On 08/30/2013 04:42 PM, Krzysztof Kozlowski wrote: Use page reference counter for zbud pages. The ref counter replaces zbud_header.under_reclaim flag and ensures that zbud page won't be freed when zbud_free() is called during reclaim. It allows implementation of additional

[RFC PATCH 1/4] zbud: use page ref counter for zbud pages

2013-08-30 Thread Krzysztof Kozlowski
Use page reference counter for zbud pages. The ref counter replaces zbud_header.under_reclaim flag and ensures that zbud page won't be freed when zbud_free() is called during reclaim. It allows implementation of additional reclaim paths. The page count is incremented when: - a handle is created

[RFC PATCH 1/4] zbud: use page ref counter for zbud pages

2013-08-30 Thread Krzysztof Kozlowski
Use page reference counter for zbud pages. The ref counter replaces zbud_header.under_reclaim flag and ensures that zbud page won't be freed when zbud_free() is called during reclaim. It allows implementation of additional reclaim paths. The page count is incremented when: - a handle is created

Re: [RFC PATCH 1/4] zbud: use page ref counter for zbud pages

2013-08-07 Thread Krzysztof Kozlowski
Hi Seth, On wto, 2013-08-06 at 13:51 -0500, Seth Jennings wrote: > I like the idea. I few things below. Also agree with Bob the > s/rebalance/adjust/ for rebalance_lists(). OK. > s/else if/if/ since the if above returns if true. Sure. > > + /* zbud_free() or zbud_alloc() */ > > +

Re: [RFC PATCH 1/4] zbud: use page ref counter for zbud pages

2013-08-07 Thread Krzysztof Kozlowski
Hi Seth, On wto, 2013-08-06 at 13:51 -0500, Seth Jennings wrote: I like the idea. I few things below. Also agree with Bob the s/rebalance/adjust/ for rebalance_lists(). OK. s/else if/if/ since the if above returns if true. Sure. + /* zbud_free() or zbud_alloc() */ +

Re: [RFC PATCH 1/4] zbud: use page ref counter for zbud pages

2013-08-06 Thread Krzysztof Kozlowski
Hi Bob, Thank you for review. On wto, 2013-08-06 at 17:00 +0800, Bob Liu wrote: > Nit picker, how about change the name to adjust_lists() or something > like this because we don't do any rebalancing. OK, I'll change it. Best regards, Krzysztof -- To unsubscribe from this list: send the line

Re: [RFC PATCH 1/4] zbud: use page ref counter for zbud pages

2013-08-06 Thread Bob Liu
Hi Krzysztof, On 08/06/2013 02:42 PM, Krzysztof Kozlowski wrote: > Use page reference counter for zbud pages. The ref counter replaces > zbud_header.under_reclaim flag and ensures that zbud page won't be freed > when zbud_free() is called during reclaim. It allows implementation of > additional

[RFC PATCH 1/4] zbud: use page ref counter for zbud pages

2013-08-06 Thread Krzysztof Kozlowski
Use page reference counter for zbud pages. The ref counter replaces zbud_header.under_reclaim flag and ensures that zbud page won't be freed when zbud_free() is called during reclaim. It allows implementation of additional reclaim paths. The page count is incremented when: - a handle is created

[RFC PATCH 1/4] zbud: use page ref counter for zbud pages

2013-08-06 Thread Krzysztof Kozlowski
Use page reference counter for zbud pages. The ref counter replaces zbud_header.under_reclaim flag and ensures that zbud page won't be freed when zbud_free() is called during reclaim. It allows implementation of additional reclaim paths. The page count is incremented when: - a handle is created

Re: [RFC PATCH 1/4] zbud: use page ref counter for zbud pages

2013-08-06 Thread Bob Liu
Hi Krzysztof, On 08/06/2013 02:42 PM, Krzysztof Kozlowski wrote: Use page reference counter for zbud pages. The ref counter replaces zbud_header.under_reclaim flag and ensures that zbud page won't be freed when zbud_free() is called during reclaim. It allows implementation of additional

Re: [RFC PATCH 1/4] zbud: use page ref counter for zbud pages

2013-08-06 Thread Krzysztof Kozlowski
Hi Bob, Thank you for review. On wto, 2013-08-06 at 17:00 +0800, Bob Liu wrote: Nit picker, how about change the name to adjust_lists() or something like this because we don't do any rebalancing. OK, I'll change it. Best regards, Krzysztof -- To unsubscribe from this list: send the line