Re: [RFC PATCH 1/5] livepatch: Fix kobject memleak

2019-05-02 Thread Petr Mladek
On Thu 2019-05-02 12:31:38, Tobin C. Harding wrote: > Currently error return from kobject_init_and_add() is not followed by a > call to kobject_put(). This means there is a memory leak. Strictly speaking there is no real memory leak in this case because the structures are either static and or

Re: [RFC PATCH 1/5] livepatch: Fix kobject memleak

2019-05-02 Thread Greg Kroah-Hartman
On Thu, May 02, 2019 at 12:31:38PM +1000, Tobin C. Harding wrote: > Currently error return from kobject_init_and_add() is not followed by a > call to kobject_put(). This means there is a memory leak. > > Add call to kobject_put() in error path of kobject_init_and_add(). > > Signed-off-by: Tobin

[RFC PATCH 1/5] livepatch: Fix kobject memleak

2019-05-01 Thread Tobin C. Harding
Currently error return from kobject_init_and_add() is not followed by a call to kobject_put(). This means there is a memory leak. Add call to kobject_put() in error path of kobject_init_and_add(). Signed-off-by: Tobin C. Harding --- kernel/livepatch/core.c | 12 +--- 1 file changed, 9