Re: [alsa-devel] [RFC PATCH 1/6] ASoC: Intel: Skylake: Add CFL-S support

2018-11-23 Thread Pierre-Louis Bossart
On 11/22/18 3:56 AM, Andy Shevchenko wrote: On Wed, Nov 21, 2018 at 11:17:41PM +0100, Takashi Iwai wrote: On Wed, 21 Nov 2018 18:38:41 +0100, Andy Shevchenko wrote: Compare: /* CFL */ { PCI_DEVICE(0x8086, 0xa348), .driver_data = (unsigned

Re: [alsa-devel] [RFC PATCH 1/6] ASoC: Intel: Skylake: Add CFL-S support

2018-11-23 Thread Pierre-Louis Bossart
On 11/22/18 3:56 AM, Andy Shevchenko wrote: On Wed, Nov 21, 2018 at 11:17:41PM +0100, Takashi Iwai wrote: On Wed, 21 Nov 2018 18:38:41 +0100, Andy Shevchenko wrote: Compare: /* CFL */ { PCI_DEVICE(0x8086, 0xa348), .driver_data = (unsigned

Re: [RFC PATCH 1/6] ASoC: Intel: Skylake: Add CFL-S support

2018-11-22 Thread Andy Shevchenko
On Wed, Nov 21, 2018 at 11:17:41PM +0100, Takashi Iwai wrote: > On Wed, 21 Nov 2018 18:38:41 +0100, Andy Shevchenko wrote: > > Compare: > > > > /* CFL */ > > { PCI_DEVICE(0x8086, 0xa348), > > .driver_data = (unsigned long)_soc_acpi_intel_cnl_machines}, > > > > to something

Re: [RFC PATCH 1/6] ASoC: Intel: Skylake: Add CFL-S support

2018-11-22 Thread Andy Shevchenko
On Wed, Nov 21, 2018 at 11:17:41PM +0100, Takashi Iwai wrote: > On Wed, 21 Nov 2018 18:38:41 +0100, Andy Shevchenko wrote: > > Compare: > > > > /* CFL */ > > { PCI_DEVICE(0x8086, 0xa348), > > .driver_data = (unsigned long)_soc_acpi_intel_cnl_machines}, > > > > to something

Re: [RFC PATCH 1/6] ASoC: Intel: Skylake: Add CFL-S support

2018-11-21 Thread Takashi Iwai
On Wed, 21 Nov 2018 18:38:41 +0100, Andy Shevchenko wrote: > > On Wed, Nov 21, 2018 at 11:16:50AM -0600, Pierre-Louis Bossart wrote: > > On 11/21/18 8:27 AM, Andy Shevchenko wrote: > > > > May you consider to switch to PCI_DEVICE_DATA() first? > > > > Is this really the recommended path? > > >

Re: [RFC PATCH 1/6] ASoC: Intel: Skylake: Add CFL-S support

2018-11-21 Thread Takashi Iwai
On Wed, 21 Nov 2018 18:38:41 +0100, Andy Shevchenko wrote: > > On Wed, Nov 21, 2018 at 11:16:50AM -0600, Pierre-Louis Bossart wrote: > > On 11/21/18 8:27 AM, Andy Shevchenko wrote: > > > > May you consider to switch to PCI_DEVICE_DATA() first? > > > > Is this really the recommended path? > > >

Re: [RFC PATCH 1/6] ASoC: Intel: Skylake: Add CFL-S support

2018-11-21 Thread Andy Shevchenko
On Wed, Nov 21, 2018 at 11:16:50AM -0600, Pierre-Louis Bossart wrote: > On 11/21/18 8:27 AM, Andy Shevchenko wrote: > > May you consider to switch to PCI_DEVICE_DATA() first? > > Is this really the recommended path? > > The macro generates PCI_DEVICE_ID_##vend##_##dev, and I don't have a turn >

Re: [RFC PATCH 1/6] ASoC: Intel: Skylake: Add CFL-S support

2018-11-21 Thread Andy Shevchenko
On Wed, Nov 21, 2018 at 11:16:50AM -0600, Pierre-Louis Bossart wrote: > On 11/21/18 8:27 AM, Andy Shevchenko wrote: > > May you consider to switch to PCI_DEVICE_DATA() first? > > Is this really the recommended path? > > The macro generates PCI_DEVICE_ID_##vend##_##dev, and I don't have a turn >

Re: [RFC PATCH 1/6] ASoC: Intel: Skylake: Add CFL-S support

2018-11-21 Thread Pierre-Louis Bossart
On 11/21/18 8:27 AM, Andy Shevchenko wrote: On Tue, Nov 20, 2018 at 03:36:39PM -0600, Pierre-Louis Bossart wrote: From: Takashi Iwai It's with CNP, supposed to be equivalent with CNL entry. May you consider to switch to PCI_DEVICE_DATA() first? Is this really the recommended path? The

Re: [RFC PATCH 1/6] ASoC: Intel: Skylake: Add CFL-S support

2018-11-21 Thread Pierre-Louis Bossart
On 11/21/18 8:27 AM, Andy Shevchenko wrote: On Tue, Nov 20, 2018 at 03:36:39PM -0600, Pierre-Louis Bossart wrote: From: Takashi Iwai It's with CNP, supposed to be equivalent with CNL entry. May you consider to switch to PCI_DEVICE_DATA() first? Is this really the recommended path? The

Re: [RFC PATCH 1/6] ASoC: Intel: Skylake: Add CFL-S support

2018-11-21 Thread Andy Shevchenko
On Tue, Nov 20, 2018 at 03:36:39PM -0600, Pierre-Louis Bossart wrote: > From: Takashi Iwai > > It's with CNP, supposed to be equivalent with CNL entry. > May you consider to switch to PCI_DEVICE_DATA() first? > Signed-off-by: Takashi Iwai > Signed-off-by: Pierre-Louis Bossart > --- >

Re: [RFC PATCH 1/6] ASoC: Intel: Skylake: Add CFL-S support

2018-11-21 Thread Andy Shevchenko
On Tue, Nov 20, 2018 at 03:36:39PM -0600, Pierre-Louis Bossart wrote: > From: Takashi Iwai > > It's with CNP, supposed to be equivalent with CNL entry. > May you consider to switch to PCI_DEVICE_DATA() first? > Signed-off-by: Takashi Iwai > Signed-off-by: Pierre-Louis Bossart > --- >

[RFC PATCH 1/6] ASoC: Intel: Skylake: Add CFL-S support

2018-11-20 Thread Pierre-Louis Bossart
From: Takashi Iwai It's with CNP, supposed to be equivalent with CNL entry. Signed-off-by: Takashi Iwai Signed-off-by: Pierre-Louis Bossart --- sound/soc/intel/skylake/skl-messages.c | 8 sound/soc/intel/skylake/skl.c | 3 +++ 2 files changed, 11 insertions(+) diff --git

[RFC PATCH 1/6] ASoC: Intel: Skylake: Add CFL-S support

2018-11-20 Thread Pierre-Louis Bossart
From: Takashi Iwai It's with CNP, supposed to be equivalent with CNL entry. Signed-off-by: Takashi Iwai Signed-off-by: Pierre-Louis Bossart --- sound/soc/intel/skylake/skl-messages.c | 8 sound/soc/intel/skylake/skl.c | 3 +++ 2 files changed, 11 insertions(+) diff --git