Re: [RFC PATCH 1/7] ALSA: ac97: split out the generic ac97 registers

2016-05-06 Thread Mark Brown
On Thu, May 05, 2016 at 09:46:10PM +0200, Robert Jarzmik wrote: > Mark Brown writes: > > On Thu, May 05, 2016 at 09:06:44PM +0200, Robert Jarzmik wrote: > >> Mark Brown writes: > >> This transition will be easier if the new ac97 code is isolated as much

Re: [RFC PATCH 1/7] ALSA: ac97: split out the generic ac97 registers

2016-05-06 Thread Mark Brown
On Thu, May 05, 2016 at 09:46:10PM +0200, Robert Jarzmik wrote: > Mark Brown writes: > > On Thu, May 05, 2016 at 09:06:44PM +0200, Robert Jarzmik wrote: > >> Mark Brown writes: > >> This transition will be easier if the new ac97 code is isolated as much as > >> possible from the former code

Re: [RFC PATCH 1/7] ALSA: ac97: split out the generic ac97 registers

2016-05-05 Thread Robert Jarzmik
Mark Brown writes: > On Thu, May 05, 2016 at 09:06:44PM +0200, Robert Jarzmik wrote: >> Mark Brown writes: > >> > I see that, I just don't know why that helps. >> In order to have a clean split between former ac97 bus implementation and >> this >> new

Re: [RFC PATCH 1/7] ALSA: ac97: split out the generic ac97 registers

2016-05-05 Thread Robert Jarzmik
Mark Brown writes: > On Thu, May 05, 2016 at 09:06:44PM +0200, Robert Jarzmik wrote: >> Mark Brown writes: > >> > I see that, I just don't know why that helps. >> In order to have a clean split between former ac97 bus implementation and >> this >> new one, I didn't want to include any former

Re: [RFC PATCH 1/7] ALSA: ac97: split out the generic ac97 registers

2016-05-05 Thread Mark Brown
On Thu, May 05, 2016 at 09:06:44PM +0200, Robert Jarzmik wrote: > Mark Brown writes: > > I see that, I just don't know why that helps. > Ok, so let me explain. > As you already understood, AC97_VENDOR* is needed in bus.c for the > autoscanning. The remaining is the reason

Re: [RFC PATCH 1/7] ALSA: ac97: split out the generic ac97 registers

2016-05-05 Thread Mark Brown
On Thu, May 05, 2016 at 09:06:44PM +0200, Robert Jarzmik wrote: > Mark Brown writes: > > I see that, I just don't know why that helps. > Ok, so let me explain. > As you already understood, AC97_VENDOR* is needed in bus.c for the > autoscanning. The remaining is the reason why I don't want to

Re: [RFC PATCH 1/7] ALSA: ac97: split out the generic ac97 registers

2016-05-05 Thread Robert Jarzmik
Mark Brown writes: > On Tue, May 03, 2016 at 09:22:05PM +0200, Robert Jarzmik wrote: >> Mark Brown writes: > >> > On Sat, Apr 30, 2016 at 11:15:33PM +0200, Robert Jarzmik wrote: > >> >> Split out from the ac97_codec.h the ac97 generic registers, which can

Re: [RFC PATCH 1/7] ALSA: ac97: split out the generic ac97 registers

2016-05-05 Thread Robert Jarzmik
Mark Brown writes: > On Tue, May 03, 2016 at 09:22:05PM +0200, Robert Jarzmik wrote: >> Mark Brown writes: > >> > On Sat, Apr 30, 2016 at 11:15:33PM +0200, Robert Jarzmik wrote: > >> >> Split out from the ac97_codec.h the ac97 generic registers, which can be >> >> used by a codec, typically a

Re: [RFC PATCH 1/7] ALSA: ac97: split out the generic ac97 registers

2016-05-04 Thread Mark Brown
On Tue, May 03, 2016 at 09:22:05PM +0200, Robert Jarzmik wrote: > Mark Brown writes: > > On Sat, Apr 30, 2016 at 11:15:33PM +0200, Robert Jarzmik wrote: > >> Split out from the ac97_codec.h the ac97 generic registers, which can be > >> used by a codec, typically a generic

Re: [RFC PATCH 1/7] ALSA: ac97: split out the generic ac97 registers

2016-05-04 Thread Mark Brown
On Tue, May 03, 2016 at 09:22:05PM +0200, Robert Jarzmik wrote: > Mark Brown writes: > > On Sat, Apr 30, 2016 at 11:15:33PM +0200, Robert Jarzmik wrote: > >> Split out from the ac97_codec.h the ac97 generic registers, which can be > >> used by a codec, typically a generic ac97 codec, and by the

Re: [RFC PATCH 1/7] ALSA: ac97: split out the generic ac97 registers

2016-05-03 Thread Robert Jarzmik
Mark Brown writes: > On Sat, Apr 30, 2016 at 11:15:33PM +0200, Robert Jarzmik wrote: >> Split out from the ac97_codec.h the ac97 generic registers, which can be >> used by a codec, typically a generic ac97 codec, and by the ac97 bus, to >> scan an ac97 AC-Link. > > I don't

Re: [RFC PATCH 1/7] ALSA: ac97: split out the generic ac97 registers

2016-05-03 Thread Robert Jarzmik
Mark Brown writes: > On Sat, Apr 30, 2016 at 11:15:33PM +0200, Robert Jarzmik wrote: >> Split out from the ac97_codec.h the ac97 generic registers, which can be >> used by a codec, typically a generic ac97 codec, and by the ac97 bus, to >> scan an ac97 AC-Link. > > I don't entirely see the value

Re: [RFC PATCH 1/7] ALSA: ac97: split out the generic ac97 registers

2016-05-03 Thread Mark Brown
On Sat, Apr 30, 2016 at 11:15:33PM +0200, Robert Jarzmik wrote: > Split out from the ac97_codec.h the ac97 generic registers, which can be > used by a codec, typically a generic ac97 codec, and by the ac97 bus, to > scan an ac97 AC-Link. I don't entirely see the value in this one but equally it

Re: [RFC PATCH 1/7] ALSA: ac97: split out the generic ac97 registers

2016-05-03 Thread Mark Brown
On Sat, Apr 30, 2016 at 11:15:33PM +0200, Robert Jarzmik wrote: > Split out from the ac97_codec.h the ac97 generic registers, which can be > used by a codec, typically a generic ac97 codec, and by the ac97 bus, to > scan an ac97 AC-Link. I don't entirely see the value in this one but equally it

[RFC PATCH 1/7] ALSA: ac97: split out the generic ac97 registers

2016-04-30 Thread Robert Jarzmik
Split out from the ac97_codec.h the ac97 generic registers, which can be used by a codec, typically a generic ac97 codec, and by the ac97 bus, to scan an ac97 AC-Link. Signed-off-by: Robert Jarzmik --- include/sound/ac97/regs.h | 262

[RFC PATCH 1/7] ALSA: ac97: split out the generic ac97 registers

2016-04-30 Thread Robert Jarzmik
Split out from the ac97_codec.h the ac97 generic registers, which can be used by a codec, typically a generic ac97 codec, and by the ac97 bus, to scan an ac97 AC-Link. Signed-off-by: Robert Jarzmik --- include/sound/ac97/regs.h | 262 +