Re: [RFC PATCH 11/13] led: bd71828: Support LED outputs on ROHM BD71828 PMIC

2019-10-23 Thread Vaittinen, Matti
Morning Jacek, Thanks for the reply again. I did some cleaning to this mail as it was getting lengthy. On Tue, 2019-10-22 at 19:40 +0200, Jacek Anaszewski wrote: > Matti, > > On 10/22/19 2:40 PM, Vaittinen, Matti wrote: > > Hello Jacek, > > > > Thanks for the clarifications. I think I now

Re: [RFC PATCH 11/13] led: bd71828: Support LED outputs on ROHM BD71828 PMIC

2019-10-22 Thread Jacek Anaszewski
Matti, On 10/22/19 2:40 PM, Vaittinen, Matti wrote: > Hello Jacek, > > Thanks for the clarifications. I think I now understand the LED > subsystem a bit better :) > > On Mon, 2019-10-21 at 21:09 +0200, Jacek Anaszewski wrote: >> Hi Matti, >> >> On 10/21/19 10:00 AM, Vaittinen, Matti wrote: >>>

Re: [RFC PATCH 11/13] led: bd71828: Support LED outputs on ROHM BD71828 PMIC

2019-10-22 Thread Vaittinen, Matti
Hello Jacek, Thanks for the clarifications. I think I now understand the LED subsystem a bit better :) On Mon, 2019-10-21 at 21:09 +0200, Jacek Anaszewski wrote: > Hi Matti, > > On 10/21/19 10:00 AM, Vaittinen, Matti wrote: > > Hello Dan, > > > > Thanks for taking the time to check my driver

Re: [RFC PATCH 11/13] led: bd71828: Support LED outputs on ROHM BD71828 PMIC

2019-10-21 Thread Jacek Anaszewski
Hi Matti, On 10/21/19 10:00 AM, Vaittinen, Matti wrote: > Hello Dan, > > Thanks for taking the time to check my driver :) I truly appreciate all > the help! > > A "fundamental question" regarding these review comments is whether I > should add DT entries for these LEDs or not. I thought I

Re: [RFC PATCH 11/13] led: bd71828: Support LED outputs on ROHM BD71828 PMIC

2019-10-21 Thread Vaittinen, Matti
Hello Dan, Thanks for taking the time to check my driver :) I truly appreciate all the help! A "fundamental question" regarding these review comments is whether I should add DT entries for these LEDs or not. I thought I shouldn't but I would like to get a comment from Rob regarding it. On Thu,

Re: [RFC PATCH 11/13] led: bd71828: Support LED outputs on ROHM BD71828 PMIC

2019-10-17 Thread Alexandre Belloni
On 17/10/2019 09:04:48-0500, Dan Murphy wrote: > Matt > > On 10/17/19 4:53 AM, Matti Vaittinen wrote: > > ROHM BD71828 power management IC has two LED outputs for charge status > > and button pressing indications. The LED outputs can also be forced > > bs SW so add driver allowing to use these

Re: [RFC PATCH 11/13] led: bd71828: Support LED outputs on ROHM BD71828 PMIC

2019-10-17 Thread Dan Murphy
Matt On 10/17/19 4:53 AM, Matti Vaittinen wrote: ROHM BD71828 power management IC has two LED outputs for charge status and button pressing indications. The LED outputs can also be forced bs SW so add driver allowing to use these LEDs for other indications s/bs/by as well. Leds are

[RFC PATCH 11/13] led: bd71828: Support LED outputs on ROHM BD71828 PMIC

2019-10-17 Thread Matti Vaittinen
ROHM BD71828 power management IC has two LED outputs for charge status and button pressing indications. The LED outputs can also be forced bs SW so add driver allowing to use these LEDs for other indications as well. Leds are controlled by SW using 'Force ON' bits. Please note the constrains