Re: [RFC PATCH 12/13] fs/userfaultfd: kmem-cache for wait-queue objects

2020-11-30 Thread Nadav Amit
> On Nov 28, 2020, at 4:45 PM, Nadav Amit wrote: > > From: Nadav Amit > > Allocating work-queue objects on the stack has usually negative > performance side-effects. First, it is hard to ensure alignment to > cache-lines without increasing the stack size. Second, it might cause > false sharing.

[RFC PATCH 12/13] fs/userfaultfd: kmem-cache for wait-queue objects

2020-11-28 Thread Nadav Amit
From: Nadav Amit Allocating work-queue objects on the stack has usually negative performance side-effects. First, it is hard to ensure alignment to cache-lines without increasing the stack size. Second, it might cause false sharing. Third, it is more likely to encounter TLB misses as objects are