Re: [RFC PATCH 2/2] clk: qcom: Add qspi (Quad SPI) clocks for sdm845

2018-07-19 Thread Doug Anderson
Hi, On Thu, Jul 19, 2018 at 12:02 PM, Taniya Das wrote: > > > On 7/19/2018 11:25 PM, Doug Anderson wrote: >> >> Hi, >> >> On Thu, Jul 19, 2018 at 4:04 AM, Taniya Das wrote: >>> >>> Hi Doug, >>> >>> Please find my comments inline. >>> >>> On 7/18/2018 11:34 PM, Douglas Anderson wrote:

Re: [RFC PATCH 2/2] clk: qcom: Add qspi (Quad SPI) clocks for sdm845

2018-07-19 Thread Doug Anderson
Hi, On Thu, Jul 19, 2018 at 12:02 PM, Taniya Das wrote: > > > On 7/19/2018 11:25 PM, Doug Anderson wrote: >> >> Hi, >> >> On Thu, Jul 19, 2018 at 4:04 AM, Taniya Das wrote: >>> >>> Hi Doug, >>> >>> Please find my comments inline. >>> >>> On 7/18/2018 11:34 PM, Douglas Anderson wrote:

Re: [RFC PATCH 2/2] clk: qcom: Add qspi (Quad SPI) clocks for sdm845

2018-07-19 Thread Taniya Das
On 7/19/2018 11:25 PM, Doug Anderson wrote: Hi, On Thu, Jul 19, 2018 at 4:04 AM, Taniya Das wrote: Hi Doug, Please find my comments inline. On 7/18/2018 11:34 PM, Douglas Anderson wrote: Add both the interface and core clock. Signed-off-by: Douglas Anderson ---

Re: [RFC PATCH 2/2] clk: qcom: Add qspi (Quad SPI) clocks for sdm845

2018-07-19 Thread Taniya Das
On 7/19/2018 11:25 PM, Doug Anderson wrote: Hi, On Thu, Jul 19, 2018 at 4:04 AM, Taniya Das wrote: Hi Doug, Please find my comments inline. On 7/18/2018 11:34 PM, Douglas Anderson wrote: Add both the interface and core clock. Signed-off-by: Douglas Anderson ---

Re: [RFC PATCH 2/2] clk: qcom: Add qspi (Quad SPI) clocks for sdm845

2018-07-19 Thread Doug Anderson
Hi, On Thu, Jul 19, 2018 at 4:04 AM, Taniya Das wrote: > Hi Doug, > > Please find my comments inline. > > On 7/18/2018 11:34 PM, Douglas Anderson wrote: >> >> Add both the interface and core clock. >> >> Signed-off-by: Douglas Anderson >> --- >> >> drivers/clk/qcom/gcc-sdm845.c | 73

Re: [RFC PATCH 2/2] clk: qcom: Add qspi (Quad SPI) clocks for sdm845

2018-07-19 Thread Doug Anderson
Hi, On Thu, Jul 19, 2018 at 4:04 AM, Taniya Das wrote: > Hi Doug, > > Please find my comments inline. > > On 7/18/2018 11:34 PM, Douglas Anderson wrote: >> >> Add both the interface and core clock. >> >> Signed-off-by: Douglas Anderson >> --- >> >> drivers/clk/qcom/gcc-sdm845.c | 73

Re: [RFC PATCH 2/2] clk: qcom: Add qspi (Quad SPI) clocks for sdm845

2018-07-19 Thread Taniya Das
Hi Doug, Please find my comments inline. On 7/18/2018 11:34 PM, Douglas Anderson wrote: Add both the interface and core clock. Signed-off-by: Douglas Anderson --- drivers/clk/qcom/gcc-sdm845.c | 73 +++ 1 file changed, 73 insertions(+) diff --git

Re: [RFC PATCH 2/2] clk: qcom: Add qspi (Quad SPI) clocks for sdm845

2018-07-19 Thread Taniya Das
Hi Doug, Please find my comments inline. On 7/18/2018 11:34 PM, Douglas Anderson wrote: Add both the interface and core clock. Signed-off-by: Douglas Anderson --- drivers/clk/qcom/gcc-sdm845.c | 73 +++ 1 file changed, 73 insertions(+) diff --git

Re: [RFC PATCH 2/2] clk: qcom: Add qspi (Quad SPI) clocks for sdm845

2018-07-18 Thread grahamr
On 2018-07-18 11:04, Douglas Anderson wrote: Add both the interface and core clock. Signed-off-by: Douglas Anderson --- drivers/clk/qcom/gcc-sdm845.c | 73 +++ 1 file changed, 73 insertions(+) diff --git a/drivers/clk/qcom/gcc-sdm845.c

Re: [RFC PATCH 2/2] clk: qcom: Add qspi (Quad SPI) clocks for sdm845

2018-07-18 Thread grahamr
On 2018-07-18 11:04, Douglas Anderson wrote: Add both the interface and core clock. Signed-off-by: Douglas Anderson --- drivers/clk/qcom/gcc-sdm845.c | 73 +++ 1 file changed, 73 insertions(+) diff --git a/drivers/clk/qcom/gcc-sdm845.c

[RFC PATCH 2/2] clk: qcom: Add qspi (Quad SPI) clocks for sdm845

2018-07-18 Thread Douglas Anderson
Add both the interface and core clock. Signed-off-by: Douglas Anderson --- drivers/clk/qcom/gcc-sdm845.c | 73 +++ 1 file changed, 73 insertions(+) diff --git a/drivers/clk/qcom/gcc-sdm845.c b/drivers/clk/qcom/gcc-sdm845.c index 0f694ed4238a..2ee96f9bc217

[RFC PATCH 2/2] clk: qcom: Add qspi (Quad SPI) clocks for sdm845

2018-07-18 Thread Douglas Anderson
Add both the interface and core clock. Signed-off-by: Douglas Anderson --- drivers/clk/qcom/gcc-sdm845.c | 73 +++ 1 file changed, 73 insertions(+) diff --git a/drivers/clk/qcom/gcc-sdm845.c b/drivers/clk/qcom/gcc-sdm845.c index 0f694ed4238a..2ee96f9bc217